{"id":811277,"url":"http://patchwork.ozlabs.org/api/patches/811277/?format=json","web_url":"http://patchwork.ozlabs.org/project/skiboot/patch/20170908004605.5125-1-oohall@gmail.com/","project":{"id":44,"url":"http://patchwork.ozlabs.org/api/projects/44/?format=json","name":"skiboot firmware development","link_name":"skiboot","list_id":"skiboot.lists.ozlabs.org","list_email":"skiboot@lists.ozlabs.org","web_url":"http://github.com/open-power/skiboot","scm_url":"http://github.com/open-power/skiboot","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908004605.5125-1-oohall@gmail.com>","list_archive_url":null,"date":"2017-09-08T00:46:05","name":"hdata: Fix /vpd dtc warnings","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2c8c5d47dfeb69b7faa5c4852bd2608c2366e225","submitter":{"id":68108,"url":"http://patchwork.ozlabs.org/api/people/68108/?format=json","name":"Oliver O'Halloran","email":"oohall@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/skiboot/patch/20170908004605.5125-1-oohall@gmail.com/mbox/","series":[{"id":2082,"url":"http://patchwork.ozlabs.org/api/series/2082/?format=json","web_url":"http://patchwork.ozlabs.org/project/skiboot/list/?series=2082","date":"2017-09-08T00:46:05","name":"hdata: Fix /vpd dtc warnings","version":1,"mbox":"http://patchwork.ozlabs.org/series/2082/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811277/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811277/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpJY46fc5z9sCZ\n\tfor ;\n\tFri, 8 Sep 2017 10:46:32 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xpJY45JPTzDrZ8\n\tfor ;\n\tFri, 8 Sep 2017 10:46:32 +1000 (AEST)","from mail-pg0-x244.google.com (mail-pg0-x244.google.com\n\t[IPv6:2607:f8b0:400e:c05::244])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xpJXv5NclzDrXy\n\tfor ; Fri, 8 Sep 2017 10:46:23 +1000 (AEST)","by mail-pg0-x244.google.com with SMTP id d8so598153pgt.3\n\tfor ; Thu, 07 Sep 2017 17:46:23 -0700 (PDT)","from flat-canetoad.ozlabs.ibm.com ([122.99.82.10])\n\tby smtp.gmail.com with ESMTPSA id\n\tb4sm964836pfa.98.2017.09.07.17.46.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 07 Sep 2017 17:46:20 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"inFQSZIE\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"inFQSZIE\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::244; helo=mail-pg0-x244.google.com;\n\tenvelope-from=oohall@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"inFQSZIE\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=BNitbepfPaW7EfQ228RZD1kstqlHFj4JPxqj/ep/Goc=;\n\tb=inFQSZIENYKuqUzIjgWc/5nBVwA/8N+OYpAe5Rnv1d3c7Io+0Ll8Tfnc2ezL1Hl27s\n\trlC97CBOR8JatbCmYHCk9L7wAUtTG4zvlrptJcMjn3w2x5J/eELXVadzZYvetu8Kkk/b\n\tYQ1RSfAJJO5AY9q+QDl6bntPJwg667DsT1BERZzU8+oG8p4uvlORJAkqJT1xWoQleHCo\n\tCWOt4D1qSX6FWMlxj2oeYVwpqW/zoCT1KNt+A43WlTNUJw5y3VCKe38ET2bi0PoBHscD\n\t6gKM1pREAzvnXtbC2WifXymBzZjdlfn6JrqSHxIQJgHgyYsS29/dlJf1led+lbAXmpPo\n\tbtjQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=BNitbepfPaW7EfQ228RZD1kstqlHFj4JPxqj/ep/Goc=;\n\tb=g5Yz1vcrk+lAfPGYHI1QuK5TlV7tGKWRURMZLnWtLVdzU+zQwSnhJRwTuhd4uYGhQl\n\tEcpcyo7RJjZgXY9ocZG9D7L+Vw7EutuJToH36yfCxxuUUtHp9Fxx7WxMPhlvjQ900F7P\n\tEuOonrN5f0Yd6ycgW2tL5XvnxB1mYBcHmWiGzxIHh6095yV49H8yQe7a9Nf2CgVA5BrK\n\t0wMMew3VSofsNCyrNHRZnK7L5EdtUtXmdW/b21bqmO1TvEHkuLCPSQlrDG1EKcpuHqSI\n\tcXD+yfSm31K15La5w7EkNIiSH9Bu+XACT2MEek4zFQB4yLxKWrBtIUGHYBEEr9vxbiPQ\n\tQSlw==","X-Gm-Message-State":"AHPjjUjs/eXs2xMi9+s5NILyAyHAsywu12a5M5hPXP3m/UPG3FmwSCWV\n\t1txTTNDxJONm0JHl","X-Google-Smtp-Source":"ADKCNb44xCTEHSesinSpipGRb6MADCQzUJ3MPIlE+1wgwLIV6Xklvc0v7gme0yisCsTmb9NdawiX6w==","X-Received":"by 10.98.98.196 with SMTP id w187mr1223950pfb.235.1504831581326; \n\tThu, 07 Sep 2017 17:46:21 -0700 (PDT)","From":"Oliver O'Halloran ","To":"skiboot@lists.ozlabs.org","Date":"Fri, 8 Sep 2017 10:46:05 +1000","Message-Id":"<20170908004605.5125-1-oohall@gmail.com>","X-Mailer":"git-send-email 2.9.5","Subject":"[Skiboot] [PATCH] hdata: Fix /vpd dtc warnings","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"},"content":"When dealing with HDAT generated device-trees dtc will complain loudly\nabout the missing reg, #size-cells and #address-cells properties of the\nnodes in the /vpd hierarchy. This patch fixes these so we get a bit more\nsignal and less noise from the dtc warnings.\n\nSigned-off-by: Oliver O'Halloran \n---\n hdata/spira.c | 3 +++\n hdata/vpd.c | 8 ++++++++\n 2 files changed, 11 insertions(+)","diff":"diff --git a/hdata/spira.c b/hdata/spira.c\nindex 95e1a016642e..291365e82c81 100644\n--- a/hdata/spira.c\n+++ b/hdata/spira.c\n@@ -1181,7 +1181,10 @@ static void dt_init_vpd_node(void)\n \n \tdt_vpd = dt_new(dt_root, \"vpd\");\n \tassert(dt_vpd);\n+\n \tdt_add_property_string(dt_vpd, \"compatible\", \"ibm,opal-v3-vpd\");\n+\tdt_add_property_cells(dt_vpd, \"#address-cells\", 1);\n+\tdt_add_property_cells(dt_vpd, \"#size-cells\", 0);\n }\n \n static void hostservices_parse(void)\ndiff --git a/hdata/vpd.c b/hdata/vpd.c\nindex d7d57cdad67c..9f3fe010c3e8 100644\n--- a/hdata/vpd.c\n+++ b/hdata/vpd.c\n@@ -405,6 +405,14 @@ static struct dt_node *dt_create_vpd_node(struct dt_node *parent,\n \t\treturn NULL;\n \t}\n \n+\t/*\n+\t * no one is sure what this is or what it means, we're adding it here\n+\t * to stop dtc from complaining about it.\n+\t */\n+\tdt_add_property_cells(node, \"reg\", addr);\n+\tdt_add_property_cells(node, \"#address-cells\", 1);\n+\tdt_add_property_cells(node, \"#size-cells\", 0);\n+\n \t/* Add location code */\n \tslca_vpd_add_loc_code(node, be16_to_cpu(entry->my_index));\n \t/* Add FRU label */\n","prefixes":[]}