{"id":811223,"url":"http://patchwork.ozlabs.org/api/patches/811223/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20170907224219.12483-26-albert.aribaud@3adev.fr/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170907224219.12483-26-albert.aribaud@3adev.fr>","list_archive_url":null,"date":"2017-09-07T22:41:52","name":"[RFC,25/52] Y2038: add function __stat64_t64 (and __xstat64_t64)","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6e3de8394168edaa556658730efe9068f6e764c1","submitter":{"id":65557,"url":"http://patchwork.ozlabs.org/api/people/65557/?format=json","name":"Albert ARIBAUD (3ADEV)","email":"albert.aribaud@3adev.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170907224219.12483-26-albert.aribaud@3adev.fr/mbox/","series":[{"id":2074,"url":"http://patchwork.ozlabs.org/api/series/2074/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=2074","date":"2017-09-07T22:41:27","name":"Make GLIBC Y2038-proof","version":1,"mbox":"http://patchwork.ozlabs.org/series/2074/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811223/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811223/checks/","tags":{},"related":[],"headers":{"Return-Path":"<libc-alpha-return-84343-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84343-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"Jd6djU+m\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpFvR3zCqz9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 08:47:15 +1000 (AEST)","(qmail 84081 invoked by alias); 7 Sep 2017 22:44:16 -0000","(qmail 84011 invoked by uid 89); 7 Sep 2017 22:44:16 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=QkOKDuAxQWpKZM85JiCd6GiLnu0fuRA\n\thbqLOo6BfdksxnUmRrOyf20QTY78H2TCUWctnnMfXmD6gVNxsqADRllrXj6Z4i8o\n\t4iygT+cnatqk8izy3EVrm32XVQI07Asid48JZ9+r9w6WiVwWVMkoLdRBZAwR2SNE\n\t01qCQfcdhAQQ=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=dcDDRykAg/5OxG1rY6NNt16ebiE=; b=Jd6dj\n\tU+mfj6GyIalLzY9BMxge8FKIiFV0G5MC7oEKaVGzx0yhUPHogrE9JF+4UdrFmXTA\n\tS8uCDdYVh8/YxyGvNpkfonp+9U3Z1zQL1IBE29pvKG3cChsb1KZqlFEiXN9+OQeQ\n\tvq9ut6H/ZmkdeDMVYn8lzcmIBuQLOo/yqbTHdY=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.6 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tKAM_LAZY_DOMAIN_SECURITY,\n\tRCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=","X-HELO":"smtp6-g21.free.fr","From":"\"Albert ARIBAUD (3ADEV)\" <albert.aribaud@3adev.fr>","To":"libc-alpha@sourceware.org","Cc":"\"Albert ARIBAUD (3ADEV)\" <albert.aribaud@3adev.fr>","Subject":"[RFC PATCH 25/52] Y2038: add function __stat64_t64 (and\n\t__xstat64_t64)","Date":"Fri,  8 Sep 2017 00:41:52 +0200","Message-Id":"<20170907224219.12483-26-albert.aribaud@3adev.fr>","In-Reply-To":"<20170907224219.12483-25-albert.aribaud@3adev.fr>","References":"<20170907224219.12483-1-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-2-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-3-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-4-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-5-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-6-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-7-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-8-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-9-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-10-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-11-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-12-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-13-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-14-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-15-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-16-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-17-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-18-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-19-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-20-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-21-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-22-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-23-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-24-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-25-albert.aribaud@3adev.fr>"},"content":"There is no Y2038-proof linux struct stat for now, so these\nimplementations just use the existing syscalls and convert from kernel\n32-bit-time struct stat64 to GLIBC Y2038-ready struct __stat64_t64.\n\nSigned-off-by: Albert ARIBAUD (3ADEV) <albert.aribaud@3adev.fr>\n---\n include/sys/stat.h                |  2 ++\n io/Versions                       |  1 +\n io/stat64.c                       |  7 ++++++\n sysdeps/unix/sysv/linux/xstat64.c | 50 +++++++++++++++++++++++++++++++++++++++\n 4 files changed, 60 insertions(+)","diff":"diff --git a/include/sys/stat.h b/include/sys/stat.h\nindex 2961849e35..8cd3fbedae 100644\n--- a/include/sys/stat.h\n+++ b/include/sys/stat.h\n@@ -39,6 +39,8 @@ extern int __mknod (const char *__path,\n \t\t    __mode_t __mode, __dev_t __dev);\n extern int __fxstat64_t64 (int __ver, int __fildes,\n                            struct __stat64_t64 *__stat_buf);\n+extern int __xstat64_t64 (int __ver, const char *__filename,\n+                          struct __stat64_t64 *__stat_buf);\n #if IS_IN (libc) || IS_IN (rtld)\n hidden_proto (__fxstat)\n hidden_proto (__fxstat64)\ndiff --git a/io/Versions b/io/Versions\nindex 747ae5d9d6..e2befdbdf7 100644\n--- a/io/Versions\n+++ b/io/Versions\n@@ -131,5 +131,6 @@ libc {\n \n   GLIBC_Y2038 {\n     __fxstat64_t64;\n+    __xstat64_t64;\n   }\n }\ndiff --git a/io/stat64.c b/io/stat64.c\nindex 704cbb34a6..22fc0db13d 100644\n--- a/io/stat64.c\n+++ b/io/stat64.c\n@@ -50,3 +50,10 @@ stat64 (const char *file, struct stat64 *buf)\n {\n   return __xstat64 (_STAT_VER, file, buf);\n }\n+\n+int\n+attribute_hidden\n+__stat64_t64 (const char *file, struct __stat64_t64 *buf)\n+{\n+  return __xstat64_t64 (_STAT_VER, file, buf);\n+}\ndiff --git a/sysdeps/unix/sysv/linux/xstat64.c b/sysdeps/unix/sysv/linux/xstat64.c\nindex b3fbe6a383..325ed36d1d 100644\n--- a/sysdeps/unix/sysv/linux/xstat64.c\n+++ b/sysdeps/unix/sysv/linux/xstat64.c\n@@ -24,6 +24,8 @@\n #include <sysdep.h>\n #include <sys/syscall.h>\n \n+#include <xstatconv.h>\n+\n #include <kernel-features.h>\n \n /* Get information about the file NAME in BUF.  */\n@@ -52,3 +54,51 @@ hidden_ver (___xstat64, __xstat64)\n strong_alias (___xstat64, __xstat64)\n hidden_def (__xstat64)\n #endif\n+\n+/* 64-bit time version */\n+\n+extern int __y2038_linux_support;\n+\n+int\n+__xstat64_t64 (int vers, const char *name, struct __stat64_t64 *buf)\n+{\n+  int result;\n+  struct stat64 st64;\n+\n+  if (__y2038_linux_support)\n+    {\n+      // TODO: use 64-bit syscalls when they become available\n+    }\n+\n+  result = INLINE_SYSCALL (stat64, 2, name, &st64);\n+#if defined _HAVE_STAT64___ST_INO && !__ASSUME_ST_INO_64_BIT\n+  if (__builtin_expect (!result, 1) && st64.__st_ino != (__ino_t) st64.st_ino)\n+    st64.st_ino = st64.__st_ino;\n+#endif\n+  if (!result)\n+    {\n+      buf->st_dev          = st64.st_dev;\n+      buf->__pad1\t\t     = st64.__pad1;\n+    \n+      buf->__st_ino        = st64.__st_ino;\n+      buf->st_mode         = st64.st_mode;\n+      buf->st_nlink        = st64.st_nlink;\n+      buf->st_uid          = st64.st_uid;\t\t \n+      buf->st_gid          = st64.st_gid;\t\t \n+      buf->st_rdev         = st64.st_rdev;\t\t \n+      buf->__pad2          = st64.__pad2;\n+      buf->st_size         = st64.st_size;\t\t \n+      buf->st_blksize      = st64.st_blksize;\n+    \n+      buf->st_blocks       = st64.st_blocks;\t\t\n+      buf->st_atim.tv_sec  = st64.st_ctim.tv_sec;\t\n+      buf->st_atim.tv_nsec = st64.st_atim.tv_nsec;\t\n+      buf->st_mtim.tv_sec  = st64.st_mtim.tv_sec;\t\n+      buf->st_mtim.tv_nsec = st64.st_mtim.tv_nsec;\t\n+      buf->st_ctim.tv_sec  = st64.st_ctim.tv_sec;\t\n+      buf->st_ctim.tv_nsec = st64.st_ctim.tv_nsec;\t\n+    \n+      buf->st_ino          = st64.st_ino;\n+    }\n+  return result;\n+}\n","prefixes":["RFC","25/52"]}