{"id":811156,"url":"http://patchwork.ozlabs.org/api/patches/811156/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907201335.13956-13-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170907201335.13956-13-david@redhat.com>","list_archive_url":null,"date":"2017-09-07T20:13:26","name":"[v3,12/21] target/s390x: set cpu->id for linux user when realizing","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3ff8e61ce09563669f32751b034e8db617effbb2","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907201335.13956-13-david@redhat.com/mbox/","series":[{"id":2053,"url":"http://patchwork.ozlabs.org/api/series/2053/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2053","date":"2017-09-07T20:13:14","name":"s390x cleanups and CPU hotplug via device_add","version":3,"mbox":"http://patchwork.ozlabs.org/series/2053/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811156/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811156/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpBn5238gz9sBW\n\tfor ;\n\tFri, 8 Sep 2017 06:26:33 +1000 (AEST)","from localhost ([::1]:42154 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dq3Nf-0006R6-CD\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 16:26:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39004)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dq3Bu-0004LO-4O\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 16:14:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dq3Bp-0002JQ-Ao\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 16:14:22 -0400","from mx1.redhat.com ([209.132.183.28]:37298)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dq3Bp-0002J1-4d\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 16:14:17 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3A9004E4F3;\n\tThu, 7 Sep 2017 20:14:16 +0000 (UTC)","from t460s.redhat.com (ovpn-116-60.ams2.redhat.com [10.36.116.60])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id ED72B17117;\n\tThu, 7 Sep 2017 20:14:13 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3A9004E4F3","From":"David Hildenbrand ","To":"qemu-devel@nongnu.org","Date":"Thu, 7 Sep 2017 22:13:26 +0200","Message-Id":"<20170907201335.13956-13-david@redhat.com>","In-Reply-To":"<20170907201335.13956-1-david@redhat.com>","References":"<20170907201335.13956-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 07 Sep 2017 20:14:16 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v3 12/21] target/s390x: set cpu->id for linux\n\tuser when realizing","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost , david@redhat.com,\n\tcohuck@redhat.com, Richard Henderson ,\n\tAlexander Graf , borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"scc->next_cpu_id is updated when realizing. Setting it just before that\npoint looks cleaner.\n\nReviewed-by: Matthew Rosato \nSigned-off-by: David Hildenbrand \n---\n target/s390x/cpu.c | 11 ++++-------\n 1 file changed, 4 insertions(+), 7 deletions(-)","diff":"diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c\nindex 74b3e4fd0d..5f9315fb16 100644\n--- a/target/s390x/cpu.c\n+++ b/target/s390x/cpu.c\n@@ -194,7 +194,11 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n \", max allowed: %d\", cpu->id, max_cpus - 1);\n goto out;\n }\n+#else\n+ /* implicitly set for linux-user only */\n+ cpu->id = scc->next_cpu_id;\n #endif\n+\n if (cpu_exists(cpu->id)) {\n error_setg(&err, \"Unable to add CPU: %\" PRIi64\n \", it already exists\", cpu->id);\n@@ -306,13 +310,6 @@ static void s390_cpu_initfn(Object *obj)\n inited = true;\n s390x_translate_init();\n }\n-\n-#if defined(CONFIG_USER_ONLY)\n- {\n- S390CPUClass *scc = S390_CPU_GET_CLASS(obj);\n- cpu->id = scc->next_cpu_id;\n- }\n-#endif\n }\n \n static void s390_cpu_finalize(Object *obj)\n","prefixes":["v3","12/21"]}