{"id":810679,"url":"http://patchwork.ozlabs.org/api/patches/810679/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/150471163020.18882.9386672218918089445.stgit@frigg.lan/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<150471163020.18882.9386672218918089445.stgit@frigg.lan>","list_archive_url":null,"date":"2017-09-06T15:27:10","name":"trace: Immediately apply per-vCPU state changes if a vCPU is being created","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e1148b179ee86b3a54d38cfb4563c3f3b090796b","submitter":{"id":9099,"url":"http://patchwork.ozlabs.org/api/people/9099/?format=json","name":"Lluís Vilanova","email":"vilanova@ac.upc.edu"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/150471163020.18882.9386672218918089445.stgit@frigg.lan/mbox/","series":[{"id":1837,"url":"http://patchwork.ozlabs.org/api/series/1837/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1837","date":"2017-09-06T15:27:10","name":"trace: Immediately apply per-vCPU state changes if a vCPU is being created","version":1,"mbox":"http://patchwork.ozlabs.org/series/1837/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810679/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810679/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnSCg0RWPz9t5Q\n\tfor ;\n\tThu, 7 Sep 2017 01:28:31 +1000 (AEST)","from localhost ([::1]:36719 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpcFh-0001Id-6s\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 11:28:29 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55922)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpcEf-0000h8-VB\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:27:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpcEb-0000FY-64\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:27:25 -0400","from roura.ac.upc.es ([147.83.33.10]:49193)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpcEa-00009E-Qw\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:27:21 -0400","from correu-2.ac.upc.es (correu-2.ac.upc.es [147.83.30.92])\n\tby roura.ac.upc.es (8.13.8/8.13.8) with ESMTP id v86FRIcJ032741;\n\tWed, 6 Sep 2017 17:27:18 +0200","from localhost (unknown [132.68.137.228])\n\tby correu-2.ac.upc.es (Postfix) with ESMTPSA id 96C7E126C;\n\tWed, 6 Sep 2017 17:27:12 +0200 (CEST)"],"From":"=?utf-8?b?TGx1w61z?= Vilanova ","To":"qemu-devel@nongnu.org","Date":"Wed, 6 Sep 2017 18:27:10 +0300","Message-Id":"<150471163020.18882.9386672218918089445.stgit@frigg.lan>","X-Mailer":"git-send-email 2.14.1","User-Agent":"StGit/0.17.1-dirty","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by roura.ac.upc.es id\n\tv86FRIcJ032741","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]","X-Received-From":"147.83.33.10","Subject":"[Qemu-devel] [PATCH] trace: Immediately apply per-vCPU state\n\tchanges if a vCPU is being created","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"stefanha@gmail.com, Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Right now, function trace_event_set_vcpu_state_dynamic() asynchronously enables\nevents in the case a vCPU is executing TCG code. If the vCPU is being created\nthis makes some events like \"guest_cpu_enter\" to not be traced.\n\nSigned-off-by: Lluís Vilanova \n---\n trace/control-target.c | 19 ++++++++++++-------\n 1 file changed, 12 insertions(+), 7 deletions(-)","diff":"diff --git a/trace/control-target.c b/trace/control-target.c\nindex 4e36101997..0056da6a46 100644\n--- a/trace/control-target.c\n+++ b/trace/control-target.c\n@@ -88,13 +88,18 @@ void trace_event_set_vcpu_state_dynamic(CPUState *vcpu,\n clear_bit(vcpu_id, vcpu->trace_dstate_delayed);\n (*ev->dstate)--;\n }\n- /*\n- * Delay changes until next TB; we want all TBs to be built from a\n- * single set of dstate values to ensure consistency of generated\n- * tracing code.\n- */\n- async_run_on_cpu(vcpu, trace_event_synchronize_vcpu_state_dynamic,\n- RUN_ON_CPU_NULL);\n+ if (vcpu->created) {\n+ /*\n+ * Delay changes until next TB; we want all TBs to be built from a\n+ * single set of dstate values to ensure consistency of generated\n+ * tracing code.\n+ */\n+ async_run_on_cpu(vcpu, trace_event_synchronize_vcpu_state_dynamic,\n+ RUN_ON_CPU_NULL);\n+ } else {\n+ run_on_cpu_data ignored;\n+ trace_event_synchronize_vcpu_state_dynamic(vcpu, ignored);\n+ }\n }\n }\n \n","prefixes":[]}