{"id":810678,"url":"http://patchwork.ozlabs.org/api/patches/810678/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906152111.16958-3-eblake@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170906152111.16958-3-eblake@redhat.com>","list_archive_url":null,"date":"2017-09-06T15:21:08","name":"[PULL,2/5] iotests: blacklist 194 with the luks driver","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"65b195280110f8f5689a112b505a487340ec72d0","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/?format=json","name":"Eric Blake","email":"eblake@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906152111.16958-3-eblake@redhat.com/mbox/","series":[{"id":1834,"url":"http://patchwork.ozlabs.org/api/series/1834/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1834","date":"2017-09-06T15:21:06","name":"[PULL,1/5] iotests: rewrite 192 to use _launch_qemu to fix LUKS support","version":1,"mbox":"http://patchwork.ozlabs.org/series/1834/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810678/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810678/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnSBK3CYpz9s03\n\tfor ;\n\tThu, 7 Sep 2017 01:27:21 +1000 (AEST)","from localhost ([::1]:36715 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpcEZ-0000Mz-Hu\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 11:27:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53914)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpc91-0004FJ-NN\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:21:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpc8w-0007Bw-2y\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:21:35 -0400","from mx1.redhat.com ([209.132.183.28]:17314)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpc8p-0006wk-Jj; Wed, 06 Sep 2017 11:21:23 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A508319CFE6;\n\tWed, 6 Sep 2017 15:21:22 +0000 (UTC)","from red.redhat.com (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 115F787801;\n\tWed, 6 Sep 2017 15:21:20 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A508319CFE6","From":"Eric Blake ","To":"qemu-devel@nongnu.org","Date":"Wed, 6 Sep 2017 10:21:08 -0500","Message-Id":"<20170906152111.16958-3-eblake@redhat.com>","In-Reply-To":"<20170906152111.16958-1-eblake@redhat.com>","References":"<20170906152111.16958-1-eblake@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 06 Sep 2017 15:21:22 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 2/5] iotests: blacklist 194 with the luks driver","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf ,\n\t\"open list:Block layer core\" ,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: \"Daniel P. Berrange\" \n\nThe 194 test has a lot of code that assumes a simple image file. Rewriting\nthis to work with luks is possible, but non-trivial, so blacklist the\nluks format for now.\n\nSigned-off-by: Daniel P. Berrange \nMessage-Id: <20170901105434.3288-3-berrange@redhat.com>\nReviewed-by: Eric Blake \nTested-by: Fam Zheng \n[eblake: commit message typo fixed]\nReviewed-by: Kashyap Chamarthy \nReviewed-by: Stefan Hajnoczi \nSigned-off-by: Eric Blake \n---\n tests/qemu-iotests/194 | 1 +\n tests/qemu-iotests/iotests.py | 4 +++-\n 2 files changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194\nindex 6449b9b64a..8d973b440f 100755\n--- a/tests/qemu-iotests/194\n+++ b/tests/qemu-iotests/194\n@@ -21,6 +21,7 @@\n\n import iotests\n\n+iotests.verify_image_format(unsupported_fmts=['luks'])\n iotests.verify_platform(['linux'])\n\n with iotests.FilePath('source.img') as source_img_path, \\\ndiff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py\nindex 07fa1626a0..1af117e37d 100644\n--- a/tests/qemu-iotests/iotests.py\n+++ b/tests/qemu-iotests/iotests.py\n@@ -421,9 +421,11 @@ def notrun(reason):\n print '%s not run: %s' % (seq, reason)\n sys.exit(0)\n\n-def verify_image_format(supported_fmts=[]):\n+def verify_image_format(supported_fmts=[], unsupported_fmts=[]):\n if supported_fmts and (imgfmt not in supported_fmts):\n notrun('not suitable for this image format: %s' % imgfmt)\n+ if unsupported_fmts and (imgfmt in unsupported_fmts):\n+ notrun('not suitable for this image format: %s' % imgfmt)\n\n def verify_platform(supported_oses=['linux']):\n if True not in [sys.platform.startswith(x) for x in supported_oses]:\n","prefixes":["PULL","2/5"]}