{"id":810676,"url":"http://patchwork.ozlabs.org/api/patches/810676/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906152111.16958-2-eblake@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170906152111.16958-2-eblake@redhat.com>","list_archive_url":null,"date":"2017-09-06T15:21:07","name":"[PULL,1/5] iotests: rewrite 192 to use _launch_qemu to fix LUKS support","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f4f89fe600763920103e9fd92fa6fb742d37b2a4","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/?format=json","name":"Eric Blake","email":"eblake@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906152111.16958-2-eblake@redhat.com/mbox/","series":[{"id":1834,"url":"http://patchwork.ozlabs.org/api/series/1834/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1834","date":"2017-09-06T15:21:06","name":"[PULL,1/5] iotests: rewrite 192 to use _launch_qemu to fix LUKS support","version":1,"mbox":"http://patchwork.ozlabs.org/series/1834/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810676/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810676/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnS8y6GBLz9t5Q\n\tfor ;\n\tThu, 7 Sep 2017 01:26:10 +1000 (AEST)","from localhost ([::1]:36711 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpcDQ-0007sW-2J\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 11:26:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53926)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpc92-0004GF-UE\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:21:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpc8y-0007D1-TW\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:21:36 -0400","from mx1.redhat.com ([209.132.183.28]:44590)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpc8n-0006tL-OY; Wed, 06 Sep 2017 11:21:21 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CAF887F351;\n\tWed, 6 Sep 2017 15:21:20 +0000 (UTC)","from red.redhat.com (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6773D61F36;\n\tWed, 6 Sep 2017 15:21:19 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CAF887F351","From":"Eric Blake ","To":"qemu-devel@nongnu.org","Date":"Wed, 6 Sep 2017 10:21:07 -0500","Message-Id":"<20170906152111.16958-2-eblake@redhat.com>","In-Reply-To":"<20170906152111.16958-1-eblake@redhat.com>","References":"<20170906152111.16958-1-eblake@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 06 Sep 2017 15:21:20 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 1/5] iotests: rewrite 192 to use _launch_qemu to\n\tfix LUKS support","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf ,\n\t\"open list:Block layer core\" ,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: \"Daniel P. Berrange\" \n\nThe LUKS driver requires extra args to QEMU to setup passwords.\nThe _launch_qemu function takes care of this, so convert the\ntest to use this function and use correct -drive syntax\n\nSigned-off-by: Daniel P. Berrange \nMessage-Id: <20170901105434.3288-2-berrange@redhat.com>\nReviewed-by: Eric Blake \nTested-by: Fam Zheng \nSigned-off-by: Eric Blake \n---\n tests/qemu-iotests/192 | 23 ++++++++++++++++-------\n 1 file changed, 16 insertions(+), 7 deletions(-)","diff":"diff --git a/tests/qemu-iotests/192 b/tests/qemu-iotests/192\nindex b50a2c0c8e..595f0d786a 100755\n--- a/tests/qemu-iotests/192\n+++ b/tests/qemu-iotests/192\n@@ -37,6 +37,7 @@ trap \"_cleanup; exit \\$status\" 0 1 2 3 15\n # get standard environment, filters and checks\n . ./common.rc\n . ./common.filter\n+. ./common.qemu\n\n _supported_fmt generic\n _supported_proto file\n@@ -49,13 +50,21 @@ fi\n size=64M\n _make_test_img $size\n\n-{\n-echo \"nbd_server_start unix:$TEST_DIR/nbd\"\n-echo \"nbd_server_add -w drive0\"\n-echo \"q\"\n-} | $QEMU -nodefaults -display none -monitor stdio \\\n- -drive format=$IMGFMT,file=$TEST_IMG,if=ide,id=drive0 \\\n- -incoming defer 2>&1 | _filter_testdir | _filter_qemu | _filter_hmp\n+if test \"$IMGOPTSSYNTAX\" = \"true\"\n+then\n+ DRIVE_ARG=if=ide,id=drive0,$TEST_IMG\n+else\n+ DRIVE_ARG=if=ide,id=drive0,format=$IMGFMT,file=$TEST_IMG\n+fi\n+\n+qemu_comm_method=\"monitor\"\n+_launch_qemu -drive $DRIVE_ARG -incoming defer\n+h=$QEMU_HANDLE\n+QEMU_COMM_TIMEOUT=1\n+\n+_send_qemu_cmd $h \"nbd_server_start unix:$TEST_DIR/nbd\" \"(qemu)\"\n+_send_qemu_cmd $h \"nbd_server_add -w drive0\" \"(qemu)\"\n+_send_qemu_cmd $h \"q\" \"(qemu)\"\n\n # success, all done\n echo \"*** done\"\n","prefixes":["PULL","1/5"]}