{"id":810609,"url":"http://patchwork.ozlabs.org/api/patches/810609/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170906133928.3152020-1-arnd@arndb.de/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170906133928.3152020-1-arnd@arndb.de>","list_archive_url":null,"date":"2017-09-06T13:38:58","name":"isdn: isdnloop: fix logic error in isdnloop_sendbuf","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"30a9e4a11732d2dd3a8e663b3e23d2d76bb5769b","submitter":{"id":30,"url":"http://patchwork.ozlabs.org/api/people/30/?format=json","name":"Arnd Bergmann","email":"arnd@arndb.de"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170906133928.3152020-1-arnd@arndb.de/mbox/","series":[{"id":1810,"url":"http://patchwork.ozlabs.org/api/series/1810/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=1810","date":"2017-09-06T13:38:58","name":"isdn: isdnloop: fix logic error in isdnloop_sendbuf","version":1,"mbox":"http://patchwork.ozlabs.org/series/1810/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810609/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810609/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnPpk1h9rz9sNV\n\tfor ;\n\tWed, 6 Sep 2017 23:40:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932086AbdIFNkA (ORCPT );\n\tWed, 6 Sep 2017 09:40:00 -0400","from mout.kundenserver.de ([212.227.17.10]:60845 \"EHLO\n\tmout.kundenserver.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753034AbdIFNj6 (ORCPT\n\t); Wed, 6 Sep 2017 09:39:58 -0400","from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de\n\t(mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id\n\t0MRDAN-1du9gO0FPb-00Ud7z; Wed, 06 Sep 2017 15:39:35 +0200"],"From":"Arnd Bergmann ","To":"Karsten Keil ","Cc":"Arnd Bergmann , Joe Perches ,\n\t\"David S. Miller\" , netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH] isdn: isdnloop: fix logic error in isdnloop_sendbuf","Date":"Wed, 6 Sep 2017 15:38:58 +0200","Message-Id":"<20170906133928.3152020-1-arnd@arndb.de>","X-Mailer":"git-send-email 2.9.0","X-Provags-ID":"V03:K0:raM9FXQN9EybXU5q5y1SPfvmcHZ/mCn3F0G45FzBcBcRLKsa2Xo\n\tBHOPAt+DQq1BOO76LaGipAEQf23WQ2emtTlO0Mnqesbs8Os7HsiJbQPLExWJQqjSuDe/8jd\n\tW4GSwg62TK/OybiVxjOV0dVDfTZSux5HZORc+FN0NN+B6VhYoqKGLfrylmRGlughO5XW2kH\n\tpBEXWVvmIxUes+sP8CXlw==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:9WTjgjyP7Ps=:rvq73VEns7/4Q5I8CPZa15\n\tf6POZMY/Vwa7P30BTlzNl1YfuoURDB9+yBOnr+97/4KZpppnDQjK0Jte09wK7B7XPJwTCiUp3\n\tvO+371OTQts+mT87ZZbVM0zCkrhAZq+BiribyU6RjdeHs68KnRC8FnqNrVOLOg86WjN5nMC40\n\tc0/LW6by9KPGpo58GIkm2w7xfWiriz3YWILqiVvhYCZ8b/QNzxCxfaSCBzk11wDT8HcXivJ63\n\ttl4ll/sgkVEiAvkAJBSxfkcupRqSd7n40/s7TsZFKfJyaNMXWhC/7njrjUYxj03wfJd47uvJB\n\tn1TGYYJAQZ73HOOEhmoe9tvI4Uuxdz6GipOEB1EkKSoU/IKbmkCYGAWkGWbeKSmm+IKi/o+v2\n\tYA/NO3grSRlAgr+blfRnqL1k0ohUOwgUpxM/3wgqomnd5q8Ohll0okB1UMsvul0KvySt6c3AK\n\tXExZ4tWKQXBeF0u/4My34HRaXd6nZeHu+XYIzg3NgGZ68HFq5aC3oMYi+1PYK4RTn0PjxELzq\n\tcCHcT5Fba3o5rsGedNG5c5O7Wia5D+FlDJIiluLfYlrCvr6UPA5vysOTh7NUdofgAyX8MsELo\n\tyhJTSR1b+w7liuWCnOYPxLXKUeYxPCP80btwzS1iSzyXq38qSq6FSQ5R6U+vsggZewpIH3cCn\n\tykQtRF2PNYrF84oSut4JoHzxPdXLsydabwk8f9WhUJYgYhl03buHQwLgIuQUebXQFydI2tazb\n\tajN61+OmRFQP0xUBj9dlO0ZUltaovg+MbBBv7w==","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"gcc-7 found an ancient bug in the loop driver, leading to a condition that\nis always false, meaning we ignore the contents of 'card->flags' here:\n\ndrivers/isdn/isdnloop/isdnloop.c:412:37: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-bool-context]\n\nThis changes the braces in the expression to ensure we actually\ncompare the flag bits, rather than comparing a constant. As Joe Perches\npointed out, an earlier patch of mine incorrectly assumed this was a\nfalse-positive warning.\n\nCc: Joe Perches \nLink: https://patchwork.kernel.org/patch/9840289/\nSigned-off-by: Arnd Bergmann \n---\n drivers/isdn/isdnloop/isdnloop.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/isdn/isdnloop/isdnloop.c b/drivers/isdn/isdnloop/isdnloop.c\nindex 6ffd13466b8c..e97232646ba1 100644\n--- a/drivers/isdn/isdnloop/isdnloop.c\n+++ b/drivers/isdn/isdnloop/isdnloop.c\n@@ -409,7 +409,7 @@ isdnloop_sendbuf(int channel, struct sk_buff *skb, isdnloop_card *card)\n \t\treturn -EINVAL;\n \t}\n \tif (len) {\n-\t\tif (!(card->flags & (channel) ? ISDNLOOP_FLAGS_B2ACTIVE : ISDNLOOP_FLAGS_B1ACTIVE))\n+\t\tif (!(card->flags & (channel ? ISDNLOOP_FLAGS_B2ACTIVE : ISDNLOOP_FLAGS_B1ACTIVE)))\n \t\t\treturn 0;\n \t\tif (card->sndcount[channel] > ISDNLOOP_MAX_SQUEUE)\n \t\t\treturn 0;\n","prefixes":[]}