{"id":810607,"url":"http://patchwork.ozlabs.org/api/patches/810607/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20170906133722.9AC8140240833@oldenburg.str.redhat.com/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170906133722.9AC8140240833@oldenburg.str.redhat.com>","list_archive_url":null,"date":"2017-09-06T13:37:22","name":"[COMMITTED] resolv: __resolv_conf_attach must not free passed conf object [BZ #22096]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"85c30241984dae365c84da615a605ce9c32ffc8a","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/?format=json","name":"Florian Weimer","email":"fweimer@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170906133722.9AC8140240833@oldenburg.str.redhat.com/mbox/","series":[{"id":1808,"url":"http://patchwork.ozlabs.org/api/series/1808/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=1808","date":"2017-09-06T13:37:22","name":"[COMMITTED] resolv: __resolv_conf_attach must not free passed conf object [BZ #22096]","version":1,"mbox":"http://patchwork.ozlabs.org/series/1808/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810607/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810607/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84253-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"iLoSe3mE\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnPlb4vSBz9sNV\n\tfor ;\n\tWed, 6 Sep 2017 23:37:31 +1000 (AEST)","(qmail 93366 invoked by alias); 6 Sep 2017 13:37:26 -0000","(qmail 93355 invoked by uid 89); 6 Sep 2017 13:37:25 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:to:subject:mime-version:content-type\n\t:content-transfer-encoding:message-id:from; q=dns; s=default; b=\n\tFNXcwcCHLFlietBkRZCMNCnOd1SMwZNg6MCUYIF5eIoGzdVe/r1jB0R0Q+AH2x2w\n\tiuGIAm5eNXimEjwNXZ5HLM+zS2td4PDkt+NblPc/9gfwa1PzH0XDMO97/elg/x3o\n\t1BFhX/82y1moOAGYvUc3V2DT2i/MZ7/LBd9+Mi0qGBE=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:to:subject:mime-version:content-type\n\t:content-transfer-encoding:message-id:from; s=default; bh=2dJAUd\n\tMPZrHx/WRtH8ge9GLA/PU=; b=iLoSe3mENErE761l6kiFXnDCjWCgav0rZuFJ6C\n\tAbHDROwNnQW9oLyKn4ds0d6mpJD0DptAfc7g8vlzkPGozsJKoD2RM23NTQ0XDi1u\n\tiZ8tEoHtVBh2p5DlCHCFjpsyQvpz0TnvGFu7RgDBn/ou0RnJTkU33rktMH9tFNTW\n\tdBoH0=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B3018883C6","Date":"Wed, 06 Sep 2017 15:37:22 +0200","To":"libc-alpha@sourceware.org","Subject":"[PATCH COMMITTED] resolv: __resolv_conf_attach must not free\n\tpassed conf object [BZ #22096]","User-Agent":"Heirloom mailx 12.5 7/5/10","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Message-Id":"<20170906133722.9AC8140240833@oldenburg.str.redhat.com>","From":"fweimer@redhat.com (Florian Weimer)"},"content":"2017-09-06 Florian Weimer \n\n\t[BZ #22096]\n\t* resolv/resolv_conf.c (__resolv_conf_attach): Do not free conf in\n\tcase of failure to obtain the global conf object.","diff":"diff --git a/resolv/resolv_conf.c b/resolv/resolv_conf.c\nindex f391d30c27..e0f296d02e 100644\n--- a/resolv/resolv_conf.c\n+++ b/resolv/resolv_conf.c\n@@ -600,10 +600,7 @@ __resolv_conf_attach (struct __res_state *resp, struct resolv_conf *conf)\n \n struct resolv_conf_global *global_copy = get_locked_global ();\n if (global_copy == NULL)\n- {\n- free (conf);\n- return false;\n- }\n+ return false;\n \n /* Try to find an unused index in the array. */\n size_t index;\n","prefixes":["COMMITTED"]}