{"id":810577,"url":"http://patchwork.ozlabs.org/api/patches/810577/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170906125904.2588620-1-arnd@arndb.de/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170906125904.2588620-1-arnd@arndb.de>","list_archive_url":null,"date":"2017-09-06T12:58:53","name":"ath10: mark PM functions as __maybe_unused","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":true,"hash":"efff29c545f978e25d7e5967b15a8ea9ce181312","submitter":{"id":30,"url":"http://patchwork.ozlabs.org/api/people/30/?format=json","name":"Arnd Bergmann","email":"arnd@arndb.de"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170906125904.2588620-1-arnd@arndb.de/mbox/","series":[{"id":1799,"url":"http://patchwork.ozlabs.org/api/series/1799/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=1799","date":"2017-09-06T12:58:53","name":"ath10: mark PM functions as __maybe_unused","version":1,"mbox":"http://patchwork.ozlabs.org/series/1799/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810577/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810577/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnNwb6SpKz9sBd\n\tfor ;\n\tWed, 6 Sep 2017 23:00:15 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932077AbdIFM7t (ORCPT );\n\tWed, 6 Sep 2017 08:59:49 -0400","from mout.kundenserver.de ([212.227.17.13]:61407 \"EHLO\n\tmout.kundenserver.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754481AbdIFM7o (ORCPT\n\t); Wed, 6 Sep 2017 08:59:44 -0400","from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de\n\t(mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id\n\t0MVLtW-1dyp4n2ZOo-00YmEV; Wed, 06 Sep 2017 14:59:07 +0200"],"From":"Arnd Bergmann ","To":"Kalle Valo ","Cc":"Arnd Bergmann , Colin Ian King ,\n\tBartosz Markowski ,\n\tGovind Singh ,\n\tRyan Hsu ,\n\tSrinivas Kandagatla ,\n\tRajkumar Manoharan ,\n\tAshok Raj Nagarajan ,\n\tBen Greear ,\n\tath10k@lists.infradead.org, linux-wireless@vger.kernel.org,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"[PATCH] ath10: mark PM functions as __maybe_unused","Date":"Wed, 6 Sep 2017 14:58:53 +0200","Message-Id":"<20170906125904.2588620-1-arnd@arndb.de>","X-Mailer":"git-send-email 2.9.0","X-Provags-ID":"V03:K0:lplKrPTQdrG1ngYdQ38fk5EyYiH6HJ3adabrs2BPwJE+chqVijm\n\tJ6yF7v0hF5jO6sCNbyV77+spU4hpF0JWLUUInjer9q9LRj76lZJbFJUXaVosAa6mDIjFved\n\tAwcVwzuU5/lR9PAGZTBaYcR9ZHiwLiUxSQ1oK6s6+JZMjwytfqxNVjrgYaCZT21dB5UHB35\n\tnWwmaFpu0HqzEot0ZKm8g==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:alKtr2AdNSA=:qvE8/+NnNZ1ZcZrynm0Z3Z\n\t0p09nFrJKxjaf/ylNeAThs3KwViy+PMTjhbqXn0T6661ws2KXt9qDixMU3vFbuEJSYgUXUBtM\n\t6RDMWcXSddrRRrZ6MXGj2rjrPnEKqOWdN6JpwErBCjstG+SzW5jGnyVcvt5Ba7wSP3mEUM3Se\n\thkJFS51fer0k+0Xg+7APn3CeRGnq5yuNJ5H/9h+jGKjLHGbMbkDOTg8HAxTwkFtvzzzOCpKDs\n\tdzGYmp6aNuzxvJ2MiUXrcykE0Jt1zgfZGbUW32+i30IohxAv4hmVUuTVTH+2vYDLjUF953UwO\n\tRChnUC6pksQ2E8wCeltNqhpnxuZmFaKVhw89p6o63Cn20iDSwFtNW06AbgEL7aFtQZnh3als0\n\tuM1JK0F3/bkiS9ScDSA7J1SOBL6zOydibHF7vT6pd4Rlb367YZy/yPYMZxY1cDOaDLxj0Zz9/\n\tZs7oSSLELLVU+b5H/E/LALapkg6H09IlA9dPhdPMTc1bW7NXvPncHyRPgXIf4Mj9cddbTKk4H\n\taYsiFiyQGIcpRJNlSWgRCGewuo4ZhxT8tx52k9/eX4Par7Ul01o6edid85Rkcht1ygP7As75Z\n\thHgtoZr2ltgNKjfW4mJy59eLchBpPEPRXgVjjPQZDatyR2L2Kz/JiLZ1YSfl9P8QfEj2ackaa\n\t268D9XJk5C/GfqoLXjylFTSFYoPhdZU2nbmawKUYMXCvZAJRTjoxIY3OdtpxkGgrnHvUKheIU\n\tWbywsBQjSa5K4nfS52C/WO9SB2WwjgVopL2oNw==","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"When CONFIG_PM_SLEEP is disabled, we get a compile-time\nwarning:\n\ndrivers/net/wireless/ath/ath10k/pci.c:3417:12: error: 'ath10k_pci_pm_resume' defined but not used [-Werror=unused-function]\n static int ath10k_pci_pm_resume(struct device *dev)\n ^~~~~~~~~~~~~~~~~~~~\ndrivers/net/wireless/ath/ath10k/pci.c:3401:12: error: 'ath10k_pci_pm_suspend' defined but not used [-Werror=unused-function]\n static int ath10k_pci_pm_suspend(struct device *dev)\n\nRather than fixing the #ifdef, this just marks both functions\nas __maybe_unused, which is a more robust way to do this.\n\nFixes: 32faa3f0ee50 (\"ath10k: add the PCI PM core suspend/resume ops\")\nSigned-off-by: Arnd Bergmann \n---\n drivers/net/wireless/ath/ath10k/pci.c | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c\nindex bc1633945a56..195dafb98131 100644\n--- a/drivers/net/wireless/ath/ath10k/pci.c\n+++ b/drivers/net/wireless/ath/ath10k/pci.c\n@@ -3396,9 +3396,7 @@ static void ath10k_pci_remove(struct pci_dev *pdev)\n \n MODULE_DEVICE_TABLE(pci, ath10k_pci_id_table);\n \n-#ifdef CONFIG_PM\n-\n-static int ath10k_pci_pm_suspend(struct device *dev)\n+static __maybe_unused int ath10k_pci_pm_suspend(struct device *dev)\n {\n \tstruct ath10k *ar = dev_get_drvdata(dev);\n \tint ret;\n@@ -3414,7 +3412,7 @@ static int ath10k_pci_pm_suspend(struct device *dev)\n \treturn ret;\n }\n \n-static int ath10k_pci_pm_resume(struct device *dev)\n+static __maybe_unused int ath10k_pci_pm_resume(struct device *dev)\n {\n \tstruct ath10k *ar = dev_get_drvdata(dev);\n \tint ret;\n@@ -3433,7 +3431,6 @@ static int ath10k_pci_pm_resume(struct device *dev)\n static SIMPLE_DEV_PM_OPS(ath10k_pci_pm_ops,\n \t\t\t ath10k_pci_pm_suspend,\n \t\t\t ath10k_pci_pm_resume);\n-#endif\n \n static struct pci_driver ath10k_pci_driver = {\n \t.name = \"ath10k_pci\",\n","prefixes":[]}