{"id":810561,"url":"http://patchwork.ozlabs.org/api/patches/810561/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20170906121647.GA59255@adacore.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170906121647.GA59255@adacore.com>","list_archive_url":null,"date":"2017-09-06T12:16:47","name":"[Ada] Reject invalid use of Global/Depends on object declaration","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f22d101992cd8530309e473045f48842f0a1da94","submitter":{"id":4418,"url":"http://patchwork.ozlabs.org/api/people/4418/?format=json","name":"Arnaud Charlet","email":"charlet@adacore.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20170906121647.GA59255@adacore.com/mbox/","series":[{"id":1785,"url":"http://patchwork.ozlabs.org/api/series/1785/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=1785","date":"2017-09-06T12:16:47","name":"[Ada] Reject invalid use of Global/Depends on object declaration","version":1,"mbox":"http://patchwork.ozlabs.org/series/1785/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810561/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810561/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461594-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"cj/6BrrD\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnMyg0jS3z9sBZ\n\tfor ;\n\tWed, 6 Sep 2017 22:16:58 +1000 (AEST)","(qmail 96679 invoked by alias); 6 Sep 2017 12:16:50 -0000","(qmail 96359 invoked by uid 89); 6 Sep 2017 12:16:50 -0000","from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tWed, 06 Sep 2017 12:16:48 +0000","from localhost (localhost.localdomain [127.0.0.1])\tby\n\tfiltered-rock.gnat.com (Postfix) with ESMTP id 8E19A5641C;\n\tWed, 6 Sep 2017 08:16:47 -0400 (EDT)","from rock.gnat.com ([127.0.0.1])\tby localhost (rock.gnat.com\n\t[127.0.0.1]) (amavisd-new, port 10024)\twith LMTP id\n\t7iRi3yh7ahFy; Wed, 6 Sep 2017 08:16:47 -0400 (EDT)","from tron.gnat.com (tron.gnat.com\n\t[IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294])\tby rock.gnat.com\n\t(Postfix) with ESMTP id 7B9495614C;\n\tWed, 6 Sep 2017 08:16:47 -0400 (EDT)","by tron.gnat.com (Postfix, from userid 4192)\tid 77C334AC;\n\tWed, 6 Sep 2017 08:16:47 -0400 (EDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:mime-version:content-type; q=dns;\n\ts=default; b=AQwaDliAuZFsWtgRbMokh1uiFVZbTSFGZdDHv16co9P1yc0uyk\n\tKSyTv4uSIneeThmBBlv78spleRrVDlROWtCsFGPH/KlmNXi7F22Oh4nYT7F9Ut8z\n\tch1M49EoGhuHbD7FTRnsoB/j1qzrj6iwuIVPm8HubcIzOOYAZY1WDXeZ4=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:mime-version:content-type; s=\n\tdefault; bh=2lB/f7HMMdBuf9BlJsnLaVgjaGY=; b=cj/6BrrDS8p6owBQui85\n\tW4ypnnah/vRfmW6awCB8biY3ca1eOqGXkgZmvnusPFzhtulEQiT9ZHh6++m1TMsA\n\tjsO2XgvOFKLffZED1LiFWN6fX16JFr0QDpeX68570LP8//JRqhJExm1jeBF7WQ34\n\tboKVi11dD6NTZK9oxC9CN+Y=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:929,\n\treinforce","X-HELO":"rock.gnat.com","Date":"Wed, 6 Sep 2017 08:16:47 -0400","From":"Arnaud Charlet ","To":"gcc-patches@gcc.gnu.org","Cc":"Yannick Moy ","Subject":"[Ada] Reject invalid use of Global/Depends on object declaration","Message-ID":"<20170906121647.GA59255@adacore.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"VS++wcV0S1rZb1Fb\"","Content-Disposition":"inline","User-Agent":"Mutt/1.5.23 (2014-03-12)"},"content":"GNAT failed to issue an error on a Global/Depends aspect put on an object\ndeclaration, which is only allowed for a task object. Instead it crashed.\nNow fixed.\n\nTested on x86_64-pc-linux-gnu, committed on trunk\n\n2017-09-06 Yannick Moy \n\n\t* sem_prag.adb (Analyze_Depends_Global): Reinforce test on object\n\tdeclarations to only consider valid uses of Global/Depends those on\n\tsingle concurrent objects.","diff":"Index: sem_prag.adb\n===================================================================\n--- sem_prag.adb\t(revision 251778)\n+++ sem_prag.adb\t(working copy)\n@@ -4080,7 +4080,10 @@\n \n -- Object declaration of a single concurrent type\n \n- elsif Nkind (Subp_Decl) = N_Object_Declaration then\n+ elsif Nkind (Subp_Decl) = N_Object_Declaration\n+ and then Is_Single_Concurrent_Object\n+ (Unique_Defining_Entity (Subp_Decl))\n+ then\n null;\n \n -- Single task type\n","prefixes":["Ada"]}