{"id":810559,"url":"http://patchwork.ozlabs.org/api/patches/810559/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/AM2PR07MB1042D848A7965231EA9EB2878A970@AM2PR07MB1042.eurprd07.prod.outlook.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-06T12:12:06","name":"[ovs-dev] netdev-dpdk: reset packet_type for reused dp_packets","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"cc196182c550b1aed26cb66e5d17c2dfc9fcb073","submitter":{"id":67904,"url":"http://patchwork.ozlabs.org/api/people/67904/?format=json","name":"Zoltan Balogh","email":"zoltan.balogh@ericsson.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/AM2PR07MB1042D848A7965231EA9EB2878A970@AM2PR07MB1042.eurprd07.prod.outlook.com/mbox/","series":[{"id":1783,"url":"http://patchwork.ozlabs.org/api/series/1783/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=1783","date":"2017-09-06T12:12:06","name":"[ovs-dev] netdev-dpdk: reset packet_type for reused dp_packets","version":1,"mbox":"http://patchwork.ozlabs.org/series/1783/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810559/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810559/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ericsson.onmicrosoft.com\n\theader.i=@ericsson.onmicrosoft.com header.b=\"C6+0oJ3r\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=zoltan.balogh@ericsson.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnMsD3DWPz9sBZ\n\tfor ;\n\tWed, 6 Sep 2017 22:12:16 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 34F65BCA;\n\tWed, 6 Sep 2017 12:12:13 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 0B2F6BAE\n\tfor ; Wed, 6 Sep 2017 12:12:12 +0000 (UTC)","from sesbmg23.ericsson.net (sesbmg23.ericsson.net [193.180.251.37])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id B16BA8A\n\tfor ; Wed, 6 Sep 2017 12:12:10 +0000 (UTC)","from ESESSHC002.ericsson.se (Unknown_Domain [153.88.183.24])\n\tby sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id\n\tB2.16.21299.816EFA95; Wed, 6 Sep 2017 14:12:08 +0200 (CEST)","from EUR03-DB5-obe.outbound.protection.outlook.com (153.88.183.145)\n\tby oa.msg.ericsson.com (153.88.183.24) with Microsoft SMTP Server\n\t(TLS) id 14.3.352.0; Wed, 6 Sep 2017 14:12:08 +0200","from AM2PR07MB1042.eurprd07.prod.outlook.com (10.162.37.27) by\n\tAM2PR07MB0563.eurprd07.prod.outlook.com (10.160.32.21) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.35.3; Wed, 6 Sep 2017 12:12:06 +0000","from AM2PR07MB1042.eurprd07.prod.outlook.com\n\t([fe80::7e:2b4e:3774:4ef3]) by\n\tAM2PR07MB1042.eurprd07.prod.outlook.com\n\t([fe80::7e:2b4e:3774:4ef3%13]) with mapi id 15.20.0035.010;\n\tWed, 6 Sep 2017 12:12:06 +0000"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-AuditID":"c1b4fb25-967ff70000005333-51-59afe618c405","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ericsson.onmicrosoft.com; s=selector1-ericsson-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=dk8pgi5OlKp1KPOllkAEBJfTRPy/3fyqY7kUtEyZr4s=;\n\tb=C6+0oJ3rYFev40pTy2GYbYzf1djpjHjLuhPsjfyhiP6kQVwUGIbVj/Ky38sSZkaN/3ucfV1HRcGDbXlpCyjsotPsysmiLYhPZcfD67QlDpbNZlEhYjeUKxJIruND5N6glwzm6gLAbCjrIl/l6egzj09eHptwI0nJaWeg0GDnbEQ=","From":"=?iso-8859-1?q?Zolt=E1n_Balogh?= ","To":"\"'dev@openvswitch.org'\" ","Thread-Topic":"[PATCH] netdev-dpdk: reset packet_type for reused dp_packets","Thread-Index":"AdMnCD3cQyrtf468Qh6oge0Asz5RMw==","Date":"Wed, 6 Sep 2017 12:12:06 +0000","Message-ID":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ericsson.onmicrosoft.com\n\theader.i=@ericsson.onmicrosoft.com header.b=\"C6+0oJ3r\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=zoltan.balogh@ericsson.com; "],"x-originating-ip":"[91.82.100.59]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; AM2PR07MB0563;\n\t6:FZFvlS3vp+UITV+mAkx+rGX6I4prxrZiMx1RVwzkRvPUhMxEjIZBVZRsEn9p7VpoFdkJBdMJ4skiNO+afexNlcgk3t4sl5LsJKHertJAG23T1dC+ifrb+Ou4N0pv4Yiimj8ZpypcHhOtZBn2+7a5eXmkk5QNsIZPQ/t4TskyOS+55sk+Lii1niasKBOHb0gziBJq4nbcaBxWuagUe4YgNVvhuPi0TPG9mwGflA+Uk3RLXPxXZ2WE+Qi6mAwEf9HFcSurJ8GWnssDlFKu+fzRU71BkPIpgGARrAedGo66XM0fVZkKT3GxbIVeC4J687mPFtgb9dElSSDREzYgD89EiQ==;\n\t5:q1a2QTvk1G5gPXV84DQiw+cBAe+FRqVw79Ydz5OYDlxbjCEHjViBXKAi3cAQff4iZIF2UUS1xUezDXqioa8/nRz2klHQLREFtrE+BQowWsAFm67ZmEINzwX4dXLGxlwdM3CjMIcKaLUIGKpPebS+RQ==;\n\t24:H4NJtTt5VJsTUDAFLgUU52QFdv30lbaAnEY5hW5UMa9cjABZ3ltNcpLriY2BttZDTnCvVS++HUwrgC2jeKS9C/9samTAdcD7QITSTl7s3H8=;\n\t7:IgbyC63sfRDUD8vRpu0uv8VgPZOYWDLlBCWsHHyRItfXtArpFDFk09OfzNKUliTgt1B+HlFkqQ9F8OYiy+6tPeOyE/UvOdproNyJSl61Cy7fvbFy4/mCEva81YUrr2R/TQqKEmQDJUrVYOghJXz+FtGz7EaJSLEvPJnSElHIjf+ikyfCQBaZ3kGbwYPeXHqyYDXBKBYwPeu9iEpLT2sTbCDNysCLUxDWudbXz/YGrig=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"dce23f64-7d53-4db0-028d-08d4f5207e10","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:AM2PR07MB0563; ","x-ms-traffictypediagnostic":"AM2PR07MB0563:","x-exchange-antispam-report-test":"UriScan:(37575265505322)(228905959029699);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:AM2PR07MB0563; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:AM2PR07MB0563; ","x-forefront-prvs":"0422860ED4","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(189002)(199003)(102836003)(189998001)(5250100002)(575784001)(33656002)(68736007)(74316002)(55016002)(99286003)(105586002)(3846002)(106356001)(9686003)(6916009)(6436002)(305945005)(6116002)(86362001)(6506006)(53936002)(97736004)(478600001)(66066001)(14454004)(5660300001)(2906002)(3660700001)(2900100001)(7736002)(81156014)(3280700002)(54356999)(110136004)(8936002)(81166006)(7696004)(101416001)(8676002)(50986999)(25786009)(491001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR07MB0563;\n\tH:AM2PR07MB1042.eurprd07.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: ericsson.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-MS-Exchange-CrossTenant-originalarrivaltime":"06 Sep 2017 12:12:06.8038\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"92e84ceb-fbfd-47ab-be52-080c6b87953f","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM2PR07MB0563","X-OriginatorOrg":"ericsson.com","X-Brightmail-Tracker":"H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsUyM2K7hK7Es/WRBhvW2VgcPb2H2YHR49nN\n\t/4wBjFFcNimpOZllqUX6dglcGfvnXWQsmCZWcWr6dOYGxnahLkZODgkBE4nbfzaxdDFycQgJ\n\tHGGUuNWzlwnCOc4oseN3H5jDItDLLPF0TwsjRGYSk8TWRyeYIZx7jBI3lvUzgQxjE3CWuL77\n\tJRuILSJgKHFp0klWEFtYwFXi7a3LUHEviRPTD7NC2HoSq/49AbNZBFQk2tsOsYDYvAIxEq03\n\tJjGC2IwCYhLfT60Bm88sIC5x68l8JojDBSSW7DnPDGGLSrx8/I8Voj5WYnprNxtEXEFi04L3\n\t7BC2rMSl+d1gH0gItLFL3Ni+FKpIT2LrxLeMELavxIZfS5ghih4xSfT//wiV0JI4fHsGK4Tt\n\tLTG1by5UPFvi1L4mNoiG06wSt6Z0Q62Tkfjw+AlUooFV4u3fu2AJIYFUieVrWxkh4SIlcfdK\n\tJ+MERq1ZSN6DsPUkbkydwgZha0ssW/iaeRY4aAQlTs58wrKAkWUVo2hxanFSbrqRsV5qUWZy\n\tcXF+nl5easkmRmCqOLjlt+oOxstvHA8xCnAwKvHwitxZHynEmlhWXJl7iFGCg1lJhFfuLlCI\n\tNyWxsiq1KD++qDQntfgQozQHi5I4r+O+CxFCAumJJanZqakFqUUwWSYOTqkGxrblrJKSKytW\n\t/tk7c1KvdFPy9WlTb8wVaZh00fnVqZXNL3U5mJRPVF9aOKfXa8GP577q+08ybMwojN0WU928\n\tfqf9ReHFcgauPrryi9dXvAyKyrKq/L2Y9ZFcUOgD5zypm4XTWx5V6LApW6cyeF679GJmWY74\n\tHZ1NAZMyD885aPtJ23TFv8kv2JRYijMSDbWYi4oTAbEWDZgRAwAA","X-Spam-Status":"No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_MED autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH] netdev-dpdk: reset packet_type for reused\n\tdp_packets","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"DPDK uses dp-packet pool for storing received packets. The pool is\nreused by rxq_recv funcions of the DPDK netdevs. The datapath is\ncapable to modify the packet_type property of packets. For instance\nwhen encapsulated L3 packets are received on a ptap gre port.\nIn this case the packet_type property of struct dp_packet can be\nmodified and later the same dp_packet with the modified packet_type\ncan be reused in the rxq_rec function, so it can contain corrupted\ndata.\n\nThe dp_packet_batch_init_cutlen() in the rxq_recv functions iterates\nover dp_packets and sets their cutlen. So I modified this function\nto set packet_type to Ethernet for the dp_packets as well. I also\nrenamed this function because of the added functionality.\n\nThe dp_packet_batch_init_cutlen() iterates over batch->count dp_packet.\nTherefore setting of batch->count = nb_rx needs to be done before the\nformer function is invoked. This is an additional fix.\n\nSigned-off-by: Zoltán Balogh \nSigned-off-by: László Sürü \nCo-authored-by: László Sürü \nCC: Jan Scheurich \nCC: Sugesh Chandran \nCC: Darrell Ball \n---\n lib/dp-packet.h | 4 +++-\n lib/netdev-dpdk.c | 5 +++--\n 2 files changed, 6 insertions(+), 3 deletions(-)","diff":"diff --git a/lib/dp-packet.h b/lib/dp-packet.h\nindex 046f3ab..0046d0a 100644\n--- a/lib/dp-packet.h\n+++ b/lib/dp-packet.h\n@@ -805,12 +805,14 @@ dp_packet_delete_batch(struct dp_packet_batch *batch, bool may_steal)\n }\n \n static inline void\n-dp_packet_batch_init_cutlen(struct dp_packet_batch *batch)\n+dp_packet_batch_init_transient_fields(struct dp_packet_batch *batch)\n {\n struct dp_packet *packet;\n \n DP_PACKET_BATCH_FOR_EACH (packet, batch) {\n dp_packet_reset_cutlen(packet);\n+ /* Set packet_type to Ethernet. */\n+ packet->packet_type = PACKET_TYPE_BE(OFPHTN_ONF, 0x0000);\n }\n }\n \ndiff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c\nindex f58e9be..2422741 100644\n--- a/lib/netdev-dpdk.c\n+++ b/lib/netdev-dpdk.c\n@@ -1644,8 +1644,9 @@ netdev_dpdk_vhost_rxq_recv(struct netdev_rxq *rxq,\n nb_rx, dropped);\n rte_spinlock_unlock(&dev->stats_lock);\n \n- dp_packet_batch_init_cutlen(batch);\n batch->count = (int) nb_rx;\n+ dp_packet_batch_init_transient_fields(batch);\n+\n return 0;\n }\n \n@@ -1684,8 +1685,8 @@ netdev_dpdk_rxq_recv(struct netdev_rxq *rxq, struct dp_packet_batch *batch)\n rte_spinlock_unlock(&dev->stats_lock);\n }\n \n- dp_packet_batch_init_cutlen(batch);\n batch->count = nb_rx;\n+ dp_packet_batch_init_transient_fields(batch);\n \n return 0;\n }\n","prefixes":["ovs-dev"]}