{"id":810538,"url":"http://patchwork.ozlabs.org/api/patches/810538/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906115143.27451-4-quintela@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170906115143.27451-4-quintela@redhat.com>","list_archive_url":null,"date":"2017-09-06T11:51:24","name":"[v7,03/22] migration: Teach it about G_SOURCE_REMOVE","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d9725ec39a89528832b1f11b8315f617d6d5c64f","submitter":{"id":2643,"url":"http://patchwork.ozlabs.org/api/people/2643/?format=json","name":"Juan Quintela","email":"quintela@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906115143.27451-4-quintela@redhat.com/mbox/","series":[{"id":1773,"url":"http://patchwork.ozlabs.org/api/series/1773/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1773","date":"2017-09-06T11:51:21","name":"Multifd","version":7,"mbox":"http://patchwork.ozlabs.org/series/1773/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810538/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810538/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=quintela@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnMXT4WKqz9s8J\n\tfor ;\n\tWed, 6 Sep 2017 21:57:45 +1000 (AEST)","from localhost ([::1]:35594 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpYxj-0003Jh-4d\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 07:57:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60149)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpYsB-0007F2-Iv\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 07:52:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpYsA-0007vV-Nz\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 07:51:59 -0400","from mx1.redhat.com ([209.132.183.28]:53310)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpYsA-0007vJ-HU\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 07:51:58 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8CF017E421\n\tfor ; Wed, 6 Sep 2017 11:51:57 +0000 (UTC)","from secure.mitica (ovpn-117-188.ams2.redhat.com [10.36.117.188])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7232619E35;\n\tWed, 6 Sep 2017 11:51:54 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8CF017E421","From":"Juan Quintela ","To":"qemu-devel@nongnu.org","Date":"Wed, 6 Sep 2017 13:51:24 +0200","Message-Id":"<20170906115143.27451-4-quintela@redhat.com>","In-Reply-To":"<20170906115143.27451-1-quintela@redhat.com>","References":"<20170906115143.27451-1-quintela@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 06 Sep 2017 11:51:57 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v7 03/22] migration: Teach it about\n\tG_SOURCE_REMOVE","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"As this is defined on glib 2.32, add compatibility macros for older glibs.\n\nSigned-off-by: Juan Quintela \nReviewed-by: Daniel P. Berrange \nReviewed-by: Peter Xu \n---\n include/glib-compat.h | 2 ++\n migration/exec.c | 2 +-\n migration/fd.c | 2 +-\n migration/socket.c | 2 +-\n 4 files changed, 5 insertions(+), 3 deletions(-)","diff":"diff --git a/include/glib-compat.h b/include/glib-compat.h\nindex fcffcd3f07..e15aca2d40 100644\n--- a/include/glib-compat.h\n+++ b/include/glib-compat.h\n@@ -223,6 +223,8 @@ static inline gboolean g_hash_table_contains(GHashTable *hash_table,\n {\n return g_hash_table_lookup_extended(hash_table, key, NULL, NULL);\n }\n+#define G_SOURCE_CONTINUE TRUE\n+#define G_SOURCE_REMOVE FALSE\n #endif\n \n #ifndef g_assert_true\ndiff --git a/migration/exec.c b/migration/exec.c\nindex 08b599e0e2..f3be1baf2e 100644\n--- a/migration/exec.c\n+++ b/migration/exec.c\n@@ -49,7 +49,7 @@ static gboolean exec_accept_incoming_migration(QIOChannel *ioc,\n {\n migration_channel_process_incoming(ioc);\n object_unref(OBJECT(ioc));\n- return FALSE; /* unregister */\n+ return G_SOURCE_REMOVE;\n }\n \n void exec_start_incoming_migration(const char *command, Error **errp)\ndiff --git a/migration/fd.c b/migration/fd.c\nindex 30f5258a6a..30de4b9847 100644\n--- a/migration/fd.c\n+++ b/migration/fd.c\n@@ -49,7 +49,7 @@ static gboolean fd_accept_incoming_migration(QIOChannel *ioc,\n {\n migration_channel_process_incoming(ioc);\n object_unref(OBJECT(ioc));\n- return FALSE; /* unregister */\n+ return G_SOURCE_REMOVE;\n }\n \n void fd_start_incoming_migration(const char *infd, Error **errp)\ndiff --git a/migration/socket.c b/migration/socket.c\nindex 757d3821a1..b02d37d7a3 100644\n--- a/migration/socket.c\n+++ b/migration/socket.c\n@@ -154,7 +154,7 @@ static gboolean socket_accept_incoming_migration(QIOChannel *ioc,\n out:\n /* Close listening socket as its no longer needed */\n qio_channel_close(ioc, NULL);\n- return FALSE; /* unregister */\n+ return G_SOURCE_REMOVE;\n }\n \n \n","prefixes":["v7","03/22"]}