{"id":810380,"url":"http://patchwork.ozlabs.org/api/patches/810380/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20170906042935.23586-2-aaron.ma@canonical.com/","project":{"id":15,"url":"http://patchwork.ozlabs.org/api/projects/15/?format=json","name":"Ubuntu Kernel","link_name":"ubuntu-kernel","list_id":"kernel-team.lists.ubuntu.com","list_email":"kernel-team@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170906042935.23586-2-aaron.ma@canonical.com>","list_archive_url":null,"date":"2017-09-06T04:29:34","name":"[1/1,SRU,Artful] Input: trackpoint - assume 3 buttons when buttons detection fails","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0b4af249dca853cc6b88d3bb1e24b7ed2e6175cd","submitter":{"id":72035,"url":"http://patchwork.ozlabs.org/api/people/72035/?format=json","name":"Aaron Ma","email":"aaron.ma@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20170906042935.23586-2-aaron.ma@canonical.com/mbox/","series":[{"id":1687,"url":"http://patchwork.ozlabs.org/api/series/1687/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=1687","date":"2017-09-06T04:29:33","name":"Fix middle button issue of trackpoint","version":1,"mbox":"http://patchwork.ozlabs.org/series/1687/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810380/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810380/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xn9bd2bQsz9t3Z;\n\tWed, 6 Sep 2017 14:29:49 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpRyC-00085F-PX; Wed, 06 Sep 2017 04:29:44 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpRyA-00084o-LL\n\tfor kernel-team@lists.ubuntu.com; Wed, 06 Sep 2017 04:29:42 +0000","from [222.129.53.12] (helo=localhost.localdomain)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpRy9-0000hd-KC; Wed, 06 Sep 2017 04:29:42 +0000"],"From":"Aaron Ma ","To":"aaron.ma@canonical.com,\n\tkernel-team@lists.ubuntu.com","Subject":"[PATCH 1/1] [SRU Artful] Input: trackpoint - assume 3 buttons when\n\tbuttons detection fails","Date":"Wed, 6 Sep 2017 12:29:34 +0800","Message-Id":"<20170906042935.23586-2-aaron.ma@canonical.com>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170906042935.23586-1-aaron.ma@canonical.com>","References":"<20170906042935.23586-1-aaron.ma@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "},"content":"From: Oscar Campos \n\nBugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1715271\n\nTrackpoint buttons detection fails on ThinkPad 570 and 470 series,\nthis makes the middle button of the trackpoint to not being recogized.\nAs I don't believe there is any trackpoint with less than 3 buttons this\npatch just assumes three buttons when the extended button information\nread fails.\n\nSigned-off-by: Oscar Campos \nAcked-by: Peter Hutterer \nSigned-off-by: Dmitry Torokhov \n(cherry-picked from commit 293b915fd9bebf33cdc906516fb28d54649a25ac)\nSigned-off-by: Aaron Ma \n---\n drivers/input/mouse/trackpoint.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c\nindex 922ea02edcc3..20b5b21c1bba 100644\n--- a/drivers/input/mouse/trackpoint.c\n+++ b/drivers/input/mouse/trackpoint.c\n@@ -380,8 +380,8 @@ int trackpoint_detect(struct psmouse *psmouse, bool set_properties)\n \t\treturn 0;\n \n \tif (trackpoint_read(ps2dev, TP_EXT_BTN, &button_info)) {\n-\t\tpsmouse_warn(psmouse, \"failed to get extended button data\\n\");\n-\t\tbutton_info = 0;\n+\t\tpsmouse_warn(psmouse, \"failed to get extended button data, assuming 3 buttons\\n\");\n+\t\tbutton_info = 0x33;\n \t}\n \n \tpsmouse->private = kzalloc(sizeof(struct trackpoint_data), GFP_KERNEL);\n","prefixes":["1/1","SRU","Artful"]}