{"id":810354,"url":"http://patchwork.ozlabs.org/api/patches/810354/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906012715.31761-4-famz@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170906012715.31761-4-famz@redhat.com>","list_archive_url":null,"date":"2017-09-06T01:27:15","name":"[v2,3/3] buildsys: Move gcrypt cflags/libs to per object","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f3a1b896828504877d9b4597fc00279eef3d7d37","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/?format=json","name":"Fam Zheng","email":"famz@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906012715.31761-4-famz@redhat.com/mbox/","series":[{"id":1678,"url":"http://patchwork.ozlabs.org/api/series/1678/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1678","date":"2017-09-06T01:27:12","name":"buildsys: Move crypto libraries to per object variables","version":2,"mbox":"http://patchwork.ozlabs.org/series/1678/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810354/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810354/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xn5cH74tTz9s2G\n\tfor ;\n\tWed, 6 Sep 2017 11:30:07 +1000 (AEST)","from localhost ([::1]:33739 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpPAK-0005S5-Qn\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 21:30:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36246)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpP7m-0003li-Ck\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 21:27:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpP7l-00088c-Gp\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 21:27:26 -0400","from mx1.redhat.com ([209.132.183.28]:42120)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpP7l-00087E-Ai\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 21:27:25 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 57A81859F7\n\tfor ; Wed, 6 Sep 2017 01:27:24 +0000 (UTC)","from lemon.redhat.com (ovpn-12-90.pek2.redhat.com [10.72.12.90])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 181A361345;\n\tWed, 6 Sep 2017 01:27:22 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 57A81859F7","From":"Fam Zheng ","To":"qemu-devel@nongnu.org","Date":"Wed, 6 Sep 2017 09:27:15 +0800","Message-Id":"<20170906012715.31761-4-famz@redhat.com>","In-Reply-To":"<20170906012715.31761-1-famz@redhat.com>","References":"<20170906012715.31761-1-famz@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 06 Sep 2017 01:27:24 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v2 3/3] buildsys: Move gcrypt cflags/libs to\n\tper object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Signed-off-by: Fam Zheng \n---\n configure | 5 ++---\n crypto/Makefile.objs | 7 +++++++\n 2 files changed, 9 insertions(+), 3 deletions(-)","diff":"diff --git a/configure b/configure\nindex d24a7eab37..42622b98be 100755\n--- a/configure\n+++ b/configure\n@@ -2566,9 +2566,6 @@ if test \"$gcrypt\" != \"no\"; then\n then\n gcrypt_libs=\"$gcrypt_libs -lgpg-error\"\n fi\n- libs_softmmu=\"$gcrypt_libs $libs_softmmu\"\n- libs_tools=\"$gcrypt_libs $libs_tools\"\n- QEMU_CFLAGS=\"$QEMU_CFLAGS $gcrypt_cflags\"\n gcrypt=\"yes\"\n if test -z \"$nettle\"; then\n nettle=\"no\"\n@@ -5716,6 +5713,8 @@ if test \"$gnutls_rnd\" = \"yes\" ; then\n fi\n if test \"$gcrypt\" = \"yes\" ; then\n echo \"CONFIG_GCRYPT=y\" >> $config_host_mak\n+ echo \"GCRYPT_CFLAGS=$gcrypt_cflags\" >> $config_host_mak\n+ echo \"GCRYPT_LIBS=$gcrypt_libs\" >> $config_host_mak\n if test \"$gcrypt_hmac\" = \"yes\" ; then\n echo \"CONFIG_GCRYPT_HMAC=y\" >> $config_host_mak\n fi\ndiff --git a/crypto/Makefile.objs b/crypto/Makefile.objs\nindex 0cb5fa24b6..45f7c0c80d 100644\n--- a/crypto/Makefile.objs\n+++ b/crypto/Makefile.objs\n@@ -34,6 +34,13 @@ crypto-obj-y += block.o\n crypto-obj-y += block-qcow.o\n crypto-obj-y += block-luks.o\n \n+$(if $(CONFIG_GCRYPT), \\\n+\t$(foreach x, init cipher hash-gcrypt hmac-gcrypt random-gcrypt \\\n+\t\t\tpbkdf-gcrypt, \\\n+\t\t$(eval $x.o-cflags := $(NETTLE_CFLAGS)) \\\n+\t\t$(eval $x.o-libs := $(NETTLE_LIBS))) \\\n+)\n+\n $(if $(CONFIG_NETTLE), \\\n \t$(foreach x, cipher hash-nettle hmac-nettle pbkdf-nettle, \\\n \t\t$(eval $x.o-cflags := $(NETTLE_CFLAGS)) \\\n","prefixes":["v2","3/3"]}