{"id":810305,"url":"http://patchwork.ozlabs.org/api/patches/810305/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20170905223541.20594-4-ross.zwisler@linux.intel.com/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170905223541.20594-4-ross.zwisler@linux.intel.com>","list_archive_url":null,"date":"2017-09-05T22:35:35","name":"[3/9] xfs: validate bdev support for DAX inode flag","commit_ref":null,"pull_url":null,"state":"new","archived":true,"hash":"4c137f4d772743bd14f0baa85df059b1b87d6f02","submitter":{"id":46514,"url":"http://patchwork.ozlabs.org/api/people/46514/?format=json","name":"Ross Zwisler","email":"ross.zwisler@linux.intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20170905223541.20594-4-ross.zwisler@linux.intel.com/mbox/","series":[{"id":1660,"url":"http://patchwork.ozlabs.org/api/series/1660/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=1660","date":"2017-09-05T22:35:36","name":"add ext4 per-inode DAX flag","version":1,"mbox":"http://patchwork.ozlabs.org/series/1660/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810305/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810305/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xn1mz5Jfgz9sP3\n\tfor ;\n\tWed, 6 Sep 2017 08:37:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754122AbdIEWgY (ORCPT );\n\tTue, 5 Sep 2017 18:36:24 -0400","from mga01.intel.com ([192.55.52.88]:4505 \"EHLO mga01.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1753341AbdIEWgR (ORCPT );\n\tTue, 5 Sep 2017 18:36:17 -0400","from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Sep 2017 15:36:16 -0700","from theros.lm.intel.com ([10.232.112.77])\n\tby fmsmga004.fm.intel.com with ESMTP; 05 Sep 2017 15:36:15 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,481,1498546800\"; d=\"scan'208\";a=\"308314871\"","From":"Ross Zwisler ","To":"Andrew Morton , linux-kernel@vger.kernel.org","Cc":"Ross Zwisler ,\n\t\"Darrick J. Wong\" ,\n\t\"Theodore Ts'o\" ,\n\tAndreas Dilger ,\n\tChristoph Hellwig , Dan Williams ,\n\tDave Chinner , Jan Kara ,\n\tlinux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org,\n\tlinux-xfs@vger.kernel.org, stable@vger.kernel.org","Subject":"[PATCH 3/9] xfs: validate bdev support for DAX inode flag","Date":"Tue, 5 Sep 2017 16:35:35 -0600","Message-Id":"<20170905223541.20594-4-ross.zwisler@linux.intel.com>","X-Mailer":"git-send-email 2.9.5","In-Reply-To":"<20170905223541.20594-1-ross.zwisler@linux.intel.com>","References":"<20170905223541.20594-1-ross.zwisler@linux.intel.com>","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"},"content":"Currently only the blocksize is checked, but we should really be calling\nbdev_dax_supported() which also tests to make sure we can get a\nstruct dax_device and that the dax_direct_access() path is working.\n\nThis is the same check that we do for the \"-o dax\" mount option in\nxfs_fs_fill_super().\n\nSigned-off-by: Ross Zwisler \nCC: stable@vger.kernel.org\n---\n fs/xfs/xfs_ioctl.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c\nindex 8155ddc..dac195d 100644\n--- a/fs/xfs/xfs_ioctl.c\n+++ b/fs/xfs/xfs_ioctl.c\n@@ -1075,6 +1075,7 @@ xfs_ioctl_setattr_dax_invalidate(\n \tint\t\t\t*join_flags)\n {\n \tstruct inode\t\t*inode = VFS_I(ip);\n+\tstruct super_block\t*sb = inode->i_sb;\n \tint\t\t\terror;\n \n \t*join_flags = 0;\n@@ -1087,7 +1088,7 @@ xfs_ioctl_setattr_dax_invalidate(\n \tif (fa->fsx_xflags & FS_XFLAG_DAX) {\n \t\tif (!(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode)))\n \t\t\treturn -EINVAL;\n-\t\tif (ip->i_mount->m_sb.sb_blocksize != PAGE_SIZE)\n+\t\tif (bdev_dax_supported(sb, sb->s_blocksize) < 0)\n \t\t\treturn -EINVAL;\n \t}\n \n","prefixes":["3/9"]}