{"id":810224,"url":"http://patchwork.ozlabs.org/api/patches/810224/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ide/patch/20170905164647.24101-1-hch@lst.de/","project":{"id":13,"url":"http://patchwork.ozlabs.org/api/projects/13/?format=json","name":"Linux IDE development","link_name":"linux-ide","list_id":"linux-ide.vger.kernel.org","list_email":"linux-ide@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170905164647.24101-1-hch@lst.de>","list_archive_url":null,"date":"2017-09-05T16:46:47","name":"ahci: don't use MSI for devices with the braindead Intel NVMe remapping scheme","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"00b4959b6c6799f0cda61efcf190ec2a294ed767","submitter":{"id":82,"url":"http://patchwork.ozlabs.org/api/people/82/?format=json","name":"Christoph Hellwig","email":"hch@lst.de"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/linux-ide/patch/20170905164647.24101-1-hch@lst.de/mbox/","series":[{"id":1610,"url":"http://patchwork.ozlabs.org/api/series/1610/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ide/list/?series=1610","date":"2017-09-05T16:46:47","name":"ahci: don't use MSI for devices with the braindead Intel NVMe remapping scheme","version":1,"mbox":"http://patchwork.ozlabs.org/series/1610/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810224/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810224/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ide-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"LlxBpSeW\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmt0h4Znpz9sNr\n\tfor ;\n\tWed, 6 Sep 2017 02:47:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752087AbdIEQq5 (ORCPT );\n\tTue, 5 Sep 2017 12:46:57 -0400","from bombadil.infradead.org ([65.50.211.133]:59300 \"EHLO\n\tbombadil.infradead.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752285AbdIEQqz (ORCPT\n\t); Tue, 5 Sep 2017 12:46:55 -0400","from 80-109-164-210.cable.dynamic.surfer.at ([80.109.164.210]\n\thelo=localhost)\n\tby bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpGzz-0002Li-RI; Tue, 05 Sep 2017 16:46:52 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=bombadil.20170209;\n\th=Message-Id:Date:Subject:Cc:To:From:\n\tSender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:\n\tContent-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:\n\tResent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=XYqSRoNsQplznU1bPk+FP/BcwqD1vIhTQPUQFrRBYp4=;\n\tb=LlxBpSeWd2Gs1ZHwF+9r59+V/\n\tOZak872qaTR4JYE5oIzhMyGWoi+tsPLe0x1atypj8RaT2lCDbD/c+8mzrbL+rrErvuq/x1s9D7pjr\n\tigUbo39b60JahIdeCX94E3ZJiUt5qtZ6i58Xj5lWSDm0xUUHOSmqWRc1Ivgzy68Y1ZlQjxlm80+Wa\n\tm7x454edSqe1xlkj5tXCn1qh2yvaJzatuhhpjGtBhDsH/UpZzYE5Rywn5DVfCMPlnay44LNU7Qgkz\n\tVyhs1rlyEVLgiaFexTmqpUhfvy9onjfxsoxn9jcXl4eqRNY7eKcp+YcG7b7ZSlL1tlBTBerKL3jMq\n\tijGh8ZtRQ==;","From":"Christoph Hellwig ","To":"tj@kernel.org","Cc":"dan.j.williams@intel.com, john.robert.loy@gmail.com,\n\tlinux-ide@vger.kernel.org, stable@vger.kernel.org","Subject":"[PATCH] ahci: don't use MSI for devices with the braindead Intel\n\tNVMe remapping scheme","Date":"Tue, 5 Sep 2017 18:46:47 +0200","Message-Id":"<20170905164647.24101-1-hch@lst.de>","X-Mailer":"git-send-email 2.11.0","X-SRS-Rewrite":"SMTP reverse-path rewritten from by\n\tbombadil.infradead.org. See http://www.infradead.org/rpr.html","Sender":"linux-ide-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ide@vger.kernel.org"},"content":"Intel AHCI controllers that also hide NVMe devices in their bar\ncan't use MSI interrupts, so disable them.\n\nReported-by: John Loy \nTestd-by: John Loy \nSigned-off-by: Christoph Hellwig \nCc: stable@vger.kernel.org\n---\n drivers/ata/ahci.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c\nindex 5a5fd0b404eb..cb9b0e9090e3 100644\n--- a/drivers/ata/ahci.c\n+++ b/drivers/ata/ahci.c\n@@ -1469,7 +1469,14 @@ static void ahci_remap_check(struct pci_dev *pdev, int bar,\n \t\treturn;\n \n \tdev_warn(&pdev->dev, \"Found %d remapped NVMe devices.\\n\", count);\n-\tdev_warn(&pdev->dev, \"Switch your BIOS from RAID to AHCI mode to use them.\\n\");\n+\tdev_warn(&pdev->dev,\n+\t\t \"Switch your BIOS from RAID to AHCI mode to use them.\\n\");\n+\n+\t/*\n+\t * Don't rely on the msi-x capability in the remap case,\n+\t * share the legacy interrupt across ahci and remapped devices.\n+\t */\n+\thpriv->flags |= AHCI_HFLAG_NO_MSI;\n }\n \n static int ahci_get_irq_vector(struct ata_host *host, int port)\n","prefixes":[]}