{"id":810119,"url":"http://patchwork.ozlabs.org/api/patches/810119/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1504615144-29770-9-git-send-email-gilad@benyossef.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504615144-29770-9-git-send-email-gilad@benyossef.com>","list_archive_url":null,"date":"2017-09-05T12:38:47","name":"[v8,08/20] crypto: move pub key to generic async completion","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"a3f7039f32f81af8761f96549dd70f4f19b57ef7","submitter":{"id":11198,"url":"http://patchwork.ozlabs.org/api/people/11198/?format=json","name":"Gilad Ben-Yossef","email":"gilad@benyossef.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1504615144-29770-9-git-send-email-gilad@benyossef.com/mbox/","series":[{"id":1573,"url":"http://patchwork.ozlabs.org/api/series/1573/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=1573","date":"2017-09-05T12:38:39","name":"simplify crypto wait for async op","version":8,"mbox":"http://patchwork.ozlabs.org/series/1573/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810119/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810119/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmmYW28x1z9sRm\n\tfor ;\n\tTue, 5 Sep 2017 22:41:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751975AbdIEMlX (ORCPT );\n\tTue, 5 Sep 2017 08:41:23 -0400","from foss.arm.com ([217.140.101.70]:39330 \"EHLO foss.arm.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751386AbdIEMlQ (ORCPT );\n\tTue, 5 Sep 2017 08:41:16 -0400","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C9BDA165C;\n\tTue, 5 Sep 2017 05:41:15 -0700 (PDT)","from gby.kfn.arm.com (unknown [10.45.48.140])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t64AED3F3E1; Tue, 5 Sep 2017 05:41:06 -0700 (PDT)"],"From":"Gilad Ben-Yossef ","To":"Herbert Xu ,\n\t\"David S. Miller\" ,\n\tJonathan Corbet , David Howells ,\n\tTom Lendacky , Gary Hook ,\n\tBoris Brezillon ,\n\tArnaud Ebalard ,\n\tMatthias Brugger ,\n\tAlasdair Kergon ,\n\tMike Snitzer , dm-devel@redhat.com,\n\tShaohua Li , Steve French ,\n\t\"Theodore Y. Ts'o\" , Jaegeuk Kim ,\n\tSteffen Klassert ,\n\tAlexey Kuznetsov ,\n\tHideaki YOSHIFUJI ,\n\tMimi Zohar ,\n\tDmitry Kasatkin ,\n\tJames Morris ,\n\t\"Serge E. Hallyn\" , linux-crypto@vger.kernel.org,\n\tlinux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkeyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-mediatek@lists.infradead.org, linux-raid@vger.kernel.org,\n\tlinux-cifs@vger.kernel.org, samba-technical@lists.samba.org,\n\tlinux-fscrypt@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-ima-devel@lists.sourceforge.net,\n\tlinux-ima-user@lists.sourceforge.net,\n\tlinux-security-module@vger.kernel.org","Cc":"Ofir Drang ","Subject":"[PATCH v8 08/20] crypto: move pub key to generic async completion","Date":"Tue, 5 Sep 2017 15:38:47 +0300","Message-Id":"<1504615144-29770-9-git-send-email-gilad@benyossef.com>","X-Mailer":"git-send-email 2.1.4","In-Reply-To":"<1504615144-29770-1-git-send-email-gilad@benyossef.com>","References":"<1504615144-29770-1-git-send-email-gilad@benyossef.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"public_key_verify_signature() is starting an async crypto op and\nwaiting for it to complete. Move it over to generic code doing\nthe same.\n\nSigned-off-by: Gilad Ben-Yossef \n---\n crypto/asymmetric_keys/public_key.c | 28 ++++------------------------\n 1 file changed, 4 insertions(+), 24 deletions(-)","diff":"diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c\nindex 3cd6e12..d916235 100644\n--- a/crypto/asymmetric_keys/public_key.c\n+++ b/crypto/asymmetric_keys/public_key.c\n@@ -57,29 +57,13 @@ static void public_key_destroy(void *payload0, void *payload3)\n \tpublic_key_signature_free(payload3);\n }\n \n-struct public_key_completion {\n-\tstruct completion completion;\n-\tint err;\n-};\n-\n-static void public_key_verify_done(struct crypto_async_request *req, int err)\n-{\n-\tstruct public_key_completion *compl = req->data;\n-\n-\tif (err == -EINPROGRESS)\n-\t\treturn;\n-\n-\tcompl->err = err;\n-\tcomplete(&compl->completion);\n-}\n-\n /*\n * Verify a signature using a public key.\n */\n int public_key_verify_signature(const struct public_key *pkey,\n \t\t\t\tconst struct public_key_signature *sig)\n {\n-\tstruct public_key_completion compl;\n+\tstruct crypto_wait cwait;\n \tstruct crypto_akcipher *tfm;\n \tstruct akcipher_request *req;\n \tstruct scatterlist sig_sg, digest_sg;\n@@ -131,20 +115,16 @@ int public_key_verify_signature(const struct public_key *pkey,\n \tsg_init_one(&digest_sg, output, outlen);\n \takcipher_request_set_crypt(req, &sig_sg, &digest_sg, sig->s_size,\n \t\t\t\t outlen);\n-\tinit_completion(&compl.completion);\n+\tcrypto_init_wait(&cwait);\n \takcipher_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG |\n \t\t\t\t CRYPTO_TFM_REQ_MAY_SLEEP,\n-\t\t\t\t public_key_verify_done, &compl);\n+\t\t\t\t crypto_req_done, &cwait);\n \n \t/* Perform the verification calculation. This doesn't actually do the\n \t * verification, but rather calculates the hash expected by the\n \t * signature and returns that to us.\n \t */\n-\tret = crypto_akcipher_verify(req);\n-\tif ((ret == -EINPROGRESS) || (ret == -EBUSY)) {\n-\t\twait_for_completion(&compl.completion);\n-\t\tret = compl.err;\n-\t}\n+\tret = crypto_wait_req(crypto_akcipher_verify(req), &cwait);\n \tif (ret < 0)\n \t\tgoto out_free_output;\n \n","prefixes":["v8","08/20"]}