{"id":810113,"url":"http://patchwork.ozlabs.org/api/patches/810113/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1504615144-29770-6-git-send-email-gilad@benyossef.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504615144-29770-6-git-send-email-gilad@benyossef.com>","list_archive_url":null,"date":"2017-09-05T12:38:44","name":"[v8,05/20] crypto: marvell/cesa: remove redundant backlog checks on EBUSY","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"eb81501c7537e5dbcb8c2f9f8065bc6aa8d6d584","submitter":{"id":11198,"url":"http://patchwork.ozlabs.org/api/people/11198/?format=json","name":"Gilad Ben-Yossef","email":"gilad@benyossef.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1504615144-29770-6-git-send-email-gilad@benyossef.com/mbox/","series":[{"id":1573,"url":"http://patchwork.ozlabs.org/api/series/1573/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=1573","date":"2017-09-05T12:38:39","name":"simplify crypto wait for async op","version":8,"mbox":"http://patchwork.ozlabs.org/series/1573/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810113/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810113/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmmXX4CJ1z9sRV\n\tfor ;\n\tTue, 5 Sep 2017 22:40:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751875AbdIEMkm (ORCPT );\n\tTue, 5 Sep 2017 08:40:42 -0400","from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:39172 \"EHLO\n\tfoss.arm.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751678AbdIEMkd (ORCPT );\n\tTue, 5 Sep 2017 08:40:33 -0400","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F40C9165C;\n\tTue, 5 Sep 2017 05:40:32 -0700 (PDT)","from gby.kfn.arm.com (unknown [10.45.48.140])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\tF19823F3E1; Tue, 5 Sep 2017 05:40:23 -0700 (PDT)"],"From":"Gilad Ben-Yossef ","To":"Herbert Xu ,\n\t\"David S. Miller\" ,\n\tJonathan Corbet , David Howells ,\n\tTom Lendacky , Gary Hook ,\n\tBoris Brezillon ,\n\tArnaud Ebalard ,\n\tMatthias Brugger ,\n\tAlasdair Kergon ,\n\tMike Snitzer , dm-devel@redhat.com,\n\tShaohua Li , Steve French ,\n\t\"Theodore Y. Ts'o\" , Jaegeuk Kim ,\n\tSteffen Klassert ,\n\tAlexey Kuznetsov ,\n\tHideaki YOSHIFUJI ,\n\tMimi Zohar ,\n\tDmitry Kasatkin ,\n\tJames Morris ,\n\t\"Serge E. Hallyn\" , linux-crypto@vger.kernel.org,\n\tlinux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkeyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-mediatek@lists.infradead.org, linux-raid@vger.kernel.org,\n\tlinux-cifs@vger.kernel.org, samba-technical@lists.samba.org,\n\tlinux-fscrypt@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-ima-devel@lists.sourceforge.net,\n\tlinux-ima-user@lists.sourceforge.net,\n\tlinux-security-module@vger.kernel.org","Cc":"Ofir Drang ","Subject":"[PATCH v8 05/20] crypto: marvell/cesa: remove redundant backlog\n\tchecks on EBUSY","Date":"Tue, 5 Sep 2017 15:38:44 +0300","Message-Id":"<1504615144-29770-6-git-send-email-gilad@benyossef.com>","X-Mailer":"git-send-email 2.1.4","In-Reply-To":"<1504615144-29770-1-git-send-email-gilad@benyossef.com>","References":"<1504615144-29770-1-git-send-email-gilad@benyossef.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Now that -EBUSY return code only indicates backlog queueing\nwe can safely remove the now redundant check for the\nCRYPTO_TFM_REQ_MAY_BACKLOG flag when -EBUSY is returned.\n\nSigned-off-by: Gilad Ben-Yossef \nAcked-by: Boris Brezillon \n---\n drivers/crypto/marvell/cesa.c | 3 +--\n drivers/crypto/marvell/cesa.h | 2 +-\n 2 files changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/crypto/marvell/cesa.c b/drivers/crypto/marvell/cesa.c\nindex 6e7a5c7..0c3909d 100644\n--- a/drivers/crypto/marvell/cesa.c\n+++ b/drivers/crypto/marvell/cesa.c\n@@ -183,8 +183,7 @@ int mv_cesa_queue_req(struct crypto_async_request *req,\n \tspin_lock_bh(&engine->lock);\n \tret = crypto_enqueue_request(&engine->queue, req);\n \tif ((mv_cesa_req_get_type(creq) == CESA_DMA_REQ) &&\n-\t (ret == -EINPROGRESS ||\n-\t (ret == -EBUSY && req->flags & CRYPTO_TFM_REQ_MAY_BACKLOG)))\n+\t (ret == -EINPROGRESS || ret == -EBUSY))\n \t\tmv_cesa_tdma_chain(engine, creq);\n \tspin_unlock_bh(&engine->lock);\n \ndiff --git a/drivers/crypto/marvell/cesa.h b/drivers/crypto/marvell/cesa.h\nindex b7872f6..63c8457 100644\n--- a/drivers/crypto/marvell/cesa.h\n+++ b/drivers/crypto/marvell/cesa.h\n@@ -763,7 +763,7 @@ static inline int mv_cesa_req_needs_cleanup(struct crypto_async_request *req,\n \t * the backlog and will be processed later. There's no need to\n \t * clean it up.\n \t */\n-\tif (ret == -EBUSY && req->flags & CRYPTO_TFM_REQ_MAY_BACKLOG)\n+\tif (ret == -EBUSY)\n \t\treturn false;\n \n \t/* Request wasn't queued, we need to clean it up */\n","prefixes":["v8","05/20"]}