{"id":810109,"url":"http://patchwork.ozlabs.org/api/patches/810109/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1504615144-29770-3-git-send-email-gilad@benyossef.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504615144-29770-3-git-send-email-gilad@benyossef.com>","list_archive_url":null,"date":"2017-09-05T12:38:41","name":"[v8,02/20] crypto: ccp: use -EAGAIN for transient busy indication","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"d5215b03a80d7d653dfa094a76185c9933b21812","submitter":{"id":11198,"url":"http://patchwork.ozlabs.org/api/people/11198/?format=json","name":"Gilad Ben-Yossef","email":"gilad@benyossef.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1504615144-29770-3-git-send-email-gilad@benyossef.com/mbox/","series":[{"id":1573,"url":"http://patchwork.ozlabs.org/api/series/1573/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=1573","date":"2017-09-05T12:38:39","name":"simplify crypto wait for async op","version":8,"mbox":"http://patchwork.ozlabs.org/series/1573/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810109/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810109/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmmWk1gkXz9sRV\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue,  5 Sep 2017 22:40:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751647AbdIEMj6 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 5 Sep 2017 08:39:58 -0400","from foss.arm.com ([217.140.101.70]:38974 \"EHLO foss.arm.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751538AbdIEMju (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 5 Sep 2017 08:39:50 -0400","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 910141650;\n\tTue,  5 Sep 2017 05:39:49 -0700 (PDT)","from gby.kfn.arm.com (unknown [10.45.48.140])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t1853D3F3E1; Tue,  5 Sep 2017 05:39:39 -0700 (PDT)"],"From":"Gilad Ben-Yossef <gilad@benyossef.com>","To":"Herbert Xu <herbert@gondor.apana.org.au>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tJonathan Corbet <corbet@lwn.net>, David Howells <dhowells@redhat.com>,\n\tTom Lendacky <thomas.lendacky@amd.com>, Gary Hook <gary.hook@amd.com>,\n\tBoris Brezillon <boris.brezillon@free-electrons.com>,\n\tArnaud Ebalard <arno@natisbad.org>,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tAlasdair Kergon <agk@redhat.com>,\n\tMike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com,\n\tShaohua Li <shli@kernel.org>, Steve French <sfrench@samba.org>,\n\t\"Theodore Y. Ts'o\" <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>,\n\tSteffen Klassert <steffen.klassert@secunet.com>,\n\tAlexey Kuznetsov <kuznet@ms2.inr.ac.ru>,\n\tHideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,\n\tMimi Zohar <zohar@linux.vnet.ibm.com>,\n\tDmitry Kasatkin <dmitry.kasatkin@gmail.com>,\n\tJames Morris <james.l.morris@oracle.com>,\n\t\"Serge E. Hallyn\" <serge@hallyn.com>, linux-crypto@vger.kernel.org,\n\tlinux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkeyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-mediatek@lists.infradead.org, linux-raid@vger.kernel.org,\n\tlinux-cifs@vger.kernel.org, samba-technical@lists.samba.org,\n\tlinux-fscrypt@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-ima-devel@lists.sourceforge.net,\n\tlinux-ima-user@lists.sourceforge.net,\n\tlinux-security-module@vger.kernel.org","Cc":"Ofir Drang <ofir.drang@arm.com>","Subject":"[PATCH v8 02/20] crypto: ccp: use -EAGAIN for transient busy\n\tindication","Date":"Tue,  5 Sep 2017 15:38:41 +0300","Message-Id":"<1504615144-29770-3-git-send-email-gilad@benyossef.com>","X-Mailer":"git-send-email 2.1.4","In-Reply-To":"<1504615144-29770-1-git-send-email-gilad@benyossef.com>","References":"<1504615144-29770-1-git-send-email-gilad@benyossef.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Replace -EBUSY with -EAGAIN when reporting transient busy\nindication in the absence of backlog.\n\nSigned-off-by: Gilad Ben-Yossef <gilad@benyossef.com>\nReviewed-by: Gary R Hook <gary.hook@amd.com>\n\n---\n\nPlease squash this patch with the previous one when merging upstream.\n---\n drivers/crypto/ccp/ccp-crypto-main.c | 8 +++-----\n drivers/crypto/ccp/ccp-dev.c         | 7 +++++--\n 2 files changed, 8 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/crypto/ccp/ccp-crypto-main.c b/drivers/crypto/ccp/ccp-crypto-main.c\nindex 35a9de7..403ff0a 100644\n--- a/drivers/crypto/ccp/ccp-crypto-main.c\n+++ b/drivers/crypto/ccp/ccp-crypto-main.c\n@@ -222,9 +222,10 @@ static int ccp_crypto_enqueue_cmd(struct ccp_crypto_cmd *crypto_cmd)\n \n \t/* Check if the cmd can/should be queued */\n \tif (req_queue.cmd_count >= CCP_CRYPTO_MAX_QLEN) {\n-\t\tret = -EBUSY;\n-\t\tif (!(crypto_cmd->cmd->flags & CCP_CMD_MAY_BACKLOG))\n+\t\tif (!(crypto_cmd->cmd->flags & CCP_CMD_MAY_BACKLOG)) {\n+\t\t\tret = -EAGAIN;\n \t\t\tgoto e_lock;\n+\t\t}\n \t}\n \n \t/* Look for an entry with the same tfm.  If there is a cmd\n@@ -243,9 +244,6 @@ static int ccp_crypto_enqueue_cmd(struct ccp_crypto_cmd *crypto_cmd)\n \t\tret = ccp_enqueue_cmd(crypto_cmd->cmd);\n \t\tif (!ccp_crypto_success(ret))\n \t\t\tgoto e_lock;\t/* Error, don't queue it */\n-\t\tif ((ret == -EBUSY) &&\n-\t\t    !(crypto_cmd->cmd->flags & CCP_CMD_MAY_BACKLOG))\n-\t\t\tgoto e_lock;\t/* Not backlogging, don't queue it */\n \t}\n \n \tif (req_queue.cmd_count >= CCP_CRYPTO_MAX_QLEN) {\ndiff --git a/drivers/crypto/ccp/ccp-dev.c b/drivers/crypto/ccp/ccp-dev.c\nindex 4e029b1..3d637e3 100644\n--- a/drivers/crypto/ccp/ccp-dev.c\n+++ b/drivers/crypto/ccp/ccp-dev.c\n@@ -292,9 +292,12 @@ int ccp_enqueue_cmd(struct ccp_cmd *cmd)\n \ti = ccp->cmd_q_count;\n \n \tif (ccp->cmd_count >= MAX_CMD_QLEN) {\n-\t\tret = -EBUSY;\n-\t\tif (cmd->flags & CCP_CMD_MAY_BACKLOG)\n+\t\tif (cmd->flags & CCP_CMD_MAY_BACKLOG) {\n+\t\t\tret = -EBUSY;\n \t\t\tlist_add_tail(&cmd->entry, &ccp->backlog);\n+\t\t} else {\n+\t\t\tret = -EAGAIN;\n+\t\t}\n \t} else {\n \t\tret = -EINPROGRESS;\n \t\tccp->cmd_count++;\n","prefixes":["v8","02/20"]}