{"id":810090,"url":"http://patchwork.ozlabs.org/api/patches/810090/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/patch/20170905113906.19438-1-ardeleanalex@gmail.com/","project":{"id":54,"url":"http://patchwork.ozlabs.org/api/projects/54/?format=json","name":"LEDE development","link_name":"lede","list_id":"lede-dev.lists.infradead.org","list_email":"lede-dev@lists.infradead.org","web_url":"http://lede-project.org/","scm_url":"","webscm_url":"http://git.lede-project.org/","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170905113906.19438-1-ardeleanalex@gmail.com>","list_archive_url":null,"date":"2017-09-05T11:39:06","name":"[LEDE-DEV] netifd-proto.sh: add ip4table & ip6table to `proto_add_dynamic_defaults()`","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"93e4007dadb9424a2b51b650c984f6ff4788ae7d","submitter":{"id":65503,"url":"http://patchwork.ozlabs.org/api/people/65503/?format=json","name":"Alexandru Ardelean","email":"ardeleanalex@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/lede/patch/20170905113906.19438-1-ardeleanalex@gmail.com/mbox/","series":[{"id":1559,"url":"http://patchwork.ozlabs.org/api/series/1559/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/list/?series=1559","date":"2017-09-05T11:39:06","name":"[LEDE-DEV] netifd-proto.sh: add ip4table & ip6table to `proto_add_dynamic_defaults()`","version":1,"mbox":"http://patchwork.ozlabs.org/series/1559/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810090/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810090/checks/","tags":{},"related":[],"headers":{"Return-Path":"<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"ahYkY80D\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"rhGHc0zO\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmlBK3kwFz9sPs\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  5 Sep 2017 21:39:53 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpCCi-0006li-Bm; Tue, 05 Sep 2017 11:39:40 +0000","from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpCCf-0006gk-MI\n\tfor lede-dev@lists.infradead.org; Tue, 05 Sep 2017 11:39:39 +0000","by mail-pf0-x242.google.com with SMTP id q76so1569489pfq.5\n\tfor <lede-dev@lists.infradead.org>;\n\tTue, 05 Sep 2017 04:39:17 -0700 (PDT)","from orion.nbttech.com\n\t(riverbed-technology-inc.vlan571.asr1.fra4.gblx.net. [208.48.24.254])\n\tby smtp.googlemail.com with ESMTPSA id\n\tp12sm1294531pgd.0.2017.09.05.04.39.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 05 Sep 2017 04:39:15 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:\n\tDate:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=X6CgJ1DjdFy0cNMLwucuzwf5HnlHpxFiEYerfyfTDGw=;\n\tb=ahYkY80DlPQ79j\n\tYNhZO0T/N/vLmS6RlDOJYPc2gy9iTaYPjHwi2VB0fU3rOEbFY5F6Q6zJMdqWbfr/1Syv95AIkQi7v\n\tPSLG6Wgmq77pA83+Hq901lGlC6GdAKPk7uIit5YpHqzbcLflSKxvKequ7yDjpykxHgWwLGuyf/2jO\n\tmi3RrNd9a26k07+S3UWlHTJUpYGwzL6aKAXLEVOxWZkedCVzfusjPJuWZVDNdNSJGP7VVU8Iqq31S\n\t1ZXtCeBpDcuUSNtXM8xnGq8fIeMcRgyel37o9ffENb5fLLauxBm08ZdwSTaOLtbIGRQ+JqTGeNbgh\n\tgScZZ/aXTm2GO+UcBYJA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=Bm/DsIAvhBW4lgmjL6ernYK9OCyG9yPsP0bCoHgr90s=;\n\tb=rhGHc0zObcIzxPbwEmPu0ERtbOST4L4/rPfTonrGo59cXazgIlwpbLAO4tfSBNkmEV\n\tw3G+5j9GSq/V6vUmSYSLPfdisgVbdRt742kTdyKqgDYY7oM3GOLCgnpZ/tR2s3Pcfy7/\n\tXELHEMTlgWClRKJ/OJ7dQu/U6VS0Io61xzRinF4Gl75ftKcTZCT4+2FZzhBLUg19+YGc\n\t6Vu3wrjK1gUW2PGi3nJsJ4VuTS7G75qei0t+RFFAKUyHaG6ynAPePdT3/Osx/826Y7P/\n\tiU9ZAJBG847LimgPN7/IY3RZXNRcSWUjcY5JyZfsjr9+i/7LdfAJo4OBAQQHH6mwcT/z\n\tQz8w=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=Bm/DsIAvhBW4lgmjL6ernYK9OCyG9yPsP0bCoHgr90s=;\n\tb=AvauQxUkAPqnkQ+2sU236CXtsLyj+tjUSFf+0Q4jdBeKkKHqOnTBy8iXxJNGzFCy8f\n\t9M3xJh15kCTNknxyEbAYJZljPaq8sq2U3lZQNTNGtO+wTzerw/PcCqPzrfOSiCD/wvor\n\te6h2ty8UHWskDu+K6XEtRIrCGuhSqTPLcWHp/Jr7mNEvztL9BL2Ai4dWLjFFU79/UMP/\n\tTI+7b3pqtdGrNBOWB1GoEEYnMgPHeZO4XQEY4XEOM75nbBmUyaQfCLefWINkcpQweJ7B\n\t0pxqSG+jzp+6w9JCKffzfLVjxKqQRaMRKaDG8tj99kf8oq63JJ07dPZ3soEfiVb6zmZD\n\tj1GA==","X-Gm-Message-State":"AHPjjUiPXI+jMy3pj73dx9CdHkEIWJpeS/OnCgiKHfsvqEpJ689f55i6\n\twQCEPSVMHQnu2v4O","X-Google-Smtp-Source":"ADKCNb7EVWbZzf4olrQ61gzosUlK4wh0uPVGVPviVwpUOBeClleWZAxshpu16SXJPJVNJVvv6Ew20w==","X-Received":"by 10.99.1.201 with SMTP id 192mr3730832pgb.282.1504611556854;\n\tTue, 05 Sep 2017 04:39:16 -0700 (PDT)","From":"Alexandru Ardelean <ardeleanalex@gmail.com>","To":"lede-dev@lists.infradead.org","Date":"Tue,  5 Sep 2017 14:39:06 +0300","Message-Id":"<20170905113906.19438-1-ardeleanalex@gmail.com>","X-Mailer":"git-send-email 2.11.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170905_043937_796582_F03A872B ","X-CRM114-Status":"UNSURE (   7.33  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c00:0:0:0:242 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (ardeleanalex[at]gmail.com)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"[LEDE-DEV] [PATCH] netifd-proto.sh: add ip4table & ip6table to\n\t`proto_add_dynamic_defaults()`","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<lede-dev.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/lede-dev/>","List-Post":"<mailto:lede-dev@lists.infradead.org>","List-Help":"<mailto:lede-dev-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>","Cc":"dedeckeh@gmail.com, Alexandru Ardelean <ardeleanalex@gmail.com>,\n\tnbd@nbd.name","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"The `proto_add_dynamic_defaults()` seems to be called mostly\nin the context of LTE/3G modems (via wwan, qmi, etc) setup.\n\nWhen they get setup, these devices override default routes.\n\nHowever, depending on setup, we want these modems to\nbe part of a another routing table.\nThis change allows that.\n\nip4table/ip6table are of string type in netifd to allow\nfor `default`, `local` routing table names to be specified.\n\nSigned-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>\n---\n scripts/netifd-proto.sh | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/scripts/netifd-proto.sh b/scripts/netifd-proto.sh\nindex cc7031a..fd7b596 100644\n--- a/scripts/netifd-proto.sh\n+++ b/scripts/netifd-proto.sh\n@@ -26,6 +26,8 @@ proto_add_dynamic_defaults() {\n \t[ -n \"$defaultroute\" ] && json_add_boolean defaultroute \"$defaultroute\"\n \t[ -n \"$peerdns\" ] && json_add_boolean peerdns \"$peerdns\"\n \t[ -n \"$metric\" ] && json_add_int metric \"$metric\"\n+\t[ -n \"$ip4table\" ] && json_add_string ip4table \"$ip4table\"\n+\t[ -n \"$ip6table\" ] && json_add_string ip6table \"$ip6table\"\n }\n \n _proto_do_teardown() {\n","prefixes":["LEDE-DEV"]}