{"id":810077,"url":"http://patchwork.ozlabs.org/api/patches/810077/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170905105442.30972-1-jakub.kicinski@netronome.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170905105442.30972-1-jakub.kicinski@netronome.com>","list_archive_url":null,"date":"2017-09-05T10:54:42","name":"[net] net: sched: don't use GFP_KERNEL under spin lock","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"de8ac4a513a8c2229754a797c41ad250cccbd871","submitter":{"id":67484,"url":"http://patchwork.ozlabs.org/api/people/67484/?format=json","name":"Jakub Kicinski","email":"jakub.kicinski@netronome.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170905105442.30972-1-jakub.kicinski@netronome.com/mbox/","series":[{"id":1548,"url":"http://patchwork.ozlabs.org/api/series/1548/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=1548","date":"2017-09-05T10:54:42","name":"[net] net: sched: don't use GFP_KERNEL under spin lock","version":1,"mbox":"http://patchwork.ozlabs.org/series/1548/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810077/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810077/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=netronome-com.20150623.gappssmtp.com\n\theader.i=@netronome-com.20150623.gappssmtp.com\n\theader.b=\"weat7Pm6\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmkDx4gM5z9sP3\n\tfor ;\n\tTue, 5 Sep 2017 20:57:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750814AbdIEK5D (ORCPT );\n\tTue, 5 Sep 2017 06:57:03 -0400","from mail-pg0-f43.google.com ([74.125.83.43]:35556 \"EHLO\n\tmail-pg0-f43.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750748AbdIEK5C (ORCPT\n\t); Tue, 5 Sep 2017 06:57:02 -0400","by mail-pg0-f43.google.com with SMTP id 188so5363589pgb.2\n\tfor ; Tue, 05 Sep 2017 03:57:01 -0700 (PDT)","from jkicinski-Precision-T1700.netronome.com ([75.53.12.129])\n\tby smtp.gmail.com with ESMTPSA id\n\tk78sm602124pfb.157.2017.09.05.03.57.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 05 Sep 2017 03:57:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=netronome-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=bxgulnfVeX7C61TG4P4O0awg+Dk4wVeqcE87p9HeRaM=;\n\tb=weat7Pm6NMfp78fURT6RHdBQ8K7OIa95g7tVokdKx+47Y3sH1wLjEPiQ3oSS3taTSn\n\t49SDRC6xpxCvjMdXc3m1+P7luFeU8d6kCrmqc3gW9cdZ61dBdhYddvbMShM3mCI55Azh\n\teFsVcAxmr5o2njoh3p8ze+hiOYkI3A8FuPiApd/7KkTIlFGHx4fhHpoOkuawvchQJQGf\n\tyi+NFXUyqj01k6sQa81HoJo+KvSAX8Dq+etHc6u1xrV9TdnSMaOqDFEPd/eds69SFRDh\n\t7bn919jg2GSAoHPFv7jLM8AHjfQBjt+SDCdFJOCl3SVtjrnWLHKvEgmRvqqv+QaqTyqo\n\tH50A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=bxgulnfVeX7C61TG4P4O0awg+Dk4wVeqcE87p9HeRaM=;\n\tb=mtknW6FJomHR+hyHrju/vKqW52mzxNm7gPtwY4oQUIg6m0QXZ8Jgut/ZG5BG4O2BEr\n\t8EBLQi39gxV8zbuXpxUU3wFBaAY1JwbssVkE7XY9qecLxCcNIDw2xJkzOn46vDb8xJ4o\n\txDpUu6vZHUGHNb9CDZurO+RiYqya8N8vD6KmzjWaCQq4ffZ5B+3VINodXcIgUgsX77Qx\n\tnR0Ev1wMnpKzwWmFgYW9oSHaonC58fVDCscdljbHP1zv/p8uWIrT7ueVeIwbLncgPJfJ\n\tToq1PavnZWb9buxY2VEsuisTfr9oFKFCb4jzzJE96aVVFnB6sd3mwgHTaXm1Xpcx8t4n\n\tj2AA==","X-Gm-Message-State":"AHPjjUgBvismsA7LpESotjrF2p4iwEU3HIJWWi1IJbjqkvcLSUAkl53v\n\tR8wdPD6NfLOicQL560k=","X-Google-Smtp-Source":"ADKCNb5C7nla/xzfbjLLd0yH5b0/0cF40HPdNjR11oIBJAfoRshyUPPQK0aOJHlOdlV/rU89KXFLIA==","X-Received":"by 10.84.129.193 with SMTP id b59mr3865315plb.147.1504609021242; \n\tTue, 05 Sep 2017 03:57:01 -0700 (PDT)","From":"Jakub Kicinski ","To":"netdev@vger.kernel.org","Cc":"jiri@resnulli.us, Chris Mi ,\n\txiyou.wangcong@gmail.com, jhs@mojatatu.com, oss-drivers@netronome.com,\n\tJakub Kicinski ","Subject":"[PATCH net] net: sched: don't use GFP_KERNEL under spin lock","Date":"Tue, 5 Sep 2017 03:54:42 -0700","Message-Id":"<20170905105442.30972-1-jakub.kicinski@netronome.com>","X-Mailer":"git-send-email 2.14.1","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"The new TC IDR code uses GFP_KERNEL under spinlocks. Which leads\nto:\n\n[ 582.621091] BUG: sleeping function called from invalid context at ../mm/slab.h:416\n[ 582.629721] in_atomic(): 1, irqs_disabled(): 0, pid: 3379, name: tc\n[ 582.636939] 2 locks held by tc/3379:\n[ 582.641049] #0: (rtnl_mutex){+.+.+.}, at: [] rtnetlink_rcv_msg+0x92e/0x1400\n[ 582.650958] #1: (&(&tn->idrinfo->lock)->rlock){+.-.+.}, at: [] tcf_idr_create+0x2f0/0x8e0\n[ 582.662217] Preemption disabled at:\n[ 582.662222] [] tcf_idr_create+0x2f0/0x8e0\n[ 582.672592] CPU: 9 PID: 3379 Comm: tc Tainted: G W 4.13.0-rc7-debug-00648-g43503a79b9f0 #287\n[ 582.683432] Hardware name: Dell Inc. PowerEdge R730/072T6D, BIOS 2.3.4 11/08/2016\n[ 582.691937] Call Trace:\n...\n[ 582.713332] ? tcf_idr_create+0x2f0/0x8e0\n[ 582.717925] ___might_sleep+0x40f/0x660\n[ 582.722336] ? finish_task_switch+0xb90/0xb90\n[ 582.727315] ? mark_held_locks+0xdd/0x190\n[ 582.731908] __might_sleep+0xba/0x240\n[ 582.736125] ? radix_tree_node_alloc.constprop.6+0x4a/0x450\n[ 582.742460] kmem_cache_alloc+0x286/0x540\n[ 582.747055] radix_tree_node_alloc.constprop.6+0x4a/0x450\n[ 582.753209] idr_get_free_cmn+0x627/0xf80\n...\n[ 582.815525] idr_alloc_cmn+0x1a8/0x270\n[ 582.819821] ? __raw_spin_lock_init+0x21/0x120\n[ 582.824914] ? idr_replace+0x20/0x20\n[ 582.829013] ? do_raw_spin_lock+0x1f0/0x1f0\n[ 582.833804] tcf_idr_create+0x31b/0x8e0\n...\n\nFixes: 65a206c01e8e (\"net/sched: Change act_api and act_xxx modules to use IDR\")\nSigned-off-by: Jakub Kicinski \nReviewed-by: Simon Horman \n---\n net/sched/act_api.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/net/sched/act_api.c b/net/sched/act_api.c\nindex 0eb545bcb247..a48e4b45722d 100644\n--- a/net/sched/act_api.c\n+++ b/net/sched/act_api.c\n@@ -298,7 +298,7 @@ int tcf_idr_create(struct tc_action_net *tn, u32 index, struct nlattr *est,\n \tif (!index) {\n \t\tspin_lock_bh(&idrinfo->lock);\n \t\terr = idr_alloc_ext(idr, NULL, &idr_index, 1, 0,\n-\t\t\t\t GFP_KERNEL);\n+\t\t\t\t GFP_ATOMIC);\n \t\tspin_unlock_bh(&idrinfo->lock);\n \t\tif (err) {\n err3:\n@@ -309,7 +309,7 @@ int tcf_idr_create(struct tc_action_net *tn, u32 index, struct nlattr *est,\n \t} else {\n \t\tspin_lock_bh(&idrinfo->lock);\n \t\terr = idr_alloc_ext(idr, NULL, NULL, index, index + 1,\n-\t\t\t\t GFP_KERNEL);\n+\t\t\t\t GFP_ATOMIC);\n \t\tspin_unlock_bh(&idrinfo->lock);\n \t\tif (err)\n \t\t\tgoto err3;\n","prefixes":["net"]}