{"id":810038,"url":"http://patchwork.ozlabs.org/api/patches/810038/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20170905092440.2172429-1-arnd@arndb.de/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170905092440.2172429-1-arnd@arndb.de>","list_archive_url":null,"date":"2017-09-05T09:24:15","name":"cifs: hide unused functions","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6d17b30c747a2368cd3043c5f3a8e2e1d55ea3ae","submitter":{"id":30,"url":"http://patchwork.ozlabs.org/api/people/30/?format=json","name":"Arnd Bergmann","email":"arnd@arndb.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20170905092440.2172429-1-arnd@arndb.de/mbox/","series":[{"id":1530,"url":"http://patchwork.ozlabs.org/api/series/1530/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=1530","date":"2017-09-05T09:24:15","name":"cifs: hide unused functions","version":1,"mbox":"http://patchwork.ozlabs.org/series/1530/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810038/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810038/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmhCn6zY9z9s0g\n\tfor ;\n\tTue, 5 Sep 2017 19:25:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750718AbdIEJZ4 (ORCPT );\n\tTue, 5 Sep 2017 05:25:56 -0400","from mout.kundenserver.de ([212.227.126.135]:59108 \"EHLO\n\tmout.kundenserver.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750707AbdIEJZz (ORCPT\n\t); Tue, 5 Sep 2017 05:25:55 -0400","from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de\n\t(mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id\n\t0LmzUL-1dHTpn3O1N-00hPDb; Tue, 05 Sep 2017 11:24:42 +0200"],"From":"Arnd Bergmann ","To":"Steve French ","Cc":"Arnd Bergmann , Pavel Shilovsky ,\n\tSachin Prabhu , Aurelien Aptel ,\n\tRonnie Sahlberg ,\n\tlinux-cifs@vger.kernel.org, samba-technical@lists.samba.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH] cifs: hide unused functions","Date":"Tue, 5 Sep 2017 11:24:15 +0200","Message-Id":"<20170905092440.2172429-1-arnd@arndb.de>","X-Mailer":"git-send-email 2.9.0","X-Provags-ID":"V03:K0:mQaZhahmtM1XG38IopTuwmdx0vYm1aiDioAC0l/h7cTy/Ubrl0Z\n\tHXKxA+4kkQ2WslV0YzTAtIAqE+82qEmF8+SjxClkdUcDed6xOSewkn7mUNMQH3E4TOLmLQx\n\tt8584ndvWU98mNG9N3bxBkWIcH/3nTCyHgMZL0w3CtGO+B3EONRnCfFwcIpcrGzirr/Y30U\n\t2JsSyhOBpJkjBqinGLXSQ==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:tgSRTknfqes=:Eap+cQvXPVBaLDlFL9ToSF\n\ti1vpIqBH9+tmrcB4XdFrl5itM24guyfobFLXNHvtPxTSKke2TQGz/dlYN1utim0pTWuN+m3gd\n\tpEx8M/4qWVr+ayTju2/DKKB9x6rpTwhkAOux9d0P86uZFKofHB1dInXcxhV1UDboUKLhMuzDa\n\t1xsjGeD3ccm0bYpchu7WLRjUtf1Yfk5RTmEkc2+GnSsqqoDa1oEbLl8vMHXA/FU7jKgsfwOxv\n\tALQ4A1/YrCRDHgSSoXd+8rjAcvQb4XooWr789ql016KT/R74GtdhBdwl95KM61s9dd4kjrTIC\n\tZq2i51zEBDBPFIW2it090M2KQScOOfw3NJ3dMclnp41n8+aMgbvj5ILexs9jwaecUc1mEMo7P\n\tPyAGzACh94DqWfuQ0DIscRgxnVexVizJtdJgazZGmmg8f7/CEblzEd7PbMU5uvBvrtfE++Thb\n\t6nrMgn8oIl5hhc0qo2g7OV6BUR8rT9TSNlAXPEF6k/NUirx6RQ5Narmq2+f4aPdKsUCbYdftU\n\t5fI9uINJswzfJhom7d/6MjarGfRO6pkaS40yeqn6Wqx3qvfTb5rvtSj37j6SY2V/qIMwACXtC\n\tTwDz8Og9St6i01uzpN+FID+g0V4cfSXB2ec3kBK7YMxvkCkLNGZ+Cy4WG+ZyJkozUaWVPk4yK\n\tzZTydmFq+5SbZJ/Qje2TxMGmUhoIuLVvjdJPqTpLMu+Wfd1ZOWpfa2f70imoY/HHY+B/vNLc/\n\tTJkBlXLeBMJxDlvW5iuzBG3Hd7MQJBnT907tOw==","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"},"content":"The newly added SMB2+ attribute support causes unused function\nwarnings when CONFIG_CIFS_XATTR is disabled:\n\nfs/cifs/smb2ops.c:563:1: error: 'smb2_set_ea' defined but not used [-Werror=unused-function]\n smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon,\nfs/cifs/smb2ops.c:513:1: error: 'smb2_query_eas' defined but not used [-Werror=unused-function]\n smb2_query_eas(const unsigned int xid, struct cifs_tcon *tcon,\n\nThis adds another #ifdef around the affected functions.\n\nFixes: 5517554e4313 (\"cifs: Add support for writing attributes on SMB2+\")\nFixes: 95907fea4fd8 (\"cifs: Add support for reading attributes on SMB2+\")\nSigned-off-by: Arnd Bergmann \n---\n fs/cifs/smb2ops.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c\nindex fb2934b9b97c..6cd91670ba2d 100644\n--- a/fs/cifs/smb2ops.c\n+++ b/fs/cifs/smb2ops.c\n@@ -426,6 +426,7 @@ smb2_query_file_info(const unsigned int xid, struct cifs_tcon *tcon,\n \treturn rc;\n }\n \n+#ifdef CONFIG_CIFS_XATTR\n static ssize_t\n move_smb2_ea_to_cifs(char *dst, size_t dst_size,\n \t\t struct smb2_file_full_ea_info *src, size_t src_size,\n@@ -613,6 +614,7 @@ smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon,\n \n \treturn rc;\n }\n+#endif\n \n static bool\n smb2_can_echo(struct TCP_Server_Info *server)\n","prefixes":[]}