{"id":810032,"url":"http://patchwork.ozlabs.org/api/patches/810032/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170905092230.8243-5-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170905092230.8243-5-berrange@redhat.com>","list_archive_url":null,"date":"2017-09-05T09:22:25","name":"[PULL,v1,4/9] sockets: factor out create_fast_reuse_socket","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eead22cfceb944f8caf72acf929d9fc535aeca9f","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170905092230.8243-5-berrange@redhat.com/mbox/","series":[{"id":1527,"url":"http://patchwork.ozlabs.org/api/series/1527/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1527","date":"2017-09-05T09:22:21","name":"[PULL,v1,1/9] io: fix temp directory used by test-io-channel-tls test","version":1,"mbox":"http://patchwork.ozlabs.org/series/1527/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810032/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810032/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmh9R0jL3z9sNr\n\tfor ;\n\tTue, 5 Sep 2017 19:23:55 +1000 (AEST)","from localhost ([::1]:57664 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpA5J-0001W7-5u\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 05:23:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41162)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpA4D-00019p-A0\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:22:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpA48-0002iJ-FU\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:22:45 -0400","from mx1.redhat.com ([209.132.183.28]:35672)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpA48-0002hY-A2\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:22:40 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 66CF9285B2;\n\tTue, 5 Sep 2017 09:22:39 +0000 (UTC)","from t460.redhat.com (unknown [10.33.36.63])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7A1F86E50A;\n\tTue, 5 Sep 2017 09:22:38 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 66CF9285B2","From":"\"Daniel P. Berrange\" ","To":"qemu-devel@nongnu.org","Date":"Tue, 5 Sep 2017 10:22:25 +0100","Message-Id":"<20170905092230.8243-5-berrange@redhat.com>","In-Reply-To":"<20170905092230.8243-1-berrange@redhat.com>","References":"<20170905092230.8243-1-berrange@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tTue, 05 Sep 2017 09:22:39 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL v1 4/9] sockets: factor out\n\tcreate_fast_reuse_socket","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\tKnut Omang ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Knut Omang \n\nAnother refactoring step to prepare for fixing the problem\nexposed with the test-listen test in the previous commit\n\nSigned-off-by: Knut Omang \nReviewed-by: Daniel P. Berrange \nSigned-off-by: Daniel P. Berrange \n---\n util/qemu-sockets.c | 15 ++++++++++++---\n 1 file changed, 12 insertions(+), 3 deletions(-)","diff":"diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c\nindex b4a2f243f4..d0d20476e5 100644\n--- a/util/qemu-sockets.c\n+++ b/util/qemu-sockets.c\n@@ -149,6 +149,16 @@ int inet_ai_family_from_address(InetSocketAddress *addr,\n return PF_UNSPEC;\n }\n \n+static int create_fast_reuse_socket(struct addrinfo *e)\n+{\n+ int slisten = qemu_socket(e->ai_family, e->ai_socktype, e->ai_protocol);\n+ if (slisten < 0) {\n+ return -1;\n+ }\n+ socket_set_fast_reuse(slisten);\n+ return slisten;\n+}\n+\n static int try_bind(int socket, InetSocketAddress *saddr, struct addrinfo *e)\n {\n #ifndef IPV6_V6ONLY\n@@ -253,7 +263,8 @@ static int inet_listen_saddr(InetSocketAddress *saddr,\n getnameinfo((struct sockaddr*)e->ai_addr,e->ai_addrlen,\n \t\t uaddr,INET6_ADDRSTRLEN,uport,32,\n \t\t NI_NUMERICHOST | NI_NUMERICSERV);\n- slisten = qemu_socket(e->ai_family, e->ai_socktype, e->ai_protocol);\n+\n+ slisten = create_fast_reuse_socket(e);\n if (slisten < 0) {\n if (!e->ai_next) {\n error_setg_errno(errp, errno, \"Failed to create socket\");\n@@ -261,8 +272,6 @@ static int inet_listen_saddr(InetSocketAddress *saddr,\n continue;\n }\n \n- socket_set_fast_reuse(slisten);\n-\n port_min = inet_getport(e);\n port_max = saddr->has_to ? saddr->to + port_offset : port_min;\n for (p = port_min; p <= port_max; p++) {\n","prefixes":["PULL","v1","4/9"]}