{"id":809996,"url":"http://patchwork.ozlabs.org/api/patches/809996/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170905083146.1289546-1-arnd@arndb.de/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170905083146.1289546-1-arnd@arndb.de>","list_archive_url":null,"date":"2017-09-05T08:31:35","name":"soc: ti/knav_dma: include dmaengine header","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"322f0ed0508619c7fb910bb3c85d77cfa81c1065","submitter":{"id":30,"url":"http://patchwork.ozlabs.org/api/people/30/?format=json","name":"Arnd Bergmann","email":"arnd@arndb.de"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170905083146.1289546-1-arnd@arndb.de/mbox/","series":[{"id":1511,"url":"http://patchwork.ozlabs.org/api/series/1511/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=1511","date":"2017-09-05T08:31:35","name":"soc: ti/knav_dma: include dmaengine header","version":1,"mbox":"http://patchwork.ozlabs.org/series/1511/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809996/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809996/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmg235YVTz9s7f\n\tfor ;\n\tTue, 5 Sep 2017 18:32:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751462AbdIEIcJ (ORCPT );\n\tTue, 5 Sep 2017 04:32:09 -0400","from mout.kundenserver.de ([217.72.192.73]:54147 \"EHLO\n\tmout.kundenserver.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751376AbdIEIcH (ORCPT\n\t); Tue, 5 Sep 2017 04:32:07 -0400","from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de\n\t(mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id\n\t0M09s4-1dUKZG13me-00uFFA; Tue, 05 Sep 2017 10:31:50 +0200"],"From":"Arnd Bergmann ","To":"arm@kernel.org, \"David S. Miller\" ","Cc":"Dave Jiang , netdev@vger.kernel.org,\n\tArnd Bergmann ,\n\t\"Karicheri, Muralidharan\" ,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH] soc: ti/knav_dma: include dmaengine header","Date":"Tue, 5 Sep 2017 10:31:35 +0200","Message-Id":"<20170905083146.1289546-1-arnd@arndb.de>","X-Mailer":"git-send-email 2.9.0","X-Provags-ID":"V03:K0:o0v+92kIxBQ/8VQPgoMYxg2whroulUGcyNMT/WSyMxcdD5jwgpH\n\tT1mjXKEWj/LmeuDu0Hyv90Vgz8Ev59j7Usp/7nCRplq+HlL2lIGD07k0PBTCkMWKUyY7+k9\n\taJ/iX4RAFyykIth9bbXgz5BNJfRsSqHDTjd6ZD+5UYBiYH9JmdBk6cZDVf9HvoH4Icygwxm\n\t9OOZLHtrjDIEvGo8E/4RA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:I3RwZ0Fw1A0=:/NpW+yVftUs9ga2MXPb6lh\n\tJZ88uQovAkG0ZXmVY9N9XHBUGYHVYfxAZzXaWh06ojw7/p4wXdbyF32DzrWSqvABKbym2siBL\n\t16JORiERMsJdPAQwVdmijGllkIeBuN6n/LN7q15ULF3NAVGpjro6BccYBGQyg5ra+5Cv2Aa9D\n\tOO8OzcPu2XTiPva2yUEPb2llXe18iu2yN/omqA6p28XjRpezweY/WWGJd0zuAY9JcA6D/JOcr\n\tyhPgWbfc53diYyBTXXtlnsXOBBFcPI5IfvjfahgjGblISj0+vAqdQNomZvQMxHa3i3uzh7gNO\n\tMnm2pF5PufWckNwKs4pWN23I4JJgFiNXOCdJOWBbVmpNJdwLS9N89IGHpvQbCi3+FE2oksj8m\n\tMGQjr8AM4AgZagpvdCCHSbXp4PD0w7CvbBS+cltexWln5tjVcps8dkphCP/cN2hpGBfApP450\n\te3cTl2w//zrHE7LZVJWzVoX7kz3t8pyT5no/UXP7FC/4zinUh9iJ5EvR0NalKSe/VDJN/UaIk\n\tw/JHvE3wDvp7JALqRIosVKeqQ+VQGLyG5TBkRdSKhroDmMgBMijyGVV202dJoFXkhKaOgl1gP\n\tugVypD7hx4UuL9XaWjuVWYPdo1hVs4HfG5i7SAfR737tJavLdBHlDrW5r0OqPY+UZNcG2ciMT\n\tpqWFLbH0kWMLfy+yh35a+4t9NynByPbo3AFq8Hb+fbIAGFQQ9f+mpXlV18ZuCKCUJmCaebZ+R\n\tvaR3J60hgxPiieKf3lozfEJAASS4G8HOxsNAKA==","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"A header file cleanup apparently caused a build regression\nwith one driver using the knav infrastructure:\n\nIn file included from drivers/net/ethernet/ti/netcp_core.c:30:0:\ninclude/linux/soc/ti/knav_dma.h:129:30: error: field 'direction' has incomplete type\n enum dma_transfer_direction direction;\n ^~~~~~~~~\ndrivers/net/ethernet/ti/netcp_core.c: In function 'netcp_txpipe_open':\ndrivers/net/ethernet/ti/netcp_core.c:1349:21: error: 'DMA_MEM_TO_DEV' undeclared (first use in this function); did you mean 'DMA_MEMORY_MAP'?\n config.direction = DMA_MEM_TO_DEV;\n ^~~~~~~~~~~~~~\n DMA_MEMORY_MAP\ndrivers/net/ethernet/ti/netcp_core.c:1349:21: note: each undeclared identifier is reported only once for each function it appears in\ndrivers/net/ethernet/ti/netcp_core.c: In function 'netcp_setup_navigator_resources':\ndrivers/net/ethernet/ti/netcp_core.c:1659:22: error: 'DMA_DEV_TO_MEM' undeclared (first use in this function); did you mean 'DMA_DESC_HOST'?\n config.direction = DMA_DEV_TO_MEM;\n\nAs the header is no longer included implicitly through netdevice.h,\nwe should include it in the header that references the enum.\n\nFixes: 0dd5759dbb1c (\"net: remove dmaengine.h inclusion from netdevice.h\")\nSigned-off-by: Arnd Bergmann \n---\nIf the cleanup patch hasn't been submitted for mainline yet, please\nadd this fixup to the net-next tree, otherwise I'll merge it through\narm-soc.\n---\n include/linux/soc/ti/knav_dma.h | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/include/linux/soc/ti/knav_dma.h b/include/linux/soc/ti/knav_dma.h\nindex 2b7882666ef6..66693bc4c6ad 100644\n--- a/include/linux/soc/ti/knav_dma.h\n+++ b/include/linux/soc/ti/knav_dma.h\n@@ -17,6 +17,8 @@\n #ifndef __SOC_TI_KEYSTONE_NAVIGATOR_DMA_H__\n #define __SOC_TI_KEYSTONE_NAVIGATOR_DMA_H__\n \n+#include \n+\n /*\n * PKTDMA descriptor manipulation macros for host packet descriptor\n */\n","prefixes":[]}