{"id":809844,"url":"http://patchwork.ozlabs.org/api/patches/809844/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20170904204608.7090-5-alexandre.belloni@free-electrons.com/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170904204608.7090-5-alexandre.belloni@free-electrons.com>","list_archive_url":null,"date":"2017-09-04T20:46:06","name":"[5/7] rtc: ds1307: fix alignments and blank lines","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9dddc9e3720aa1d05a9b169b09c9322c90423862","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/people/26276/?format=json","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20170904204608.7090-5-alexandre.belloni@free-electrons.com/mbox/","series":[{"id":1455,"url":"http://patchwork.ozlabs.org/api/series/1455/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/list/?series=1455","date":"2017-09-04T20:46:03","name":"[1/7] rtc: ds1307: remove regs member","version":1,"mbox":"http://patchwork.ozlabs.org/series/1455/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809844/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809844/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmMP057Y0z9sRm\n\tfor ;\n\tTue, 5 Sep 2017 06:47:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754025AbdIDUr0 (ORCPT );\n\tMon, 4 Sep 2017 16:47:26 -0400","from mail.free-electrons.com ([62.4.15.54]:53967 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754026AbdIDUqN (ORCPT\n\t); Mon, 4 Sep 2017 16:46:13 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid DAC9B208F1; Mon, 4 Sep 2017 22:46:10 +0200 (CEST)","from localhost (unknown [88.191.26.124])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id B47A420870;\n\tMon, 4 Sep 2017 22:46:10 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Alexandre Belloni ","To":"linux-rtc@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, Heiner Kallweit ,\n\tAlexandre Belloni ","Subject":"[PATCH 5/7] rtc: ds1307: fix alignments and blank lines","Date":"Mon, 4 Sep 2017 22:46:06 +0200","Message-Id":"<20170904204608.7090-5-alexandre.belloni@free-electrons.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170904204608.7090-1-alexandre.belloni@free-electrons.com>","References":"<20170904204608.7090-1-alexandre.belloni@free-electrons.com>","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"},"content":"Alignment should always match open parenthesis.\nAlso remove two unnecessary blank lines\n\nSigned-off-by: Alexandre Belloni \n---\n drivers/rtc/rtc-ds1307.c | 21 ++++++++++-----------\n 1 file changed, 10 insertions(+), 11 deletions(-)","diff":"diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c\nindex 5b2fe3579e45..bac0f9ec9351 100644\n--- a/drivers/rtc/rtc-ds1307.c\n+++ b/drivers/rtc/rtc-ds1307.c\n@@ -51,7 +51,6 @@ enum ds_type {\n \t/* rs5c372 too? different address... */\n };\n \n-\n /* RTC registers don't differ much, except for the century flag */\n #define DS1307_REG_SECS\t\t0x00\t/* 00-59 */\n #\tdefine DS1307_BIT_CH\t\t0x80\n@@ -114,7 +113,6 @@ enum ds_type {\n #\tdefine RX8025_BIT_VDET\t\t0x40\n #\tdefine RX8025_BIT_XST\t\t0x20\n \n-\n struct ds1307 {\n \tstruct nvmem_config\tnvmem_cfg;\n \tenum ds_type\t\ttype;\n@@ -1042,7 +1040,7 @@ static int ds3231_hwmon_read_temp(struct device *dev, s32 *mC)\n }\n \n static ssize_t ds3231_hwmon_show_temp(struct device *dev,\n-\t\t\t\tstruct device_attribute *attr, char *buf)\n+\t\t\t\t struct device_attribute *attr, char *buf)\n {\n \tint ret;\n \ts32 temp;\n@@ -1054,7 +1052,7 @@ static ssize_t ds3231_hwmon_show_temp(struct device *dev,\n \treturn sprintf(buf, \"%d\\n\", temp);\n }\n static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, ds3231_hwmon_show_temp,\n-\t\t\tNULL, 0);\n+\t\t\t NULL, 0);\n \n static struct attribute *ds3231_hwmon_attrs[] = {\n \t&sensor_dev_attr_temp1_input.dev_attr.attr,\n@@ -1070,7 +1068,8 @@ static void ds1307_hwmon_register(struct ds1307 *ds1307)\n \t\treturn;\n \n \tdev = devm_hwmon_device_register_with_groups(ds1307->dev, ds1307->name,\n-\t\t\t\t\t\tds1307, ds3231_hwmon_groups);\n+\t\t\t\t\t\t ds1307,\n+\t\t\t\t\t\t ds3231_hwmon_groups);\n \tif (IS_ERR(dev)) {\n \t\tdev_warn(ds1307->dev, \"unable to register hwmon device %ld\\n\",\n \t\t\t PTR_ERR(dev));\n@@ -1142,7 +1141,7 @@ static unsigned long ds3231_clk_sqw_recalc_rate(struct clk_hw *hw,\n }\n \n static long ds3231_clk_sqw_round_rate(struct clk_hw *hw, unsigned long rate,\n-\t\t\t\t\tunsigned long *prate)\n+\t\t\t\t unsigned long *prate)\n {\n \tint i;\n \n@@ -1155,7 +1154,7 @@ static long ds3231_clk_sqw_round_rate(struct clk_hw *hw, unsigned long rate,\n }\n \n static int ds3231_clk_sqw_set_rate(struct clk_hw *hw, unsigned long rate,\n-\t\t\t\t\tunsigned long parent_rate)\n+\t\t\t\t unsigned long parent_rate)\n {\n \tstruct ds1307 *ds1307 = clk_sqw_to_ds1307(hw);\n \tint control = 0;\n@@ -1215,7 +1214,7 @@ static const struct clk_ops ds3231_clk_sqw_ops = {\n };\n \n static unsigned long ds3231_clk_32khz_recalc_rate(struct clk_hw *hw,\n-\t\t\t\t\t\tunsigned long parent_rate)\n+\t\t\t\t\t\t unsigned long parent_rate)\n {\n \treturn 32768;\n }\n@@ -1306,7 +1305,7 @@ static int ds3231_clks_register(struct ds1307 *ds1307)\n \n \t\t/* optional override of the clockname */\n \t\tof_property_read_string_index(node, \"clock-output-names\", i,\n-\t\t\t\t\t\t&init.name);\n+\t\t\t\t\t &init.name);\n \t\tds1307->clks[i].init = &init;\n \n \t\tonecell->clks[i] = devm_clk_register(ds1307->dev,\n@@ -1570,8 +1569,8 @@ static int ds1307_probe(struct i2c_client *client,\n \t\t/* oscillator fault? clear flag, and warn */\n \t\tif (regs[DS1307_REG_CONTROL] & DS1338_BIT_OSF) {\n \t\t\tregmap_write(ds1307->regmap, DS1307_REG_CONTROL,\n-\t\t\t\t\tregs[DS1307_REG_CONTROL] &\n-\t\t\t\t\t~DS1338_BIT_OSF);\n+\t\t\t\t regs[DS1307_REG_CONTROL] &\n+\t\t\t\t ~DS1338_BIT_OSF);\n \t\t\tdev_warn(ds1307->dev, \"SET TIME!\\n\");\n \t\t\tgoto read_rtc;\n \t\t}\n","prefixes":["5/7"]}