{"id":809841,"url":"http://patchwork.ozlabs.org/api/patches/809841/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20170904204608.7090-4-alexandre.belloni@free-electrons.com/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170904204608.7090-4-alexandre.belloni@free-electrons.com>","list_archive_url":null,"date":"2017-09-04T20:46:05","name":"[4/7] rtc: ds1307: use BIT","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7f2a6a57a05b4b5614c692695b1acc3ecc2324f0","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/people/26276/?format=json","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20170904204608.7090-4-alexandre.belloni@free-electrons.com/mbox/","series":[{"id":1455,"url":"http://patchwork.ozlabs.org/api/series/1455/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/list/?series=1455","date":"2017-09-04T20:46:03","name":"[1/7] rtc: ds1307: remove regs member","version":1,"mbox":"http://patchwork.ozlabs.org/series/1455/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809841/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809841/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmMNQ4r9dz9t24\n\tfor ;\n\tTue, 5 Sep 2017 06:47:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754056AbdIDUqU (ORCPT );\n\tMon, 4 Sep 2017 16:46:20 -0400","from mail.free-electrons.com ([62.4.15.54]:53964 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754025AbdIDUqN (ORCPT\n\t); Mon, 4 Sep 2017 16:46:13 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 986F1208F0; Mon, 4 Sep 2017 22:46:10 +0200 (CEST)","from localhost (unknown [88.191.26.124])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 7946120870;\n\tMon, 4 Sep 2017 22:46:10 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Alexandre Belloni ","To":"linux-rtc@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, Heiner Kallweit ,\n\tAlexandre Belloni ","Subject":"[PATCH 4/7] rtc: ds1307: use BIT","Date":"Mon, 4 Sep 2017 22:46:05 +0200","Message-Id":"<20170904204608.7090-4-alexandre.belloni@free-electrons.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170904204608.7090-1-alexandre.belloni@free-electrons.com>","References":"<20170904204608.7090-1-alexandre.belloni@free-electrons.com>","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"},"content":"Use the BIT macro were possbiel.\n\nSigned-off-by: Alexandre Belloni \n---\n drivers/rtc/rtc-ds1307.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)","diff":"diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c\nindex 328183e0e121..5b2fe3579e45 100644\n--- a/drivers/rtc/rtc-ds1307.c\n+++ b/drivers/rtc/rtc-ds1307.c\n@@ -634,11 +634,11 @@ static const struct rtc_class_ops ds13xx_rtc_ops = {\n #define RX8130_REG_ALARM_HOUR\t\t0x08\n #define RX8130_REG_ALARM_WEEK_OR_DAY\t0x09\n #define RX8130_REG_EXTENSION\t\t0x0c\n-#define RX8130_REG_EXTENSION_WADA\t(1 << 3)\n+#define RX8130_REG_EXTENSION_WADA\tBIT(3)\n #define RX8130_REG_FLAG\t\t\t0x0d\n-#define RX8130_REG_FLAG_AF\t\t(1 << 3)\n+#define RX8130_REG_FLAG_AF\t\tBIT(3)\n #define RX8130_REG_CONTROL0\t\t0x0e\n-#define RX8130_REG_CONTROL0_AIE\t\t(1 << 3)\n+#define RX8130_REG_CONTROL0_AIE\t\tBIT(3)\n \n static irqreturn_t rx8130_irq(int irq, void *dev_id)\n {\n@@ -798,11 +798,11 @@ static int rx8130_alarm_irq_enable(struct device *dev, unsigned int enabled)\n #define MCP794XX_REG_ALARM0_CTRL\t0x0d\n #define MCP794XX_REG_ALARM1_BASE\t0x11\n #define MCP794XX_REG_ALARM1_CTRL\t0x14\n-#\tdefine MCP794XX_BIT_ALMX_IF\t(1 << 3)\n-#\tdefine MCP794XX_BIT_ALMX_C0\t(1 << 4)\n-#\tdefine MCP794XX_BIT_ALMX_C1\t(1 << 5)\n-#\tdefine MCP794XX_BIT_ALMX_C2\t(1 << 6)\n-#\tdefine MCP794XX_BIT_ALMX_POL\t(1 << 7)\n+#\tdefine MCP794XX_BIT_ALMX_IF\tBIT(3)\n+#\tdefine MCP794XX_BIT_ALMX_C0\tBIT(4)\n+#\tdefine MCP794XX_BIT_ALMX_C1\tBIT(5)\n+#\tdefine MCP794XX_BIT_ALMX_C2\tBIT(6)\n+#\tdefine MCP794XX_BIT_ALMX_POL\tBIT(7)\n #\tdefine MCP794XX_MSK_ALMX_MATCH\t(MCP794XX_BIT_ALMX_C0 | \\\n \t\t\t\t\t MCP794XX_BIT_ALMX_C1 | \\\n \t\t\t\t\t MCP794XX_BIT_ALMX_C2)\n@@ -869,7 +869,7 @@ static int mcp794xx_read_alarm(struct device *dev, struct rtc_wkalrm *t)\n \tt->time.tm_isdst = -1;\n \n \tdev_dbg(dev, \"%s, sec=%d min=%d hour=%d wday=%d mday=%d mon=%d \"\n-\t\t\"enabled=%d polarity=%d irq=%d match=%d\\n\", __func__,\n+\t\t\"enabled=%d polarity=%d irq=%d match=%lu\\n\", __func__,\n \t\tt->time.tm_sec, t->time.tm_min, t->time.tm_hour,\n \t\tt->time.tm_wday, t->time.tm_mday, t->time.tm_mon, t->enabled,\n \t\t!!(regs[6] & MCP794XX_BIT_ALMX_POL),\n","prefixes":["4/7"]}