{"id":809770,"url":"http://patchwork.ozlabs.org/api/patches/809770/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/patch/20170904170324.5426-1-aleksander@aleksander.es/","project":{"id":27,"url":"http://patchwork.ozlabs.org/api/projects/27/?format=json","name":"Buildroot development","link_name":"buildroot","list_id":"buildroot.buildroot.org","list_email":"buildroot@buildroot.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170904170324.5426-1-aleksander@aleksander.es>","list_archive_url":null,"date":"2017-09-04T17:03:24","name":"libmbim: udev is optional","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"c1f74c5e3b239006614cb6b4080d081346b38be3","submitter":{"id":48681,"url":"http://patchwork.ozlabs.org/api/people/48681/?format=json","name":"Aleksander Morgado","email":"aleksander@aleksander.es"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/buildroot/patch/20170904170324.5426-1-aleksander@aleksander.es/mbox/","series":[{"id":1425,"url":"http://patchwork.ozlabs.org/api/series/1425/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/list/?series=1425","date":"2017-09-04T17:03:24","name":"libmbim: udev is optional","version":1,"mbox":"http://patchwork.ozlabs.org/series/1425/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809770/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809770/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aleksander-es.20150623.gappssmtp.com\n\theader.i=@aleksander-es.20150623.gappssmtp.com\n\theader.b=\"cU5elQJ2\"; dkim-atps=neutral"],"Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmGQP64Y8z9t16\n\tfor ;\n\tTue, 5 Sep 2017 03:03:41 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3A813860D9;\n\tMon, 4 Sep 2017 17:03:39 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vPyKRL595VYW; Mon, 4 Sep 2017 17:03:38 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F15128607B;\n\tMon, 4 Sep 2017 17:03:37 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id A33A71C0674\n\tfor ;\n\tMon, 4 Sep 2017 17:03:36 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9C161861C9\n\tfor ;\n\tMon, 4 Sep 2017 17:03:36 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id m227dQaC9YAN for ;\n\tMon, 4 Sep 2017 17:03:33 +0000 (UTC)","from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 7973F861BE\n\tfor ; Mon, 4 Sep 2017 17:03:33 +0000 (UTC)","by mail-wm0-f67.google.com with SMTP id r75so844319wmf.1\n\tfor ; Mon, 04 Sep 2017 10:03:33 -0700 (PDT)","from localhost.localdomain\n\t(116.red-83-40-186.dynamicip.rima-tde.net. [83.40.186.116])\n\tby smtp.gmail.com with ESMTPSA id\n\tw6sm6373593wra.25.2017.09.04.10.03.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 10:03:30 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=aleksander-es.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=pLKNBu96JnkCbkfe50ZPQMf3flLFUfevZsbS42bfB0o=;\n\tb=cU5elQJ2VqRsvxG++zhP6D6nWq1ywPmvmsW9NysGg+ioj4F1Ywca/Qtr5ld6jM0xOV\n\txsPnywfwM6hQhOpZDu0fC7ORjaepsV7Y44RMXIUycbFTLh5rPA8pAr3m+NbQMTPaMtQl\n\tuFwRXVuFTcuad5wUyNkjQQOJUH9w5gSfQUGUPgrOXjL2+tn9Li0yBpAJAJzUxUX30nO5\n\tKuWIDnv+LubH7SgUe9IJdca+HwTa9XzNKDymz3GfCfqk7UKscPi6OAMRuz6dy8B0FtIk\n\tPUe+tMwbnZYoezlziC+r5mUT7AwrPas6e/AmggVwMoljngXae1+Nf801C8K6DStGB9ub\n\ti8jw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=pLKNBu96JnkCbkfe50ZPQMf3flLFUfevZsbS42bfB0o=;\n\tb=az5L5yQrUT6sNVGvbmKBv/URgxL5+VeFAQ/XEY7IWC7Q1Zg3lpa0Q49z0xLYxOADNg\n\tAz1heO5f4PdD29j2UMK7RfW5ZqPV4CpxTi/J8G+6yzRULkVv6R75UvxSajxa907f3YiK\n\teWNMLFvr0GUV8ddaCUHXqBmX7+rstH+muGvSAWwtUWmEL59KvsuGaS4R3v+WIZHnclAF\n\tS0/FzDs8EVOB14QIJL1OkIyfsChcZzPMla+LfT9Z/5h8vIv4QnBxxxGp5Di7zrobrjTG\n\tSCXjeb65Sz7In6gNpnE45jhtJsV94Mtw4avy6TVJdEeY+byLH/LG0wAFPOzAD6NiXKv+\n\tHaQA==","X-Gm-Message-State":"AHPjjUjbzXDEpypbU+n1Z9vfj77MzI1Ju9awX06UvZlridxed86MnU54\n\tT8+O822ho/5Nooaak0syjw==","X-Google-Smtp-Source":"ADKCNb4lrslUd9LUsh1XmoE8cPjQtwrQ4e+R09GjAaITD6RnIEQi7WW1dtjEGHmAF/6b+AKBXMeqFw==","X-Received":"by 10.28.94.85 with SMTP id s82mr673297wmb.13.1504544611379;\n\tMon, 04 Sep 2017 10:03:31 -0700 (PDT)","From":"Aleksander Morgado ","To":"buildroot@buildroot.org","Date":"Mon, 4 Sep 2017 19:03:24 +0200","Message-Id":"<20170904170324.5426-1-aleksander@aleksander.es>","X-Mailer":"git-send-email 2.13.1","Cc":"thomas.petazzoni@free-electrons.com,\n\tAleksander Morgado ","Subject":"[Buildroot] [PATCH] libmbim: udev is optional","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "},"content":"Don't require udev/libgudev when building libmbim, just make it\noptional. If there is udev support in the setup, require libgudev and\nconfigure using --with-udev explicitly; otherwise just --without-udev.\n\nSigned-off-by: Aleksander Morgado \n---\n package/libmbim/Config.in | 16 +++++++++++-----\n package/libmbim/libmbim.mk | 9 ++++++++-\n 2 files changed, 19 insertions(+), 6 deletions(-)","diff":"diff --git a/package/libmbim/Config.in b/package/libmbim/Config.in\nindex 4f8059264..35fceca67 100644\n--- a/package/libmbim/Config.in\n+++ b/package/libmbim/Config.in\n@@ -2,8 +2,6 @@ config BR2_PACKAGE_LIBMBIM\n \tbool \"libmbim\"\n \tdepends on BR2_USE_WCHAR # libglib2\n \tdepends on BR2_TOOLCHAIN_HAS_THREADS # libglib2\n-\tdepends on BR2_PACKAGE_HAS_UDEV\n-\tselect BR2_PACKAGE_LIBGUDEV\n \tselect BR2_PACKAGE_LIBGLIB2\n \thelp\n \t libmbim is a glib-based library for talking to WWAN modems and\n@@ -12,6 +10,14 @@ config BR2_PACKAGE_LIBMBIM\n \n \t http://www.freedesktop.org/wiki/Software/libmbim/\n \n-comment \"libmbim needs udev /dev management and a toolchain w/ wchar, threads\"\n-\tdepends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \\\n-\t\t!BR2_PACKAGE_HAS_UDEV\n+if BR2_PACKAGE_LIBMBIM\n+config BR2_PACKAGE_LIBMBIM_UDEV\n+\tbool \"udev support\"\n+\tdepends on BR2_PACKAGE_HAS_UDEV\n+\tselect BR2_PACKAGE_LIBGUDEV\n+\thelp\n+\t This option enables udev support in libmbim\n+endif\n+\n+comment \"libmbim needs a toolchain w/ wchar, threads\"\n+\tdepends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS\ndiff --git a/package/libmbim/libmbim.mk b/package/libmbim/libmbim.mk\nindex 33e500e53..03291a27f 100644\n--- a/package/libmbim/libmbim.mk\n+++ b/package/libmbim/libmbim.mk\n@@ -11,9 +11,16 @@ LIBMBIM_LICENSE = LGPL-2.0+ (library), GPL-2.0+ (programs)\n LIBMBIM_LICENSE_FILES = COPYING\n LIBMBIM_INSTALL_STAGING = YES\n \n-LIBMBIM_DEPENDENCIES = libglib2 udev libgudev\n+LIBMBIM_DEPENDENCIES = libglib2\n \n # we don't want -Werror\n LIBMBIM_CONF_OPTS = --enable-more-warnings=no\n \n+ifeq ($(BR2_PACKAGE_LIBMBIM_UDEV),y)\n+LIBMBIM_DEPENDENCIES += libgudev\n+LIBMBIM_CONF_OPTS += --with-udev\n+else\n+LIBMBIM_CONF_OPTS += --without-udev\n+endif\n+\n $(eval $(autotools-package))\n","prefixes":[]}