{"id":809769,"url":"http://patchwork.ozlabs.org/api/patches/809769/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170904164659.26915-1-n54@gmx.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170904164659.26915-1-n54@gmx.com>","list_archive_url":null,"date":"2017-09-04T16:46:59","name":"[v2] target/m68k: Switch fpu_rom from make_floatx80() to make_floatx80_init()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9df0f8efe88d6b060dcee975e2cd4a055239f261","submitter":{"id":11273,"url":"http://patchwork.ozlabs.org/api/people/11273/?format=json","name":"Kamil Rytarowski","email":"n54@gmx.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170904164659.26915-1-n54@gmx.com/mbox/","series":[{"id":1424,"url":"http://patchwork.ozlabs.org/api/series/1424/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1424","date":"2017-09-04T16:46:59","name":"[v2] target/m68k: Switch fpu_rom from make_floatx80() to make_floatx80_init()","version":2,"mbox":"http://patchwork.ozlabs.org/series/1424/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809769/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809769/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmGKy4nfMz9t16\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  5 Sep 2017 02:59:50 +1000 (AEST)","from localhost ([::1]:54913 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1douiy-000495-Rq\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 12:59:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34186)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from <n54@gmx.com>)\n\tid 1douib-00048F-T2\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:59:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <n54@gmx.com>) id 1douiX-0001uh-17\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:59:25 -0400","from mout.gmx.net ([212.227.17.20]:65023)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <n54@gmx.com>) id 1douiW-0001tW-N9\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:59:20 -0400","from localhost.localdomain ([185.58.161.191]) by mail.gmx.com\n\t(mrgmx102 [212.227.17.174]) with ESMTPSA (Nemesis) id\n\t0Lxdfb-1dQysK25nP-017C80; Mon, 04 Sep 2017 18:59:15 +0200"],"From":"Kamil Rytarowski <n54@gmx.com>","To":"laurent@vivier.eu","Date":"Mon,  4 Sep 2017 18:46:59 +0200","Message-Id":"<20170904164659.26915-1-n54@gmx.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170903163130.14288-1-n54@gmx.com>","References":"<20170903163130.14288-1-n54@gmx.com>","X-Provags-ID":"V03:K0:udiB/vqD8LWfQeB/A62tS5Vk24iDRdvpnCIDy09xYFlZDhxTuwo\n\tku8ncw46QSqvrtg7RfmZi5JKys2GzGkpANUrnRVVb9VdpZLXFg3TC8RqHrg4SiN/tJzV2XG\n\tGcFXIx61NWF3ZFXOBqHrh8BEwvMFv9Sg3OVyogOrgEmVTGukd7/8SQl10LrMuuHINvjga5J\n\tTCzt9eMwG4nUrxbTpipRg==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:c6hfAzP7jTs=:+kjkrWnpiVjE5sluxYcRL+\n\tKWGsmdMc0QIdxul8GOAhiSF0W1/VrrdKD/JJYqSAmwXI3FjWMdCw3g+iHdrKa73rY0T3CGxiq\n\toqnptUvTMlwLaD8lzJpeckPWJHKwFBwI/5rg2kggOE9YYOpVRnQRwHPeZLcn/SpXsPE6BqI4w\n\tQxL70KF9Hoi5AfDAr6NlqW2sdDly5TOX4CBhD2z21F0NS86bn3xuc1+K5Vbql8eRDrcYi1hr1\n\tyG045RNldB3XFsY6t5SOk/I7pL440xNZ5yXcCU7G68S4pasVsWFWfKoORXx9nv+fPD2/GV/E3\n\tMQFXp3BqdOHOfJ+/memKV6ckdqTsOaa4DMZpClWjQhWkuMn/Bvgj+Saq9nqVYMOKorte+AuQ5\n\twXbYLYROgdOLJ+E3OTdV6fNxI8Qr/kD0jRSRVCoyEfnEvANMhuGQdMNWbWMmoxMI2nR2uWy7Y\n\tDee6fHmafD5uI4zRkPVhD5kMxj3/RYF5CIKrWzYkQI8quU+P/hL38pc10CZhU1pp7D+uFvFuz\n\t/ip34CvgbS9qZcHZ8WBWiwRlpUMUlWcA0/kELH9q6250mwKPrp+9ZCdh0h3nEYfgeiQnE4zzR\n\turM8ThavRh0l1EMyVpQqmdWqW8vymaL1pq5EUOQ8ZEYAKdE+V7/oe9Ab14hxpsIeMk8q/zNNd\n\t8Os5mF6HlwQO6b9jb7qnpZnKAKJGSdvnruSjyILHqnZOp92kdQyTBMyMd40HfU5i7MF+sC9Hn\n\tfmv2DUPOTrNd4ysaXjfH5+8eGcfNddRHR0VFPs73vNBEWyfiyQnQrP4BsUZilzd9+MvPUBM6C\n\tmBoCwcPu9qG3ZGllRsFWPMAAzxTTA==","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"212.227.17.20","Subject":"[Qemu-devel] [PATCH v2] target/m68k: Switch fpu_rom from\n\tmake_floatx80() to make_floatx80_init()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"peter.maydell@linaro.org, Kamil Rytarowski <n54@gmx.com>,\n\tqemu-devel@nongnu.org, f4bug@amsat.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"GCC 4.7.2 on SunOS reports that the values assigned to array members are not\nreal constants:\n\ntarget/m68k/fpu_helper.c:32:5: error: initializer element is not constant\ntarget/m68k/fpu_helper.c:32:5: error: (near initialization for 'fpu_rom[0]')\nrules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed\n\nConvert the array to make_floatx80_init() to fix it.\nReplace floatx80_pi-like constants with make_floatx80_init() as they are\ndefined as make_floatx80().\n\nThis fixes build on SmartOS (Joyent).\n\nSigned-off-by: Kamil Rytarowski <n54@gmx.com>\n---\n target/m68k/fpu_helper.c | 44 ++++++++++++++++++++++----------------------\n 1 file changed, 22 insertions(+), 22 deletions(-)","diff":"diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c\nindex bdfc537c68..8afd319ede 100644\n--- a/target/m68k/fpu_helper.c\n+++ b/target/m68k/fpu_helper.c\n@@ -29,28 +29,28 @@\n  */\n \n static const floatx80 fpu_rom[128] = {\n-    [0x00] = floatx80_pi,                                   /* Pi */\n-    [0x0b] = make_floatx80(0x3ffd, 0x9a209a84fbcff798ULL),  /* Log10(2) */\n-    [0x0c] = make_floatx80(0x4000, 0xadf85458a2bb4a9aULL),  /* e        */\n-    [0x0d] = make_floatx80(0x3fff, 0xb8aa3b295c17f0bcULL),  /* Log2(e)  */\n-    [0x0e] = make_floatx80(0x3ffd, 0xde5bd8a937287195ULL),  /* Log10(e) */\n-    [0x0f] = floatx80_zero,                                 /* Zero     */\n-    [0x30] = floatx80_ln2,                                  /* ln(2)    */\n-    [0x31] = make_floatx80(0x4000, 0x935d8dddaaa8ac17ULL),  /* ln(10)   */\n-    [0x32] = floatx80_one,                                  /* 10^0     */\n-    [0x33] = make_floatx80(0x4002, 0xa000000000000000ULL),  /* 10^1     */\n-    [0x34] = make_floatx80(0x4005, 0xc800000000000000ULL),  /* 10^2     */\n-    [0x35] = make_floatx80(0x400c, 0x9c40000000000000ULL),  /* 10^4     */\n-    [0x36] = make_floatx80(0x4019, 0xbebc200000000000ULL),  /* 10^8     */\n-    [0x37] = make_floatx80(0x4034, 0x8e1bc9bf04000000ULL),  /* 10^16    */\n-    [0x38] = make_floatx80(0x4069, 0x9dc5ada82b70b59eULL),  /* 10^32    */\n-    [0x39] = make_floatx80(0x40d3, 0xc2781f49ffcfa6d5ULL),  /* 10^64    */\n-    [0x3a] = make_floatx80(0x41a8, 0x93ba47c980e98ce0ULL),  /* 10^128   */\n-    [0x3b] = make_floatx80(0x4351, 0xaa7eebfb9df9de8eULL),  /* 10^256   */\n-    [0x3c] = make_floatx80(0x46a3, 0xe319a0aea60e91c7ULL),  /* 10^512   */\n-    [0x3d] = make_floatx80(0x4d48, 0xc976758681750c17ULL),  /* 10^1024  */\n-    [0x3e] = make_floatx80(0x5a92, 0x9e8b3b5dc53d5de5ULL),  /* 10^2048  */\n-    [0x3f] = make_floatx80(0x7525, 0xc46052028a20979bULL),  /* 10^4096  */\n+    [0x00] = make_floatx80_init(0x4000, 0x0c90fdaa22168c235LL),  /* Pi       */\n+    [0x0b] = make_floatx80_init(0x3ffd, 0x9a209a84fbcff798ULL),  /* Log10(2) */\n+    [0x0c] = make_floatx80_init(0x4000, 0xadf85458a2bb4a9aULL),  /* e        */\n+    [0x0d] = make_floatx80_init(0x3fff, 0xb8aa3b295c17f0bcULL),  /* Log2(e)  */\n+    [0x0e] = make_floatx80_init(0x3ffd, 0xde5bd8a937287195ULL),  /* Log10(e) */\n+    [0x0f] = make_floatx80_init(0x0000, 0x00000000000000000LL),  /* Zero     */\n+    [0x30] = make_floatx80_init(0x3ffe, 0x0b17217f7d1cf79acLL),  /* ln(2)    */\n+    [0x31] = make_floatx80_init(0x4000, 0x935d8dddaaa8ac17ULL),  /* ln(10)   */\n+    [0x32] = make_floatx80_init(0x3fff, 0x08000000000000000LL),  /* 10^0     */\n+    [0x33] = make_floatx80_init(0x4002, 0xa000000000000000ULL),  /* 10^1     */\n+    [0x34] = make_floatx80_init(0x4005, 0xc800000000000000ULL),  /* 10^2     */\n+    [0x35] = make_floatx80_init(0x400c, 0x9c40000000000000ULL),  /* 10^4     */\n+    [0x36] = make_floatx80_init(0x4019, 0xbebc200000000000ULL),  /* 10^8     */\n+    [0x37] = make_floatx80_init(0x4034, 0x8e1bc9bf04000000ULL),  /* 10^16    */\n+    [0x38] = make_floatx80_init(0x4069, 0x9dc5ada82b70b59eULL),  /* 10^32    */\n+    [0x39] = make_floatx80_init(0x40d3, 0xc2781f49ffcfa6d5ULL),  /* 10^64    */\n+    [0x3a] = make_floatx80_init(0x41a8, 0x93ba47c980e98ce0ULL),  /* 10^128   */\n+    [0x3b] = make_floatx80_init(0x4351, 0xaa7eebfb9df9de8eULL),  /* 10^256   */\n+    [0x3c] = make_floatx80_init(0x46a3, 0xe319a0aea60e91c7ULL),  /* 10^512   */\n+    [0x3d] = make_floatx80_init(0x4d48, 0xc976758681750c17ULL),  /* 10^1024  */\n+    [0x3e] = make_floatx80_init(0x5a92, 0x9e8b3b5dc53d5de5ULL),  /* 10^2048  */\n+    [0x3f] = make_floatx80_init(0x7525, 0xc46052028a20979bULL),  /* 10^4096  */\n };\n \n int32_t HELPER(reds32)(CPUM68KState *env, FPReg *val)\n","prefixes":["v2"]}