{"id":809724,"url":"http://patchwork.ozlabs.org/api/patches/809724/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/cef46365-5695-ee20-c2cf-12cad823d179@infradead.org/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-04T15:35:28","name":"[-next] pinctrl: sprd: fix build errors and dependencies","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c06cae79984e72528a7a126a1bb2266584c0557c","submitter":{"id":18663,"url":"http://patchwork.ozlabs.org/api/people/18663/?format=json","name":"Randy Dunlap","email":"rdunlap@infradead.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/cef46365-5695-ee20-c2cf-12cad823d179@infradead.org/mbox/","series":[{"id":1409,"url":"http://patchwork.ozlabs.org/api/series/1409/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=1409","date":"2017-09-04T15:35:28","name":"[-next] pinctrl: sprd: fix build errors and dependencies","version":1,"mbox":"http://patchwork.ozlabs.org/series/1409/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809724/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809724/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"ahu+T6qZ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmDT45dHvz9t2c\n\tfor ;\n\tTue, 5 Sep 2017 01:35:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753932AbdIDPfi (ORCPT );\n\tMon, 4 Sep 2017 11:35:38 -0400","from bombadil.infradead.org ([65.50.211.133]:54966 \"EHLO\n\tbombadil.infradead.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753748AbdIDPff (ORCPT\n\t); Mon, 4 Sep 2017 11:35:35 -0400","from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16]\n\thelo=midway.dunlap)\n\tby bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dotPP-000132-0b; Mon, 04 Sep 2017 15:35:31 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding:\n\tContent-Type:MIME-Version:Date:Message-ID:Subject:From:To:Sender:Reply-To:Cc:\n\tContent-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:\n\tResent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=CUxY/mue3Evy8XDyndIZI2KggdypeDW9LWaLMVg9E7s=;\n\tb=ahu+T6qZdVTPSeMB95CrVo/2Q\n\t2FlwCLDH1Pbzn/7KtPJgC+nFUq+APERQnwY00GMtxHRkp1CxmqjUpQ/+35su8JsTIG2DhoM2njl4Z\n\tWOdoQfhOJ3yCO8mZlsnnL02fHhxq/pGffKLFv5YfvEO//3WC3twE6GZlU6rgSwiDiSPbyrM+bKhmp\n\t27FcYqW03Wub9raRkkSJR9wVLkFo+xIxMkHm1YQIFgGgeR0R9+LRwzQmfxy7pPDYS63ukqMGIn78S\n\tAgoeL7eH0tBkpQBvhUWHKZ6ew7VUqDnnwQn6o3SpaxYFk9+9uvWK/c9Tpivg4w+OKtlcjhrgkJrHo\n\tY9w93BzBA==;","To":"LKML ,\n\tLinus Walleij ,\n\tBaolin Wang ,\n\t\"linux-gpio@vger.kernel.org\" ","From":"Randy Dunlap ","Subject":"[PATCH -next] pinctrl: sprd: fix build errors and dependencies","Message-ID":"","Date":"Mon, 4 Sep 2017 08:35:28 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"},"content":"From: Randy Dunlap \n\nFix build errors when CONFIG_OF is not enabled.\nAlso, the pinctrl-sprd-sc9860 driver uses functions from the pinctrl-sprd\ndriver, so the former should depend on the latter driver.\n\n../drivers/pinctrl/sprd/pinctrl-sprd.c: In function 'sprd_dt_node_to_map':\n../drivers/pinctrl/sprd/pinctrl-sprd.c:290:2: error: implicit declaration of function 'pinconf_generic_parse_dt_config' [-Werror=implicit-function-declaration]\n ret = pinconf_generic_parse_dt_config(np, pctldev, &configs,\n ^\n../drivers/pinctrl/sprd/pinctrl-sprd.c: At top level:\n../drivers/pinctrl/sprd/pinctrl-sprd.c:844:44: error: array type has incomplete element type\n static const struct pinconf_generic_params sprd_dt_params[] = {\n ^\nSigned-off-by: Randy Dunlap \nCc: Baolin Wang \nCc: Linus Walleij \nCc: linux-gpio@vger.kernel.org\n---\n drivers/pinctrl/sprd/Kconfig | 2 ++\n 1 file changed, 2 insertions(+)\n\nWhy are these drivers not buildable as loadable modules?\nI.e., why bool instead of tristate?\n\n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","diff":"--- linux-next-20170904.orig/drivers/pinctrl/sprd/Kconfig\n+++ linux-next-20170904/drivers/pinctrl/sprd/Kconfig\n@@ -8,10 +8,12 @@ config PINCTRL_SPRD\n \tselect PINCONF\n \tselect GENERIC_PINCONF\n \tselect GENERIC_PINMUX_FUNCTIONS\n+\tdepends on OF\n \thelp\n \t Say Y here to enable Spreadtrum pinctrl driver\n \n config PINCTRL_SPRD_SC9860\n \tbool \"Spreadtrum SC9860 pinctrl driver\"\n+\tdepends on PINCTRL_SPRD\n \thelp\n \t Say Y here to enable Spreadtrum SC9860 pinctrl driver\n","prefixes":["-next"]}