{"id":809679,"url":"http://patchwork.ozlabs.org/api/patches/809679/?format=json","web_url":"http://patchwork.ozlabs.org/project/fwts/patch/20170904131601.19434-1-colin.king@canonical.com/","project":{"id":24,"url":"http://patchwork.ozlabs.org/api/projects/24/?format=json","name":"Firmware Test Suite development","link_name":"fwts","list_id":"fwts-devel.lists.ubuntu.com","list_email":"fwts-devel@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170904131601.19434-1-colin.king@canonical.com>","list_archive_url":null,"date":"2017-09-04T13:16:01","name":"uefi: uefirttime: constify static array dayofmonth","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"28b6a01122634bfb18de2a0ea4fe13ed75719874","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/people/2900/?format=json","name":"Colin Ian King","email":"colin.king@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/fwts/patch/20170904131601.19434-1-colin.king@canonical.com/mbox/","series":[{"id":1381,"url":"http://patchwork.ozlabs.org/api/series/1381/?format=json","web_url":"http://patchwork.ozlabs.org/project/fwts/list/?series=1381","date":"2017-09-04T13:16:01","name":"uefi: uefirttime: constify static array dayofmonth","version":1,"mbox":"http://patchwork.ozlabs.org/series/1381/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809679/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809679/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm9Mn3zjNz9sR9;\n\tMon, 4 Sep 2017 23:16:05 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dorES-0002EV-BW; Mon, 04 Sep 2017 13:16:04 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dorEQ-0002EJ-MR\n\tfor fwts-devel@lists.ubuntu.com; Mon, 04 Sep 2017 13:16:02 +0000","from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1dorEQ-0000Zp-CM; Mon, 04 Sep 2017 13:16:02 +0000"],"From":"Colin King ","To":"fwts-devel@lists.ubuntu.com","Subject":"[PATCH] uefi: uefirttime: constify static array dayofmonth","Date":"Mon, 4 Sep 2017 14:16:01 +0100","Message-Id":"<20170904131601.19434-1-colin.king@canonical.com>","X-Mailer":"git-send-email 2.14.1","MIME-Version":"1.0","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "},"content":"From: Colin Ian King \n\nThe static and read-only array can also be made const\n\nSigned-off-by: Colin Ian King \n---\n src/uefi/uefirttime/uefirttime.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c\nindex 621f53b6..7998f7fd 100644\n--- a/src/uefi/uefirttime/uefirttime.c\n+++ b/src/uefi/uefirttime/uefirttime.c\n@@ -36,7 +36,7 @@\n \t\t((year) % 4 == 0 && ((year) % 100 != 0 || (year) % 400 == 0))\n \n static int fd;\n-static uint32_t dayofmonth[12] = {31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};\n+static const uint32_t dayofmonth[12] = { 31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };\n \n static bool dayvalid(EFI_TIME *Time)\n {\n","prefixes":[]}