{"id":809678,"url":"http://patchwork.ozlabs.org/api/patches/809678/?format=json","web_url":"http://patchwork.ozlabs.org/project/fwts/patch/20170904131313.19236-1-colin.king@canonical.com/","project":{"id":24,"url":"http://patchwork.ozlabs.org/api/projects/24/?format=json","name":"Firmware Test Suite development","link_name":"fwts","list_id":"fwts-devel.lists.ubuntu.com","list_email":"fwts-devel@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170904131313.19236-1-colin.king@canonical.com>","list_archive_url":null,"date":"2017-09-04T13:13:13","name":"uefi: uefirtmisc: make arrays flag static const","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"03053082ef8517d75033a0d769b215cd0b4e9551","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/people/2900/?format=json","name":"Colin Ian King","email":"colin.king@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/fwts/patch/20170904131313.19236-1-colin.king@canonical.com/mbox/","series":[{"id":1380,"url":"http://patchwork.ozlabs.org/api/series/1380/?format=json","web_url":"http://patchwork.ozlabs.org/project/fwts/list/?series=1380","date":"2017-09-04T13:13:13","name":"uefi: uefirtmisc: make arrays flag static const","version":1,"mbox":"http://patchwork.ozlabs.org/series/1380/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809678/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809678/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm9JX5Jkyz9sR9;\n\tMon, 4 Sep 2017 23:13:16 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dorBj-0001xO-Cd; Mon, 04 Sep 2017 13:13:15 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dorBi-0001x5-5k\n\tfor fwts-devel@lists.ubuntu.com; Mon, 04 Sep 2017 13:13:14 +0000","from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1dorBh-0000N1-N1; Mon, 04 Sep 2017 13:13:13 +0000"],"From":"Colin King ","To":"fwts-devel@lists.ubuntu.com","Subject":"[PATCH] uefi: uefirtmisc: make arrays flag static const","Date":"Mon, 4 Sep 2017 14:13:13 +0100","Message-Id":"<20170904131313.19236-1-colin.king@canonical.com>","X-Mailer":"git-send-email 2.14.1","MIME-Version":"1.0","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "},"content":"From: Colin Ian King \n\nThe arrays are read-only and hence can be make static const\n\nSigned-off-by: Colin Ian King \n---\n src/uefi/uefirtmisc/uefirtmisc.c | 24 ++++++++++++++----------\n 1 file changed, 14 insertions(+), 10 deletions(-)","diff":"diff --git a/src/uefi/uefirtmisc/uefirtmisc.c b/src/uefi/uefirtmisc/uefirtmisc.c\nindex 70068c9d..b107a915 100644\n--- a/src/uefi/uefirtmisc/uefirtmisc.c\n+++ b/src/uefi/uefirtmisc/uefirtmisc.c\n@@ -153,11 +153,13 @@ static int uefirtmisc_test1(fwts_framework *fw)\n \tuint32_t multitesttime = 1;\n \tuint32_t i;\n \n-\tuint32_t flag[] = { 0,\n-\t\t\t CAPSULE_FLAGS_PERSIST_ACROSS_RESET,\n-\t\t\t CAPSULE_FLAGS_PERSIST_ACROSS_RESET | CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE,\n-\t\t\t CAPSULE_FLAGS_PERSIST_ACROSS_RESET | CAPSULE_FLAGS_INITIATE_RESET,\n-\t\t\t CAPSULE_FLAGS_PERSIST_ACROSS_RESET | CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE | CAPSULE_FLAGS_INITIATE_RESET};\n+\tstatic const uint32_t flag[] = {\n+\t\t0,\n+\t\tCAPSULE_FLAGS_PERSIST_ACROSS_RESET,\n+\t\tCAPSULE_FLAGS_PERSIST_ACROSS_RESET | CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE,\n+\t\tCAPSULE_FLAGS_PERSIST_ACROSS_RESET | CAPSULE_FLAGS_INITIATE_RESET,\n+\t\tCAPSULE_FLAGS_PERSIST_ACROSS_RESET | CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE | CAPSULE_FLAGS_INITIATE_RESET\n+\t};\n \n \tfwts_log_info(fw, \"Testing UEFI runtime service GetNextHighMonotonicCount interface.\");\n \tret = getnexthighmonotoniccount_test(fw, multitesttime);\n@@ -186,11 +188,13 @@ static int uefirtmisc_test2(fwts_framework *fw)\n \tuint32_t multitesttime = 512;\n \tuint32_t i;\n \n-\tuint32_t flag[] = { 0,\n-\t\t\t CAPSULE_FLAGS_PERSIST_ACROSS_RESET,\n-\t\t\t CAPSULE_FLAGS_PERSIST_ACROSS_RESET | CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE,\n-\t\t\t CAPSULE_FLAGS_PERSIST_ACROSS_RESET | CAPSULE_FLAGS_INITIATE_RESET,\n-\t\t\t CAPSULE_FLAGS_PERSIST_ACROSS_RESET | CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE | CAPSULE_FLAGS_INITIATE_RESET};\n+\tstatic const uint32_t flag[] = {\n+\t\t0,\n+\t\tCAPSULE_FLAGS_PERSIST_ACROSS_RESET,\n+\t\tCAPSULE_FLAGS_PERSIST_ACROSS_RESET | CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE,\n+\t\tCAPSULE_FLAGS_PERSIST_ACROSS_RESET | CAPSULE_FLAGS_INITIATE_RESET,\n+\t\tCAPSULE_FLAGS_PERSIST_ACROSS_RESET | CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE | CAPSULE_FLAGS_INITIATE_RESET\n+\t};\n \n \tfwts_log_info(fw, \"Stress testing for UEFI runtime service GetNextHighMonotonicCount interface.\");\n \tret = getnexthighmonotoniccount_test(fw, multitesttime);\n","prefixes":[]}