{"id":809671,"url":"http://patchwork.ozlabs.org/api/patches/809671/?format=json","web_url":"http://patchwork.ozlabs.org/project/fwts/patch/20170904130041.6286-1-colin.king@canonical.com/","project":{"id":24,"url":"http://patchwork.ozlabs.org/api/projects/24/?format=json","name":"Firmware Test Suite development","link_name":"fwts","list_id":"fwts-devel.lists.ubuntu.com","list_email":"fwts-devel@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170904130041.6286-1-colin.king@canonical.com>","list_archive_url":null,"date":"2017-09-04T13:00:41","name":"dmi: dmicheck: constify array dmi_used_by_kernel_table","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5e162c9729aee32ff8d872945ee8745b75a5ae8b","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/people/2900/?format=json","name":"Colin Ian King","email":"colin.king@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/fwts/patch/20170904130041.6286-1-colin.king@canonical.com/mbox/","series":[{"id":1375,"url":"http://patchwork.ozlabs.org/api/series/1375/?format=json","web_url":"http://patchwork.ozlabs.org/project/fwts/list/?series=1375","date":"2017-09-04T13:00:41","name":"dmi: dmicheck: constify array dmi_used_by_kernel_table","version":1,"mbox":"http://patchwork.ozlabs.org/series/1375/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809671/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809671/checks/","tags":{},"related":[],"headers":{"Return-Path":"<fwts-devel-bounces@lists.ubuntu.com>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=<UNKNOWN>)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm926306vz9sNr;\n\tMon,  4 Sep 2017 23:00:46 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from <fwts-devel-bounces@lists.ubuntu.com>)\n\tid 1doqzc-0000lU-Cn; Mon, 04 Sep 2017 13:00:44 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from <colin.king@canonical.com>)\n\tid 1doqza-0000lO-7l\n\tfor fwts-devel@lists.ubuntu.com; Mon, 04 Sep 2017 13:00:42 +0000","from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1doqzZ-0008JG-SV; Mon, 04 Sep 2017 13:00:42 +0000"],"From":"Colin King <colin.king@canonical.com>","To":"fwts-devel@lists.ubuntu.com","Subject":"[PATCH] dmi: dmicheck: constify array dmi_used_by_kernel_table","Date":"Mon,  4 Sep 2017 14:00:41 +0100","Message-Id":"<20170904130041.6286-1-colin.king@canonical.com>","X-Mailer":"git-send-email 2.14.1","MIME-Version":"1.0","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development <fwts-devel.lists.ubuntu.com>","List-Unsubscribe":"<https://lists.ubuntu.com/mailman/options/fwts-devel>,\n\t<mailto:fwts-devel-request@lists.ubuntu.com?subject=unsubscribe>","List-Archive":"<https://lists.ubuntu.com/archives/fwts-devel>","List-Post":"<mailto:fwts-devel@lists.ubuntu.com>","List-Help":"<mailto:fwts-devel-request@lists.ubuntu.com?subject=help>","List-Subscribe":"<https://lists.ubuntu.com/mailman/listinfo/fwts-devel>,\n\t<mailto:fwts-devel-request@lists.ubuntu.com?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" <fwts-devel-bounces@lists.ubuntu.com>"},"content":"From: Colin Ian King <colin.king@canonical.com>\n\nThe array dmi_used_by_kernel_table is static and read-only so also\nmake it const\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n src/dmi/dmicheck/dmicheck.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c\nindex 20f28b17..61c6b816 100644\n--- a/src/dmi/dmicheck/dmicheck.c\n+++ b/src/dmi/dmicheck/dmicheck.c\n@@ -264,7 +264,7 @@ static const fwts_dmi_version dmi_versions[] = {\n  *  we care that work,\n  *\tsee drivers/firmware/dmi_scan.c, dmi_decode()\n  */\n-static fwts_dmi_used_by_kernel dmi_used_by_kernel_table[] = {\n+static const fwts_dmi_used_by_kernel dmi_used_by_kernel_table[] = {\n \t/* Type 0 BIOS Information fields */\n \t{ 0, 4 },\n \t{ 0, 5 },\n","prefixes":[]}