{"id":809668,"url":"http://patchwork.ozlabs.org/api/patches/809668/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504527967-29248-34-git-send-email-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504527967-29248-34-git-send-email-peter.maydell@linaro.org>","list_archive_url":null,"date":"2017-09-04T12:26:04","name":"[PULL,33/36] hw/arm/aspeed_soc: Mark devices as user_creatable = false","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9036bf52f458680fe6989b5a5bbc82e437c8e459","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504527967-29248-34-git-send-email-peter.maydell@linaro.org/mbox/","series":[{"id":1366,"url":"http://patchwork.ozlabs.org/api/series/1366/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1366","date":"2017-09-04T12:25:36","name":"[PULL,01/36] target/arm: Use MMUAccessType enum rather than int","version":1,"mbox":"http://patchwork.ozlabs.org/series/1366/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809668/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809668/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm8yn4tYlz9sNr\n\tfor ;\n\tMon, 4 Sep 2017 22:57:53 +1000 (AEST)","from localhost ([::1]:60118 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1doqwp-0004A1-Pe\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 08:57:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52928)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1doqSi-0005EK-UQ\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1doqSV-0004zY-IE\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:44 -0400","from orth.archaic.org.uk ([2001:8b0:1d0::2]:37138)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1doqSV-0004yH-BZ\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:31 -0400","from pm215 by orth.archaic.org.uk with local (Exim 4.89)\n\t(envelope-from ) id 1doqSU-0005dZ-Cf\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:26:30 +0100"],"From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Date":"Mon, 4 Sep 2017 13:26:04 +0100","Message-Id":"<1504527967-29248-34-git-send-email-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1504527967-29248-1-git-send-email-peter.maydell@linaro.org>","References":"<1504527967-29248-1-git-send-email-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2001:8b0:1d0::2","Subject":"[Qemu-devel] [PULL 33/36] hw/arm/aspeed_soc: Mark devices as\n\tuser_creatable = false","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Thomas Huth \n\nQEMU currently aborts if the user is accidentially trying to\ndo something like this:\n\n$ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic\nQEMU 2.9.93 monitor - type 'help' for more information\n(qemu) device_add ast2400\nUnexpected error in error_set_from_qdev_prop_error()\n at hw/core/qdev-properties.c:1032:\nAborted (core dumped)\n\nThe ast2400 SoC devices are clearly not creatable by the user since\nthey are using the serial_hds and nd_table arrays directly in their\nrealize function, so mark them with user_creatable = false.\n\nSigned-off-by: Thomas Huth \nReviewed-by: Peter Maydell \nReviewed-by: Cédric Le Goater \nSigned-off-by: Peter Maydell \n---\n hw/arm/aspeed_soc.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c\nindex 22dcac9..13c6393 100644\n--- a/hw/arm/aspeed_soc.c\n+++ b/hw/arm/aspeed_soc.c\n@@ -340,6 +340,8 @@ static void aspeed_soc_class_init(ObjectClass *oc, void *data)\n \n sc->info = (AspeedSoCInfo *) data;\n dc->realize = aspeed_soc_realize;\n+ /* Reason: Uses serial_hds and nd_table in realize() directly */\n+ dc->user_creatable = false;\n }\n \n static const TypeInfo aspeed_soc_type_info = {\n","prefixes":["PULL","33/36"]}