{"id":809658,"url":"http://patchwork.ozlabs.org/api/patches/809658/?format=json","web_url":"http://patchwork.ozlabs.org/project/fwts/patch/20170904125116.25705-1-colin.king@canonical.com/","project":{"id":24,"url":"http://patchwork.ozlabs.org/api/projects/24/?format=json","name":"Firmware Test Suite development","link_name":"fwts","list_id":"fwts-devel.lists.ubuntu.com","list_email":"fwts-devel@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170904125116.25705-1-colin.king@canonical.com>","list_archive_url":null,"date":"2017-09-04T12:51:16","name":"cmos: cmosdump: constify several char * arrays","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ef893fd6d26d1cff5cd6cf674d580e8f2c9d58fa","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/people/2900/?format=json","name":"Colin Ian King","email":"colin.king@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/fwts/patch/20170904125116.25705-1-colin.king@canonical.com/mbox/","series":[{"id":1371,"url":"http://patchwork.ozlabs.org/api/series/1371/?format=json","web_url":"http://patchwork.ozlabs.org/project/fwts/list/?series=1371","date":"2017-09-04T12:51:16","name":"cmos: cmosdump: constify several char * arrays","version":1,"mbox":"http://patchwork.ozlabs.org/series/1371/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809658/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809658/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm8qC42lDz9s75;\n\tMon, 4 Sep 2017 22:51:19 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1doqqU-0008Nq-Ba; Mon, 04 Sep 2017 12:51:18 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1doqqT-0008Ni-F9\n\tfor fwts-devel@lists.ubuntu.com; Mon, 04 Sep 2017 12:51:17 +0000","from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1doqqT-00084e-5i; Mon, 04 Sep 2017 12:51:17 +0000"],"From":"Colin King ","To":"fwts-devel@lists.ubuntu.com","Subject":"[PATCH] cmos: cmosdump: constify several char * arrays","Date":"Mon, 4 Sep 2017 13:51:16 +0100","Message-Id":"<20170904125116.25705-1-colin.king@canonical.com>","X-Mailer":"git-send-email 2.14.1","MIME-Version":"1.0","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "},"content":"From: Colin Ian King \n\nThese arrays are read only and static, so consitfy them too.\n\nSigned-off-by: Colin Ian King \n---\n src/cmos/cmosdump/cmosdump.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/src/cmos/cmosdump/cmosdump.c b/src/cmos/cmosdump/cmosdump.c\nindex 2050f15f..f9e7ed52 100644\n--- a/src/cmos/cmosdump/cmosdump.c\n+++ b/src/cmos/cmosdump/cmosdump.c\n@@ -32,7 +32,7 @@ static int cmosdump_test1(fwts_framework *fw)\n \tint i;\n \tunsigned long tmp;\n \n-\tstatic char *cmos_shutdown_status[] = {\n+\tstatic const char *const cmos_shutdown_status[] = {\n \t\t\"Power on or soft reset\",\n \t\t\"Memory size pass\",\n \t\t\"Memory test pass\",\n@@ -49,7 +49,7 @@ static int cmosdump_test1(fwts_framework *fw)\n \t\t\"Used by 80386\",\n \t};\n \n-\tstatic char *floppy_disk[] = {\n+\tstatic const char *const floppy_disk[] = {\n \t\t\"None\",\n \t\t\"360KB 5.25\\\" Drive\",\n \t\t\"1.2MB 5.25\\\" Drive\",\n@@ -60,7 +60,7 @@ static int cmosdump_test1(fwts_framework *fw)\n \t\t\"Unknown\"\n \t};\n \n-\tstatic char *hard_disk[] = {\n+\tstatic const char *const hard_disk[] = {\n \t\t\"None\",\n \t\t\"Type 1\",\n \t\t\"Unknown\",\n@@ -79,14 +79,14 @@ static int cmosdump_test1(fwts_framework *fw)\n \t\t\"Type 16-47\"\n \t};\n \n-\tstatic char *primary_display[] = {\n+\tstatic const char *const primary_display[] = {\n \t\t\"BIOS selected\",\n \t\t\"CGA 40 column\",\n \t\t\"CGA 80 column\",\n \t\t\"Monochrome\"\n \t};\n \n-\tstatic char *divider[8] = {\n+\tstatic const char *const divider[8] = {\n \t\t\"4.194 MHz\",\n \t\t\"1.049 MHz\",\n \t\t\"32.768 KHz (default)\",\n@@ -97,7 +97,7 @@ static int cmosdump_test1(fwts_framework *fw)\n \t\t\"reset / disable\",\n \t};\n \n-\tstatic char *rate_selection[16] = {\n+\tstatic const char *const rate_selection[16] = {\n \t\t\"none\",\n \t\t\"3.90625 millseconds\",\n \t\t\"7.8215 milliseconds\",\n","prefixes":[]}