{"id":809654,"url":"http://patchwork.ozlabs.org/api/patches/809654/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504527967-29248-26-git-send-email-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504527967-29248-26-git-send-email-peter.maydell@linaro.org>","list_archive_url":null,"date":"2017-09-04T12:25:56","name":"[PULL,25/36] memory.h: Move MemTxResult type to memattrs.h","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"07ff379d99d8aafcfd3e8256e7c00775a01c6faf","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504527967-29248-26-git-send-email-peter.maydell@linaro.org/mbox/","series":[{"id":1366,"url":"http://patchwork.ozlabs.org/api/series/1366/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1366","date":"2017-09-04T12:25:36","name":"[PULL,01/36] target/arm: Use MMUAccessType enum rather than int","version":1,"mbox":"http://patchwork.ozlabs.org/series/1366/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809654/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809654/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm8m36YnPz9t3J\n\tfor ;\n\tMon, 4 Sep 2017 22:48:35 +1000 (AEST)","from localhost ([::1]:59648 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1doqnp-0004kY-Tw\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 08:48:33 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52809)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1doqSd-0005At-7y\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1doqSO-0004u0-50\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:39 -0400","from orth.archaic.org.uk ([2001:8b0:1d0::2]:37130)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1doqSN-0004tI-RZ\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:24 -0400","from pm215 by orth.archaic.org.uk with local (Exim 4.89)\n\t(envelope-from ) id 1doqSM-0005a3-ST\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:26:22 +0100"],"From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Date":"Mon, 4 Sep 2017 13:25:56 +0100","Message-Id":"<1504527967-29248-26-git-send-email-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1504527967-29248-1-git-send-email-peter.maydell@linaro.org>","References":"<1504527967-29248-1-git-send-email-peter.maydell@linaro.org>","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2001:8b0:1d0::2","Subject":"[Qemu-devel] [PULL 25/36] memory.h: Move MemTxResult type to\n\tmemattrs.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Move the MemTxResult type to memattrs.h. We're going to want to\nuse it in cpu/qom.h, which doesn't want to include all of\nmemory.h. In practice MemTxResult and MemTxAttrs are pretty\nclosely linked since both are used for the new-style\nread_with_attrs and write_with_attrs callbacks, so memattrs.h\nis a reasonable home for this rather than creating a whole\nnew header file for it.\n\nSigned-off-by: Peter Maydell \nReviewed-by: Richard Henderson \nReviewed-by: Edgar E. Iglesias \nReviewed-by: Alistair Francis \n---\n include/exec/memattrs.h | 10 ++++++++++\n include/exec/memory.h | 10 ----------\n 2 files changed, 10 insertions(+), 10 deletions(-)","diff":"diff --git a/include/exec/memattrs.h b/include/exec/memattrs.h\nindex e601061..d4a1642 100644\n--- a/include/exec/memattrs.h\n+++ b/include/exec/memattrs.h\n@@ -46,4 +46,14 @@ typedef struct MemTxAttrs {\n */\n #define MEMTXATTRS_UNSPECIFIED ((MemTxAttrs) { .unspecified = 1 })\n \n+/* New-style MMIO accessors can indicate that the transaction failed.\n+ * A zero (MEMTX_OK) response means success; anything else is a failure\n+ * of some kind. The memory subsystem will bitwise-OR together results\n+ * if it is synthesizing an operation from multiple smaller accesses.\n+ */\n+#define MEMTX_OK 0\n+#define MEMTX_ERROR (1U << 0) /* device returned an error */\n+#define MEMTX_DECODE_ERROR (1U << 1) /* nothing at that address */\n+typedef uint32_t MemTxResult;\n+\n #endif\ndiff --git a/include/exec/memory.h b/include/exec/memory.h\nindex 400dd44..1dcd312 100644\n--- a/include/exec/memory.h\n+++ b/include/exec/memory.h\n@@ -112,16 +112,6 @@ static inline void iommu_notifier_init(IOMMUNotifier *n, IOMMUNotify fn,\n n->end = end;\n }\n \n-/* New-style MMIO accessors can indicate that the transaction failed.\n- * A zero (MEMTX_OK) response means success; anything else is a failure\n- * of some kind. The memory subsystem will bitwise-OR together results\n- * if it is synthesizing an operation from multiple smaller accesses.\n- */\n-#define MEMTX_OK 0\n-#define MEMTX_ERROR (1U << 0) /* device returned an error */\n-#define MEMTX_DECODE_ERROR (1U << 1) /* nothing at that address */\n-typedef uint32_t MemTxResult;\n-\n /*\n * Memory region callbacks\n */\n","prefixes":["PULL","25/36"]}