{"id":809626,"url":"http://patchwork.ozlabs.org/api/patches/809626/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504527967-29248-8-git-send-email-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504527967-29248-8-git-send-email-peter.maydell@linaro.org>","list_archive_url":null,"date":"2017-09-04T12:25:38","name":"[PULL,07/36] target/arm: Fix outdated comment about exception exit","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8b7d73fce9041aeca363cf63e83cf8532427da3d","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504527967-29248-8-git-send-email-peter.maydell@linaro.org/mbox/","series":[{"id":1366,"url":"http://patchwork.ozlabs.org/api/series/1366/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1366","date":"2017-09-04T12:25:36","name":"[PULL,01/36] target/arm: Use MMUAccessType enum rather than int","version":1,"mbox":"http://patchwork.ozlabs.org/series/1366/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809626/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809626/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm8HY6CC8z9t1G\n\tfor ;\n\tMon, 4 Sep 2017 22:27:21 +1000 (AEST)","from localhost ([::1]:59527 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1doqTH-000514-Te\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 08:27:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52236)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1doqSA-0004ou-P3\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1doqS3-0004bv-1B\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:10 -0400","from orth.archaic.org.uk ([2001:8b0:1d0::2]:37104)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1doqS2-0004RY-Q0\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:02 -0400","from pm215 by orth.archaic.org.uk with local (Exim 4.89)\n\t(envelope-from ) id 1doqS1-0005Ri-Gj\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:26:01 +0100"],"From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Date":"Mon, 4 Sep 2017 13:25:38 +0100","Message-Id":"<1504527967-29248-8-git-send-email-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1504527967-29248-1-git-send-email-peter.maydell@linaro.org>","References":"<1504527967-29248-1-git-send-email-peter.maydell@linaro.org>","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2001:8b0:1d0::2","Subject":"[Qemu-devel] [PULL 07/36] target/arm: Fix outdated comment about\n\texception exit","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"When we switched our handling of exception exit to detect\nthe magic addresses at translate time rather than via\na do_unassigned_access hook, we forgot to update a\ncomment; correct the omission.\n\nSigned-off-by: Peter Maydell \nReviewed-by: Edgar E. Iglesias \nReviewed-by: Richard Henderson \nMessage-id: 1501692241-23310-8-git-send-email-peter.maydell@linaro.org\n---\n target/arm/helper.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/target/arm/helper.c b/target/arm/helper.c\nindex 8190682..2fb0202 100644\n--- a/target/arm/helper.c\n+++ b/target/arm/helper.c\n@@ -6138,7 +6138,7 @@ static void do_v7m_exception_exit(ARMCPU *cpu)\n bool rettobase = false;\n \n /* We can only get here from an EXCP_EXCEPTION_EXIT, and\n- * arm_v7m_do_unassigned_access() enforces the architectural rule\n+ * gen_bx_excret() enforces the architectural rule\n * that jumps to magic addresses don't have magic behaviour unless\n * we're in Handler mode (compare pseudocode BXWritePC()).\n */\n","prefixes":["PULL","07/36"]}