{"id":809623,"url":"http://patchwork.ozlabs.org/api/patches/809623/?format=json","web_url":"http://patchwork.ozlabs.org/project/fwts/patch/20170904122014.18550-1-colin.king@canonical.com/","project":{"id":24,"url":"http://patchwork.ozlabs.org/api/projects/24/?format=json","name":"Firmware Test Suite development","link_name":"fwts","list_id":"fwts-devel.lists.ubuntu.com","list_email":"fwts-devel@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170904122014.18550-1-colin.king@canonical.com>","list_archive_url":null,"date":"2017-09-04T12:20:14","name":"acpi: method: constify arrays","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0231a14cd1c48a40abb039e5a15bdfa5aecc60d9","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/people/2900/?format=json","name":"Colin Ian King","email":"colin.king@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/fwts/patch/20170904122014.18550-1-colin.king@canonical.com/mbox/","series":[{"id":1365,"url":"http://patchwork.ozlabs.org/api/series/1365/?format=json","web_url":"http://patchwork.ozlabs.org/project/fwts/list/?series=1365","date":"2017-09-04T12:20:14","name":"acpi: method: constify arrays","version":1,"mbox":"http://patchwork.ozlabs.org/series/1365/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809623/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809623/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm87Q680xz9t1G;\n\tMon, 4 Sep 2017 22:20:17 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1doqMS-0004s8-7t; Mon, 04 Sep 2017 12:20:16 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1doqMR-0004s2-Ga\n\tfor fwts-devel@lists.ubuntu.com; Mon, 04 Sep 2017 12:20:15 +0000","from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1doqMR-0006Ro-1X; Mon, 04 Sep 2017 12:20:15 +0000"],"From":"Colin King ","To":"fwts-devel@lists.ubuntu.com","Subject":"[PATCH] acpi: method: constify arrays","Date":"Mon, 4 Sep 2017 13:20:14 +0100","Message-Id":"<20170904122014.18550-1-colin.king@canonical.com>","X-Mailer":"git-send-email 2.14.1","MIME-Version":"1.0","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "},"content":"From: Colin Ian King \n\nConstify some read only arrays\n\nSigned-off-by: Colin Ian King \n---\n src/acpi/method/method.c | 26 +++++++++++++-------------\n 1 file changed, 13 insertions(+), 13 deletions(-)","diff":"diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c\nindex d082fc15..71f0a0ee 100644\n--- a/src/acpi/method/method.c\n+++ b/src/acpi/method/method.c\n@@ -3220,7 +3220,7 @@ static void method_test_CPC_return(\n {\n \tuint8_t revision;\n \n-\tstatic fwts_package_element elementsv1[] = {\n+\tstatic const fwts_package_element elementsv1[] = {\n \t\t{ ACPI_TYPE_INTEGER,\t\"Number of Entries\" },\n \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n \t\t{ ACPI_TYPE_INTBUF,\t\"Highest Performance\" },\n@@ -3240,7 +3240,7 @@ static void method_test_CPC_return(\n \t\t{ ACPI_TYPE_BUFFER,\t\"Enable Register\" }\n \t};\n \n-\tstatic fwts_package_element elementsv2[] = {\n+\tstatic const fwts_package_element elementsv2[] = {\n \t\t{ ACPI_TYPE_INTEGER,\t\"Number of Entries\" },\n \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n \t\t{ ACPI_TYPE_INTBUF,\t\"Highest Performance\" },\n@@ -3264,7 +3264,7 @@ static void method_test_CPC_return(\n \t\t{ ACPI_TYPE_INTBUF,\t\"Reference Performance\" }\n \t};\n \n-\tstatic fwts_package_element elementsv3[] = {\n+\tstatic const fwts_package_element elementsv3[] = {\n \t\t{ ACPI_TYPE_INTEGER,\t\"Number of Entries\" },\n \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n \t\t{ ACPI_TYPE_INTBUF,\t\"Highest Performance\" },\n@@ -4402,7 +4402,7 @@ static void method_test_PUR_return(\n \tACPI_OBJECT *obj,\n \tvoid *private)\n {\n-\tstatic fwts_package_element elements[] = {\n+\tstatic const fwts_package_element elements[] = {\n \t\t{ ACPI_TYPE_INTEGER,\t\"RevisionID\" },\n \t\t{ ACPI_TYPE_INTEGER,\t\"NumProcessors\" },\n \t};\n@@ -4641,7 +4641,7 @@ static void method_test_MBM_return(\n \tACPI_OBJECT *obj,\n \tvoid *private)\n {\n-\tstatic fwts_package_element elements[] = {\n+\tstatic const fwts_package_element elements[] = {\n \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n \t\t{ ACPI_TYPE_INTEGER,\t\"Window Size\" },\n \t\t{ ACPI_TYPE_INTEGER,\t\"Sampling Interval\" },\n@@ -4936,7 +4936,7 @@ static void method_test_SBS_return(\n \tACPI_OBJECT *obj,\n \tvoid *private)\n {\n-\tstatic char *sbs_info[] = {\n+\tstatic const char *sbs_info[] = {\n \t\t\"Maximum 1 Smart Battery, system manager/selector not present\",\n \t\t\"Maximum 1 Smart Battery, system manager/selector present\",\n \t\t\"Maximum 2 Smart Batteries, system manager/selector present\",\n@@ -5002,7 +5002,7 @@ static void method_test_BIF_return(\n {\n \tbool failed = false;\n \n-\tstatic fwts_package_element elements[] = {\n+\tstatic const fwts_package_element elements[] = {\n \t\t{ ACPI_TYPE_INTEGER,\t\"Power Unit\" },\n \t\t{ ACPI_TYPE_INTEGER,\t\"Design Capacity\" },\n \t\t{ ACPI_TYPE_INTEGER,\t\"Last Full Charge Capacity\" },\n@@ -5132,7 +5132,7 @@ static void method_test_BIX_return(\n {\n \tbool failed = false;\n \n-\tstatic fwts_package_element elements[] = {\n+\tstatic const fwts_package_element elements[] = {\n \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n \t\t{ ACPI_TYPE_INTEGER,\t\"Power Unit\" },\n \t\t{ ACPI_TYPE_INTEGER,\t\"Design Capacity\" },\n@@ -5357,7 +5357,7 @@ static int method_test_BST(fwts_framework *fw)\n \n static int method_test_BTP(fwts_framework *fw)\n {\n-\tstatic int values[] = { 0, 1, 100, 200, 0x7fffffff };\n+\tstatic const int values[] = { 0, 1, 100, 200, 0x7fffffff };\n \tint i;\n \n \tfor (i = 0; i < 5; i++) {\n@@ -5418,7 +5418,7 @@ static int method_test_BTH(fwts_framework *fw)\n \n static int method_test_BTM(fwts_framework *fw)\n {\n-\tstatic int values[] = { 0, 1, 100, 200, 0x7fffffff };\n+\tstatic const int values[] = { 0, 1, 100, 200, 0x7fffffff };\n \tint i;\n \n \tfor (i = 0 ; i < 5; i++) {\n@@ -5464,7 +5464,7 @@ static int method_test_BMD(fwts_framework *fw)\n \n static int method_test_BMC(fwts_framework *fw)\n {\n-\tstatic int values[] = { 0, 1, 2, 4 };\n+\tstatic const int values[] = { 0, 1, 2, 4 };\n \tint i;\n \n \tfor (i = 0; i < 4; i++) {\n@@ -5542,7 +5542,7 @@ static void method_test_PIF_return(\n \tACPI_OBJECT *obj,\n \tvoid *private)\n {\n-\tstatic fwts_package_element elements[] = {\n+\tstatic const fwts_package_element elements[] = {\n \t\t{ ACPI_TYPE_INTEGER,\t\"Power Source State\" },\n \t\t{ ACPI_TYPE_INTEGER,\t\"Maximum Output Power\" },\n \t\t{ ACPI_TYPE_INTEGER,\t\"Maximum Input Power\" },\n@@ -6627,7 +6627,7 @@ static void method_test_DOD_return(\n \tuint32_t i;\n \tbool failed = false;\n \n-\tstatic char *dod_type[] = {\n+\tstatic const char *dod_type[] = {\n \t\t\"Other\",\n \t\t\"VGA, CRT or VESA Compatible Analog Monitor\",\n \t\t\"TV/HDTV or other Analog-Video Monitor\",\n","prefixes":[]}