{"id":809518,"url":"http://patchwork.ozlabs.org/api/patches/809518/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1504503988-21903-1-git-send-email-ganeshgr@chelsio.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504503988-21903-1-git-send-email-ganeshgr@chelsio.com>","list_archive_url":null,"date":"2017-09-04T05:46:28","name":"[net-next] cxgb4: fix memory leak","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"36dbe78e882b3ed5205959637ef9ca00fc0354bd","submitter":{"id":69424,"url":"http://patchwork.ozlabs.org/api/people/69424/?format=json","name":"Ganesh Goudar","email":"ganeshgr@chelsio.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1504503988-21903-1-git-send-email-ganeshgr@chelsio.com/mbox/","series":[{"id":1307,"url":"http://patchwork.ozlabs.org/api/series/1307/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=1307","date":"2017-09-04T05:46:28","name":"[net-next] cxgb4: fix memory leak","version":1,"mbox":"http://patchwork.ozlabs.org/series/1307/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809518/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809518/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlzPP3NmDz9s7M\n\tfor ;\n\tMon, 4 Sep 2017 15:46:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753248AbdIDFqr (ORCPT );\n\tMon, 4 Sep 2017 01:46:47 -0400","from stargate.chelsio.com ([12.32.117.8]:38520 \"EHLO\n\tstargate.chelsio.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752632AbdIDFqq (ORCPT\n\t); Mon, 4 Sep 2017 01:46:46 -0400","from localhost (victim.blr.asicdesigners.com [10.193.185.129])\n\tby stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id v845kewG003019; \n\tSun, 3 Sep 2017 22:46:41 -0700"],"From":"Ganesh Goudar ","To":"netdev@vger.kernel.org, davem@davemloft.net","Cc":"nirranjan@chelsio.com, indranil@chelsio.com, venkatesh@chelsio.com,\n\tGanesh Goudar ","Subject":"[PATCH net-next] cxgb4: fix memory leak","Date":"Mon, 4 Sep 2017 11:16:28 +0530","Message-Id":"<1504503988-21903-1-git-send-email-ganeshgr@chelsio.com>","X-Mailer":"git-send-email 2.1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"do not reuse the loop counter which is used iterate over\nthe ports, so that sched_tbl will be freed for all the ports.\n\nSigned-off-by: Ganesh Goudar \n---\n drivers/net/ethernet/chelsio/cxgb4/sched.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c b/drivers/net/ethernet/chelsio/cxgb4/sched.c\nindex 02acff7..9148abb 100644\n--- a/drivers/net/ethernet/chelsio/cxgb4/sched.c\n+++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c\n@@ -533,10 +533,10 @@ struct sched_table *t4_init_sched(unsigned int sched_size)\n void t4_cleanup_sched(struct adapter *adap)\n {\n \tstruct sched_table *s;\n-\tunsigned int i;\n+\tunsigned int j, i;\n \n-\tfor_each_port(adap, i) {\n-\t\tstruct port_info *pi = netdev2pinfo(adap->port[i]);\n+\tfor_each_port(adap, j) {\n+\t\tstruct port_info *pi = netdev2pinfo(adap->port[j]);\n \n \t\ts = pi->sched_tbl;\n \t\tfor (i = 0; i < s->sched_size; i++) {\n","prefixes":["net-next"]}