{"id":809102,"url":"http://patchwork.ozlabs.org/api/patches/809102/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170902155645.19071-1-f.fainelli@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170902155645.19071-1-f.fainelli@gmail.com>","list_archive_url":null,"date":"2017-09-02T15:56:45","name":"[net] net: dsa: loop: Do not unregister invalid fixed PHY","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"4489e89f4b95d73472dd07460079ed670871579e","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/?format=json","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170902155645.19071-1-f.fainelli@gmail.com/mbox/","series":[{"id":1163,"url":"http://patchwork.ozlabs.org/api/series/1163/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=1163","date":"2017-09-02T15:56:45","name":"[net] net: dsa: loop: Do not unregister invalid fixed PHY","version":1,"mbox":"http://patchwork.ozlabs.org/series/1163/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809102/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809102/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"n4wuDVX0\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl12T6n3kz9t0F\n\tfor ;\n\tSun, 3 Sep 2017 01:57:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752766AbdIBP4x (ORCPT );\n\tSat, 2 Sep 2017 11:56:53 -0400","from mail-oi0-f66.google.com ([209.85.218.66]:34858 \"EHLO\n\tmail-oi0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752697AbdIBP4w (ORCPT\n\t); Sat, 2 Sep 2017 11:56:52 -0400","by mail-oi0-f66.google.com with SMTP id n18so2262813oig.2;\n\tSat, 02 Sep 2017 08:56:52 -0700 (PDT)","from cox.net (ip68-109-195-31.pv.oc.cox.net. [68.109.195.31])\n\tby smtp.gmail.com with ESMTPSA id\n\td203sm3209744oif.56.2017.09.02.08.56.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 02 Sep 2017 08:56:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=bsM5YMZsSAZndGGBDuhw5vDdJi7xrVNu4E+mDTqW09Y=;\n\tb=n4wuDVX0yAM6hVFEQQUvvushifmr7SYcZAT2KzEHGKinpG7XEtk6C7qbRTtWzNoo89\n\tGsXz5PTBp2oW0I1dRSlvB9LICwqfaTqoVmafM+cUj3XbUFgV9tXna4wQ+4hyN823E/A0\n\tQBnHIc+c64mXCV1RSvaSV1ctCyyBDTk8uQrnVOyFJFMDRHEMjXuzLTDXJuMVBUG5O8D8\n\t+3TidSubJ6HzTq2Jgx5Sf+2jRN3mexbrKR9ErHyDlF+5uFPu2soTgO8Qs9IY0cqSFfhi\n\tOorBiwz/d36TXN9EUt0bXQIV8EdcXnEuUB+s8gU1TcE2nzvGxnhPzd2MXhH+aGlEWCCj\n\tFG6w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=bsM5YMZsSAZndGGBDuhw5vDdJi7xrVNu4E+mDTqW09Y=;\n\tb=N9IGONo7UjfkRzfQ7xQnXUOAMEhpoSAPc1S7LWDqA5QKzs03iFx2KdtuFWQWbq+rsK\n\tvQSHKUqUSjgqnDVVcKywxijo+l0KVZXYQwuB8tdYv2nDPYKvKKrunuWLQX2lxwQtix+x\n\t9Tl8U4YlZ+8Cs21svODW+M9+TYbn7cSFRkznW6sXQVAxMCJ+T7D8Of1GEE7cvAUvrOhp\n\tbFNXemLr4+U2YeKVSJlO1UIWALg+UPXJFIG5bIXAMfRK3tyHbTmG2TODvPaJlcM1AUZ1\n\tu9rZ47VH9gmhHgPiRbllzJhy6EpMoOpgnZ6T6nPRtRqZ4RMdtpY6/AndXYQS1BzdGts4\n\t9Hlw==","X-Gm-Message-State":"AHPjjUiD5ipMlgOiTTSvGWleWNctZS3F/+kYZAujtfmn1B4NWXrbkD8o\n\txvxlfNCX+YNk8DNn6lg=","X-Google-Smtp-Source":"ADKCNb6TukJ6J6mrPxblqcvkNJzqSBbKVZacsTP9ZMGUJLhQqynUrN6GtvAAY33Ro9QtmBaTL35aSg==","X-Received":"by 10.202.71.5 with SMTP id u5mr4598426oia.56.1504367811262;\n\tSat, 02 Sep 2017 08:56:51 -0700 (PDT)","From":"Florian Fainelli ","To":"netdev@vger.kernel.org","Cc":"Florian Fainelli , Andrew Lunn ,\n\tVivien Didelot ,\n\tlinux-kernel@vger.kernel.org (open list)","Subject":"[PATCH net] net: dsa: loop: Do not unregister invalid fixed PHY","Date":"Sat, 2 Sep 2017 08:56:45 -0700","Message-Id":"<20170902155645.19071-1-f.fainelli@gmail.com>","X-Mailer":"git-send-email 2.11.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"During error injection it was possible to crash in dsa_loop_exit() because of\nan attempt to unregister an invalid PHY. We actually want to the driver probing\nin dsa_loop_init() even though fixed_phy_register() may return an error to\nexercise how DSA deals with such cases, but we should not be crashing during\ndriver removal.\n\nFixes: 98cd1552ea27 (\"net: dsa: Mock-up driver\")\nSigned-off-by: Florian Fainelli \n---\n drivers/net/dsa/dsa_loop.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c\nindex fdd8f3872102..8150e3a3c8dd 100644\n--- a/drivers/net/dsa/dsa_loop.c\n+++ b/drivers/net/dsa/dsa_loop.c\n@@ -390,7 +390,7 @@ static void __exit dsa_loop_exit(void)\n \n \tmdio_driver_unregister(&dsa_loop_drv);\n \tfor (i = 0; i < NUM_FIXED_PHYS; i++)\n-\t\tif (phydevs[i])\n+\t\tif (!IS_ERR(phydevs[i]))\n \t\t\tfixed_phy_unregister(phydevs[i]);\n }\n module_exit(dsa_loop_exit);\n","prefixes":["net"]}