{"id":809100,"url":"http://patchwork.ozlabs.org/api/patches/809100/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1504367034-1000-2-git-send-email-bmeng.cn@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504367034-1000-2-git-send-email-bmeng.cn@gmail.com>","list_archive_url":null,"date":"2017-09-02T15:43:53","name":"[U-Boot,2/3] block: ide: Drop CONFIG_IDE_LED","commit_ref":"caa8bfbc456907fbab92a1c4f5890efcc8fb083e","pull_url":null,"state":"accepted","archived":false,"hash":"c2d8fc10bfdef6d05be6b602e6760c8e5e107356","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/?format=json","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1504367034-1000-2-git-send-email-bmeng.cn@gmail.com/mbox/","series":[{"id":1161,"url":"http://patchwork.ozlabs.org/api/series/1161/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=1161","date":"2017-09-02T15:43:52","name":"[U-Boot,1/3] block: ide: Drop CONFIG_IDE_INIT_POSTRESET","version":1,"mbox":"http://patchwork.ozlabs.org/series/1161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809100/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809100/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vgYuFzag\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl0gg3q9tz9sQl\n\tfor ;\n\tSun, 3 Sep 2017 01:40:47 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 33543C21DC1; Sat, 2 Sep 2017 15:40:35 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E3FFBC21D19;\n\tSat, 2 Sep 2017 15:39:52 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid AA06FC21E55; Sat, 2 Sep 2017 15:39:36 +0000 (UTC)","from mail-it0-f66.google.com (mail-it0-f66.google.com\n\t[209.85.214.66])\n\tby lists.denx.de (Postfix) with ESMTPS id E058CC21E05\n\tfor ; Sat, 2 Sep 2017 15:39:32 +0000 (UTC)","by mail-it0-f66.google.com with SMTP id k189so1174259itk.1\n\tfor ; Sat, 02 Sep 2017 08:39:32 -0700 (PDT)","from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com.\n\t[147.11.156.139]) by smtp.gmail.com with ESMTPSA id\n\tx87sm1425596ita.38.2017.09.02.08.39.30\n\t(version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSat, 02 Sep 2017 08:39:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=J7nXRYllVN9fsWHLt2s9qSVOz/emyPTtJ4ooDvEJl7s=;\n\tb=vgYuFzagu5U5gHNyN1vUEOeXS6MNmXnrWnbY5KmBqsnTBQjvXCaQH2A1xED71nnqq+\n\tLtFOsIGi0QYf45VVc84JHE+vVn6I5qk80tZlWoVlVsUjBDP3h2XP2tEB9QixlRJOJUiW\n\tN3od/obzE8kD5LpsMWk5buG35xCiCIIDH6KanzI4/tAonlPPzH+whiwO0H8/RQHQqTuA\n\tlz4v6h94BeGmJW3dwv1XGzHhw3ATgtvXRsSNTASFps70vE3Bnc3h9n8Q1E8D36LCQXPM\n\tH3ONx53geHoaonRWQOnF2/kr+O7jlKeKWZDBK3eDzUZpRAdkPc5bnyhp27YoROs6BghV\n\ty1xQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=J7nXRYllVN9fsWHLt2s9qSVOz/emyPTtJ4ooDvEJl7s=;\n\tb=b2WpLAVfiV7SxvPmS8D98KsrlDN/gKbxtTrIldL3hwEvT1MRILV63YaahFJuSJ12RN\n\tow50k2NlpL4JwTGaYtHpffyaEhxT+81/3dY1n28bbzVy+Eb/ykAE4MO5mekbf10l4Z4O\n\tnIcO/o/1iAbOKKbbuQ3wvSkzhmSHl+WBYBG9/6pShsp7TZnwy9BJrJo+11dzXJul+VB9\n\tUhQ5ijY2ZT4MyZYfXakVfTiN81dPCtlcXjboQ8INyUZsnrn/p2iCzvmELGLOAVtaTuVT\n\tTmE/VVVlElaK6rEkiibdixwSVA2H8AT2rVWUFgodilsNl/rsYb523Bm/HPuz/gVHQ1Ka\n\t6Wnw==","X-Gm-Message-State":"AHPjjUiiIcfaS3qshQfBn4kQPlTRkAmgvXwr2r648m/ojjPN3toj9pt1\n\tyhKnCCMYQhpyHBX/","X-Google-Smtp-Source":"ADKCNb6+3eEkmdwUPRbVz7P13MW8WorvoAgusLv1oWxBdT0FkuKvhsCs5nB9ZAF4gtr+RagqcvmegQ==","X-Received":"by 10.36.60.151 with SMTP id m145mr1399093ita.101.1504366771725; \n\tSat, 02 Sep 2017 08:39:31 -0700 (PDT)","From":"Bin Meng ","To":"Tom Rini , U-Boot Mailing List ","Date":"Sat, 2 Sep 2017 08:43:53 -0700","Message-Id":"<1504367034-1000-2-git-send-email-bmeng.cn@gmail.com>","X-Mailer":"git-send-email 1.7.9.5","In-Reply-To":"<1504367034-1000-1-git-send-email-bmeng.cn@gmail.com>","References":"<1504367034-1000-1-git-send-email-bmeng.cn@gmail.com>","Subject":"[U-Boot] [PATCH 2/3] block: ide: Drop CONFIG_IDE_LED","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"This is actually not used. Drop it.\n\nSigned-off-by: Bin Meng \n---\n\n drivers/block/ide.c | 46 --------------------------------------------\n include/configs/dbau1x00.h | 1 -\n include/configs/lsxl.h | 1 -\n include/configs/pb1x00.h | 1 -\n include/ide.h | 13 -------------\n scripts/config_whitelist.txt | 1 -\n 6 files changed, 63 deletions(-)","diff":"diff --git a/drivers/block/ide.c b/drivers/block/ide.c\nindex cea0397..ce51153 100644\n--- a/drivers/block/ide.c\n+++ b/drivers/block/ide.c\n@@ -44,12 +44,6 @@ struct blk_desc ide_dev_desc[CONFIG_SYS_IDE_MAXDEVICE];\n #define CONFIG_SYS_ATA_PORT_ADDR(port) (port)\n #endif\n \n-#ifndef CONFIG_IDE_LED\t/* define LED macros, they are not used anyways */\n-# define DEVICE_LED(x) 0\n-# define LED_IDE1 1\n-# define LED_IDE2 2\n-#endif\n-\n #ifdef CONFIG_IDE_RESET\n extern void ide_set_reset(int idereset);\n \n@@ -217,8 +211,6 @@ unsigned char atapi_issue(int device, unsigned char *ccb, int ccblen,\n \tunsigned char c, err, mask, res;\n \tint n;\n \n-\tide_led(DEVICE_LED(device), 1);\t/* LED on */\n-\n \t/* Select device\n \t */\n \tmask = ATA_STAT_BUSY | ATA_STAT_DRQ;\n@@ -326,7 +318,6 @@ unsigned char atapi_issue(int device, unsigned char *ccb, int ccblen,\n \t\terr = 0;\n \t}\n AI_OUT:\n-\tide_led(DEVICE_LED(device), 0);\t/* LED off */\n \treturn err;\n }\n \n@@ -560,7 +551,6 @@ static void ide_ident(struct blk_desc *dev_desc)\n \tdevice = dev_desc->devnum;\n \tprintf(\" Device %d: \", device);\n \n-\tide_led(DEVICE_LED(device), 1);\t/* LED on */\n \t/* Select device\n \t */\n \tide_outb(device, ATA_DEV_HD, ATA_LBA | ATA_DEVICE(device));\n@@ -600,7 +590,6 @@ static void ide_ident(struct blk_desc *dev_desc)\n \t\t\t */\n \t\t\tc = ide_wait(device, IDE_TIME_OUT);\n \t\t}\n-\t\tide_led(DEVICE_LED(device), 0);\t/* LED off */\n \n \t\tif (((c & ATA_STAT_DRQ) == 0) ||\n \t\t ((c & (ATA_STAT_FAULT | ATA_STAT_ERR)) != 0)) {\n@@ -716,22 +705,6 @@ static void ide_ident(struct blk_desc *dev_desc)\n #endif\n }\n \n-__weak void ide_led(uchar led, uchar status)\n-{\n-#if defined(CONFIG_IDE_LED) && defined(PER8_BASE) /* required by LED_PORT */\n-\tstatic uchar led_buffer;\t/* Buffer for current LED status */\n-\n-\tuchar *led_port = LED_PORT;\n-\n-\tif (status)\t\t/* switch LED on */\n-\t\tled_buffer |= led;\n-\telse\t\t\t/* switch LED off */\n-\t\tled_buffer &= ~led;\n-\n-\t*led_port = led_buffer;\n-#endif\n-}\n-\n __weak void ide_outb(int dev, int port, unsigned char val)\n {\n \tdebug(\"ide_outb (dev= %d, port= 0x%x, val= 0x%02x) : @ 0x%08lx\\n\",\n@@ -783,12 +756,6 @@ void ide_init(void)\n \n \tWATCHDOG_RESET();\n \n-\t/*\n-\t * Reset the IDE just to be sure.\n-\t * Light LED's to show\n-\t */\n-\tide_led((LED_IDE1 | LED_IDE2), 1);\t/* LED's on */\n-\n \t/* ATAPI Drives seems to need a proper IDE Reset */\n \tide_reset();\n \n@@ -818,8 +785,6 @@ void ide_init(void)\n \t\t\ti++;\n \t\t\tif (i > (ATA_RESET_TIME * 100)) {\n \t\t\t\tputs(\"** Timeout **\\n\");\n-\t\t\t\t/* LED's off */\n-\t\t\t\tide_led((LED_IDE1 | LED_IDE2), 0);\n \t\t\t\treturn;\n \t\t\t}\n \t\t\tif ((i >= 100) && ((i % 100) == 0))\n@@ -844,10 +809,7 @@ void ide_init(void)\n \n \tputc('\\n');\n \n-\tide_led((LED_IDE1 | LED_IDE2), 0);\t/* LED's off */\n-\n \tfor (i = 0; i < CONFIG_SYS_IDE_MAXDEVICE; ++i) {\n-\t\tint led = (IDE_BUS(i) == 0) ? LED_IDE1 : LED_IDE2;\n \t\tide_dev_desc[i].type = DEV_TYPE_UNKNOWN;\n \t\tide_dev_desc[i].if_type = IF_TYPE_IDE;\n \t\tide_dev_desc[i].devnum = i;\n@@ -862,9 +824,7 @@ void ide_init(void)\n #endif\n \t\tif (!ide_bus_ok[IDE_BUS(i)])\n \t\t\tcontinue;\n-\t\tide_led(led, 1);\t/* LED on */\n \t\tide_ident(&ide_dev_desc[i]);\n-\t\tide_led(led, 0);\t/* LED off */\n \t\tdev_print(&ide_dev_desc[i]);\n \n \t\tif ((ide_dev_desc[i].lba > 0) && (ide_dev_desc[i].blksz > 0)) {\n@@ -987,8 +947,6 @@ ulong ide_read(struct blk_desc *block_dev, lbaint_t blknr, lbaint_t blkcnt,\n \tdebug(\"ide_read dev %d start \" LBAF \", blocks \" LBAF \" buffer at %lX\\n\",\n \t device, blknr, blkcnt, (ulong) buffer);\n \n-\tide_led(DEVICE_LED(device), 1);\t/* LED on */\n-\n \t/* Select device\n \t */\n \tide_outb(device, ATA_DEV_HD, ATA_LBA | ATA_DEVICE(device));\n@@ -1086,7 +1044,6 @@ ulong ide_read(struct blk_desc *block_dev, lbaint_t blknr, lbaint_t blkcnt,\n \t\tbuffer += ATA_BLOCKSIZE;\n \t}\n IDE_READ_E:\n-\tide_led(DEVICE_LED(device), 0);\t/* LED off */\n \treturn n;\n }\n \n@@ -1114,8 +1071,6 @@ ulong ide_write(struct blk_desc *block_dev, lbaint_t blknr, lbaint_t blkcnt,\n \t}\n #endif\n \n-\tide_led(DEVICE_LED(device), 1);\t/* LED on */\n-\n \t/* Select device\n \t */\n \tide_outb(device, ATA_DEV_HD, ATA_LBA | ATA_DEVICE(device));\n@@ -1179,7 +1134,6 @@ ulong ide_write(struct blk_desc *block_dev, lbaint_t blknr, lbaint_t blkcnt,\n \t\tbuffer += ATA_BLOCKSIZE;\n \t}\n WR_OUT:\n-\tide_led(DEVICE_LED(device), 0);\t/* LED off */\n \treturn n;\n }\n \ndiff --git a/include/configs/dbau1x00.h b/include/configs/dbau1x00.h\nindex ce91f10..1207372 100644\n--- a/include/configs/dbau1x00.h\n+++ b/include/configs/dbau1x00.h\n@@ -163,7 +163,6 @@\n #define CONFIG_SYS_IDE_MAXBUS\t\t1\t/* max. 1 IDE bus\t\t*/\n #define CONFIG_SYS_IDE_MAXDEVICE\t1\t/* max. 1 drive per IDE bus\t*/\n \n-#undef\tCONFIG_IDE_LED\t\t\t/* LED for ide not supported\t*/\n #undef\tCONFIG_IDE_RESET\t\t/* reset for ide not supported\t*/\n \n #define CONFIG_SYS_ATA_IDE0_OFFSET\t0x0000\ndiff --git a/include/configs/lsxl.h b/include/configs/lsxl.h\nindex 7cbbe87..5d5851f 100644\n--- a/include/configs/lsxl.h\n+++ b/include/configs/lsxl.h\n@@ -142,7 +142,6 @@\n #endif /* CONFIG_CMD_NET */\n \n #ifdef CONFIG_IDE\n-#undef CONFIG_IDE_LED\n #undef CONFIG_SYS_IDE_MAXBUS\n #define CONFIG_SYS_IDE_MAXBUS\t\t1\n #undef CONFIG_SYS_IDE_MAXDEVICE\ndiff --git a/include/configs/pb1x00.h b/include/configs/pb1x00.h\nindex 369e82f..b7e3196 100644\n--- a/include/configs/pb1x00.h\n+++ b/include/configs/pb1x00.h\n@@ -115,7 +115,6 @@\n #define CONFIG_SYS_IDE_MAXBUS\t\t1\t/* max. 1 IDE bus\t\t*/\n #define CONFIG_SYS_IDE_MAXDEVICE\t1\t/* max. 1 drive per IDE bus\t*/\n \n-#undef\tCONFIG_IDE_LED\t\t\t/* LED for ide not supported\t*/\n #undef\tCONFIG_IDE_RESET\t\t/* reset for ide not supported\t*/\n \n #define CONFIG_SYS_ATA_IDE0_OFFSET\t0x0000\ndiff --git a/include/ide.h b/include/ide.h\nindex a4be763..4d78891 100644\n--- a/include/ide.h\n+++ b/include/ide.h\n@@ -15,19 +15,6 @@\n #define\tATA_CURR_BASE(dev)\t(CONFIG_SYS_ATA_BASE_ADDR+ide_bus_offset[IDE_BUS(dev)])\n extern ulong ide_bus_offset[];\n \n-#ifdef CONFIG_IDE_LED\n-\n-/*\n- * LED Port\n- */\n-#define\tLED_PORT\t((uchar *)(PER8_BASE + 0x3000))\n-#define LED_IDE1\t0x01\n-#define LED_IDE2\t0x02\n-#define\tDEVICE_LED(d)\t((d & 2) | ((d & 2) == 0)) /* depends on bit positions! */\n-\n-void ide_led(uchar led, uchar status);\n-#endif /* CONFIG_IDE_LED */\n-\n /*\n * Function Prototypes\n */\ndiff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt\nindex 440f740..2aa23dc 100644\n--- a/scripts/config_whitelist.txt\n+++ b/scripts/config_whitelist.txt\n@@ -1080,7 +1080,6 @@ CONFIG_I2C_RTC_ADDR\n CONFIG_I2C_TIMEOUT\n CONFIG_ICACHE\n CONFIG_ICS307_REFCLK_HZ\n-CONFIG_IDE_LED\n CONFIG_IDE_PCMCIA\n CONFIG_IDE_PREINIT\n CONFIG_IDE_REG_CS\n","prefixes":["U-Boot","2/3"]}