{"id":809065,"url":"http://patchwork.ozlabs.org/api/patches/809065/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/patch/20170902142853.18011-1-yann.morin.1998@free.fr/","project":{"id":27,"url":"http://patchwork.ozlabs.org/api/projects/27/?format=json","name":"Buildroot development","link_name":"buildroot","list_id":"buildroot.buildroot.org","list_email":"buildroot@buildroot.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170902142853.18011-1-yann.morin.1998@free.fr>","list_archive_url":null,"date":"2017-09-02T14:28:53","name":"package/lzo: enable shared/static libs when needed","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9e7caa0941315997719d11bac9dcaa01d4c0648b","submitter":{"id":13903,"url":"http://patchwork.ozlabs.org/api/people/13903/?format=json","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/buildroot/patch/20170902142853.18011-1-yann.morin.1998@free.fr/mbox/","series":[{"id":1153,"url":"http://patchwork.ozlabs.org/api/series/1153/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/list/?series=1153","date":"2017-09-02T14:28:53","name":"package/lzo: enable shared/static libs when needed","version":1,"mbox":"http://patchwork.ozlabs.org/series/1153/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809065/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809065/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"BLI9KEZH\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkz535GzKz9s7c\n\tfor ;\n\tSun, 3 Sep 2017 00:29:10 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E4F722CAA5;\n\tSat, 2 Sep 2017 14:29:07 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1vBey72AQnPn; Sat, 2 Sep 2017 14:29:07 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 434D52F36B;\n\tSat, 2 Sep 2017 14:29:07 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 857FB1C0306\n\tfor ;\n\tSat, 2 Sep 2017 14:29:06 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7FA8887E60\n\tfor ;\n\tSat, 2 Sep 2017 14:29:06 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id h8Oto3BSYOlS for ;\n\tSat, 2 Sep 2017 14:29:02 +0000 (UTC)","from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id A0B7C87E13\n\tfor ; Sat, 2 Sep 2017 14:29:02 +0000 (UTC)","by mail-wm0-f68.google.com with SMTP id l19so2574510wmi.1\n\tfor ; Sat, 02 Sep 2017 07:29:02 -0700 (PDT)","from localhost.localdomain\n\t(2a01cb0886107300b48a82470a363779.ipv6.abo.wanadoo.fr.\n\t[2a01:cb08:8610:7300:b48a:8247:a36:3779])\n\tby smtp.gmail.com with ESMTPSA id\n\tb70sm2010640wmf.7.2017.09.02.07.28.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 02 Sep 2017 07:28:59 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id;\n\tbh=AQoiGezHRPkaTXWLZDBH7klwZ/tZx9SWVvj+qDqUqIU=;\n\tb=BLI9KEZHjwHE9HbTao6FfT1qFaYRjhbBCOKaIXd4/ITRlIsIi0Cl6tmKFajad+D/Sa\n\tYFcOSaYor2s7czSoczmPxDp0l1TYU/5FXaFLjs4OXwEHbuUgoXkVLwVc3SipKymldkim\n\tsMthndxjwaEuBGjc2EBTHXrLcXpggI4tTitI2GRCSa4RX1OG8YKjwewRwhUCShWEcwXi\n\tU/wcS2R1kRmJY5gvRLH1Mzsi0D+X0YHk61+MtO4I01Yv/g9WDHT7VBp8PzHBtDeyfqyC\n\tQ7M+jofI9nWCEMHbR9HNBXkTs4E8m6NUWIvazsjcoCslh0hJQsl+WHwtKyPLKosAC6lb\n\tngWA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id;\n\tbh=AQoiGezHRPkaTXWLZDBH7klwZ/tZx9SWVvj+qDqUqIU=;\n\tb=PSpqW5o0DaDkP+1vfW+x3/7HZWUYHqXBsRtrQQRkeGJy5BByxxYiLDGYYntyw7fU3e\n\t2zfjX4wmsq3oG/AjTit4kmo+ppzrLhI7oHRKWCT+ZcbU7j+3l8yDPEIhr7p0nisFERwS\n\tuwO8kxOGOBvH6W4To2sgYcYYHPw64hopGvjU5NCWSEvKb6AZ8UKWKbRkza+Pxjs2HvAr\n\tSLUuKDH6sueW1+4GniSpTWw5GV8Koqvv9g4UDrCQSWgg236KILk0KG7fRIyhPII1Vdww\n\tjDEtLWTft7h4/3M26NliVFRHLOtrwFPmVXLZr6/eYjntEfo/ORPzKwyCOjh4wl4gNbm1\n\twRkw==","X-Gm-Message-State":"AHPjjUgoX5zgGqrAJvm39qqwC5cQM9nZsh1shHNRnTDxf+7E9wZgQSPh\n\tR7cb6vhd+Nk77dlo","X-Google-Smtp-Source":"ADKCNb623p96HkPug687Si4TfyovgR2FQvypizLYQu+woRLsM2+hWNeljEi0cSO15trTbHF+V4THAg==","X-Received":"by 10.28.98.5 with SMTP id w5mr391159wmb.51.1504362540718;\n\tSat, 02 Sep 2017 07:29:00 -0700 (PDT)","From":"\"Yann E. MORIN\" ","To":"buildroot@buildroot.org","Date":"Sat, 2 Sep 2017 16:28:53 +0200","Message-Id":"<20170902142853.18011-1-yann.morin.1998@free.fr>","X-Mailer":"git-send-email 2.11.0","Cc":"Bernd Kuhls ,\n\t\"Yann E. MORIN\" ","Subject":"[Buildroot] [PATCH] package/lzo: enable shared/static libs when\n\tneeded","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "},"content":"In 61c4c63 (package/lzo: switch to cmake), building lzo has switched\nfrom autotools to cmake. In the conversion, we've lost the build of the\nshared library, because the cmake-based buildsystem of lzo explcitly\ndisables it by default.\n\nRestore the shared library build.\n\nSigned-off-by: \"Yann E. MORIN\" \nCc: Bernd Kuhls \n\n---\nNote: it was noticed because of an autobuild failure of cairo:\nhttp://autobuild.buildroot.org/results/d51/d51888cbc3a743d53ce38f736ee43953e50bdf61/\nbut it has not been checked wether this patch fixes the build at all.\nYet, the patch is still valid even without fixing the autobuild failure.\n---\n package/lzo/lzo.mk | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/package/lzo/lzo.mk b/package/lzo/lzo.mk\nindex dba965fcd3..27ca459acf 100644\n--- a/package/lzo/lzo.mk\n+++ b/package/lzo/lzo.mk\n@@ -11,5 +11,17 @@ LZO_LICENSE_FILES = COPYING\n LZO_INSTALL_STAGING = YES\n LZO_SUPPORTS_IN_SOURCE_BUILD = NO\n \n+ifeq ($(BR2_SHARED_LIBS)$(BR2_SHARED_STATIC_LIBS),y)\n+LZO_CONF_OPTS += -DENABLE_SHARED=ON\n+else\n+LZO_CONF_OPTS += -DENABLE_SHARED=OFF\n+endif\n+\n+ifeq ($(BR2_STATIC_LIBS)$(BR2_SHARED_STATIC_LIBS),y)\n+LZO_CONF_OPTS += -DENABLE_STATIC=ON\n+else\n+LZO_CONF_OPTS += -DENABLE_STATIC=OFF\n+endif\n+\n $(eval $(cmake-package))\n $(eval $(host-cmake-package))\n","prefixes":[]}