{"id":808985,"url":"http://patchwork.ozlabs.org/api/patches/808985/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20170901203310.GS2323@tucnak/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170901203310.GS2323@tucnak>","list_archive_url":null,"date":"2017-09-01T20:33:10","name":"Fix a pasto in lra-remat.c (reg_overlap_for_remat_p)","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b05b123b30ef091faeac4554feea7c8e1d092ff0","submitter":{"id":671,"url":"http://patchwork.ozlabs.org/api/people/671/?format=json","name":"Jakub Jelinek","email":"jakub@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20170901203310.GS2323@tucnak/mbox/","series":[{"id":1106,"url":"http://patchwork.ozlabs.org/api/series/1106/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=1106","date":"2017-09-01T20:33:10","name":"Fix a pasto in lra-remat.c (reg_overlap_for_remat_p)","version":1,"mbox":"http://patchwork.ozlabs.org/series/1106/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808985/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808985/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461331-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"Px4LgYqG\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jakub@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkWCm2mZ8z9s7M\n\tfor ;\n\tSat, 2 Sep 2017 06:33:23 +1000 (AEST)","(qmail 20752 invoked by alias); 1 Sep 2017 20:33:17 -0000","(qmail 20564 invoked by uid 89); 1 Sep 2017 20:33:16 -0000","from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 01 Sep 2017 20:33:15 +0000","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com\n\t[10.5.11.13])\t(using TLSv1.2 with cipher AECDH-AES256-SHA\n\t(256/256 bits))\t(No client certificate requested)\tby\n\tmx1.redhat.com (Postfix) with ESMTPS id 3329568CE;\n\tFri, 1 Sep 2017 20:33:14 +0000 (UTC)","from tucnak.zalov.cz (ovpn-116-33.ams2.redhat.com\n\t[10.36.116.33])\tby smtp.corp.redhat.com (Postfix) with ESMTPS\n\tid B85C9781E5; Fri, 1 Sep 2017 20:33:13 +0000 (UTC)","from tucnak.zalov.cz (localhost [127.0.0.1])\tby tucnak.zalov.cz\n\t(8.15.2/8.15.2) with ESMTP id v81KXB6h012698;\n\tFri, 1 Sep 2017 22:33:11 +0200","(from jakub@localhost)\tby tucnak.zalov.cz (8.15.2/8.15.2/Submit)\n\tid v81KXAuX012697; Fri, 1 Sep 2017 22:33:10 +0200"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:mime-version\n\t:content-type; q=dns; s=default; b=AN7MDh3Vo40ShC/DckpSDMOmpcUkU\n\t62Kd4YgwbO1XpZxcEkP0zT206840pi/1fQzo6saEWx0hiUU2Nrr5kBxFF2IZRxiC\n\t833wy9h+N+CHwPVX/QkgH2r3X850Ygm1oqCAErwDSMjE0kTscpUm04Je6plmBWrx\n\tI1AMyM6vIvqOkU=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:mime-version\n\t:content-type; s=default; bh=Wg0RJoGYRZKPZ3UbewsgRInSlCk=; b=Px4\n\tLgYqGqiwz6UiPUNG50EU/vx/KFxg9edS9CApdy8OvAsRn9a7DVGgWNpzFvWZIudO\n\tbblJ5dfuflAEzakEKxqbiQZy1J8UR5t4zrYIDyIg0LnVgsJvfS1ibUJinltzhbnQ\n\tEgEtV9oQrRhe1wUBmeutU7fjfZ4n/A0lCbOk5j0E=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=privately,\n\tHx-languages-length:1144, HTo:U*vmakarov","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3329568CE","Date":"Fri, 1 Sep 2017 22:33:10 +0200","From":"Jakub Jelinek ","To":"Vladimir Makarov , Jeff Law ,\n\tBernd Schmidt ","Cc":"gcc-patches@gcc.gnu.org","Subject":"[PATCH] Fix a pasto in lra-remat.c (reg_overlap_for_remat_p)","Message-ID":"<20170901203310.GS2323@tucnak>","Reply-To":"Jakub Jelinek ","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","User-Agent":"Mutt/1.7.1 (2016-10-04)","X-IsSubscribed":"yes"},"content":"Hi!\n\nThis is something that has been reported privately to me.\nThis is in code introduced in\nhttps://gcc.gnu.org/ml/gcc-patches/2016-03/msg00660.html\nand looks indeed like a pasto to me, before the loop there is\na very similar set of stmts without the 2 suffix, and unless\nregno being a hard reg (after possible reg_renumber) implies\nthat regno2 (after possible reg_renumber) is a hard reg, if\nunlucky we might access out of bounds.\n\nI don't have a testcase for this, but have bootstrapped/regtested\nit on x86_64-linux and i686-linux, ok for trunk?\n\n2017-09-01 Jakub Jelinek \n\n\t* lra-remat.c (reg_overlap_for_remat_p): Fix a pasto.\n\n\n\tJakub","diff":"--- gcc/lra-remat.c.jj\t2017-05-25 10:37:00.000000000 +0200\n+++ gcc/lra-remat.c\t2017-09-01 19:42:07.615291583 +0200\n@@ -684,7 +684,7 @@ reg_overlap_for_remat_p (lra_insn_reg *r\n \n \tif (regno2 >= FIRST_PSEUDO_REGISTER && reg_renumber[regno2] >= 0)\n \t regno2 = reg_renumber[regno2];\n-\tif (regno >= FIRST_PSEUDO_REGISTER)\n+\tif (regno2 >= FIRST_PSEUDO_REGISTER)\n \t nregs2 = 1;\n \telse\n \t nregs2 = hard_regno_nregs[regno2][reg->biggest_mode];\n","prefixes":[]}