{"id":808794,"url":"http://patchwork.ozlabs.org/api/patches/808794/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901153758.8628-48-armbru@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170901153758.8628-48-armbru@redhat.com>","list_archive_url":null,"date":"2017-09-01T15:37:58","name":"[PULL,v2,47/47] qapi: drop the sentinel in enum array","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"57cd7e1886f1300b9f25dfab3180f25c81685b6e","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/?format=json","name":"Markus Armbruster","email":"armbru@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901153758.8628-48-armbru@redhat.com/mbox/","series":[{"id":1049,"url":"http://patchwork.ozlabs.org/api/series/1049/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1049","date":"2017-09-01T15:37:14","name":"[PULL,v2,01/47] qapi: Fix error handling code on alternate conflict","version":2,"mbox":"http://patchwork.ozlabs.org/series/1049/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808794/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808794/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkPWF336xz9t2x\n\tfor ;\n\tSat, 2 Sep 2017 02:16:25 +1000 (AEST)","from localhost ([::1]:47142 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnocJ-0002uS-8G\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 12:16:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51831)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dno1Z-0006rF-6q\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dno1S-0001ot-8Z\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:25 -0400","from mx1.redhat.com ([209.132.183.28]:17602)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dno1S-0001oU-3F\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:18 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2BAB061BA6\n\tfor ; Fri, 1 Sep 2017 15:38:17 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 8F897E1CA6;\n\tFri, 1 Sep 2017 15:38:12 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid CE03E1132F50; Fri, 1 Sep 2017 17:37:58 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2BAB061BA6","From":"Markus Armbruster ","To":"qemu-devel@nongnu.org","Date":"Fri, 1 Sep 2017 17:37:58 +0200","Message-Id":"<20170901153758.8628-48-armbru@redhat.com>","In-Reply-To":"<20170901153758.8628-1-armbru@redhat.com>","References":"<20170901153758.8628-1-armbru@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 01 Sep 2017 15:38:17 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL v2 47/47] qapi: drop the sentinel in enum array","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Marc-André Lureau \n\nNow that all usages have been converted to user lookup helpers.\n\nSigned-off-by: Marc-André Lureau \nMessage-Id: <20170822132255.23945-14-marcandre.lureau@redhat.com>\n[Rebased, superfluous local variable dropped, missing\ncheck-qom-proplist.c update added]\nSigned-off-by: Markus Armbruster \nMessage-Id: <1503564371-26090-17-git-send-email-armbru@redhat.com>\n---\n block/parallels.c | 1 -\n scripts/qapi.py | 4 +---\n tests/check-qom-proplist.c | 1 -\n 3 files changed, 1 insertion(+), 5 deletions(-)","diff":"diff --git a/block/parallels.c b/block/parallels.c\nindex cce7336cac..2b6c6e5709 100644\n--- a/block/parallels.c\n+++ b/block/parallels.c\n@@ -72,7 +72,6 @@ static QEnumLookup prealloc_mode_lookup = {\n .array = (const char *const[]) {\n \"falloc\",\n \"truncate\",\n- NULL,\n },\n .size = PRL_PREALLOC_MODE__MAX\n };\ndiff --git a/scripts/qapi.py b/scripts/qapi.py\nindex 39a67270fc..62dc52ed6e 100644\n--- a/scripts/qapi.py\n+++ b/scripts/qapi.py\n@@ -1860,14 +1860,12 @@ const QEnumLookup %(c_name)s_lookup = {\n ''',\n index=index, value=value)\n \n- max_index = c_enum_const(name, '_MAX', prefix)\n ret += mcgen('''\n- [%(max_index)s] = NULL,\n },\n .size = %(max_index)s\n };\n ''',\n- max_index=max_index)\n+ max_index=c_enum_const(name, '_MAX', prefix))\n return ret\n \n \ndiff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c\nindex 07e351f950..92898e1520 100644\n--- a/tests/check-qom-proplist.c\n+++ b/tests/check-qom-proplist.c\n@@ -51,7 +51,6 @@ const QEnumLookup dummy_animal_map = {\n [DUMMY_FROG] = \"frog\",\n [DUMMY_ALLIGATOR] = \"alligator\",\n [DUMMY_PLATYPUS] = \"platypus\",\n- [DUMMY_LAST] = NULL,\n },\n .size = DUMMY_LAST\n };\n","prefixes":["PULL","v2","47/47"]}