{"id":808789,"url":"http://patchwork.ozlabs.org/api/patches/808789/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901153758.8628-42-armbru@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170901153758.8628-42-armbru@redhat.com>","list_archive_url":null,"date":"2017-09-01T15:37:52","name":"[PULL,v2,41/47] qapi: Use qapi_enum_parse() in input_type_enum()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"73cb6d1f549e412bb7d1e1583c665d74dae168b9","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/?format=json","name":"Markus Armbruster","email":"armbru@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901153758.8628-42-armbru@redhat.com/mbox/","series":[{"id":1049,"url":"http://patchwork.ozlabs.org/api/series/1049/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1049","date":"2017-09-01T15:37:14","name":"[PULL,v2,01/47] qapi: Fix error handling code on alternate conflict","version":2,"mbox":"http://patchwork.ozlabs.org/series/1049/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808789/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808789/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkPSJ4VK7z9sRV\n\tfor ;\n\tSat, 2 Sep 2017 02:13:52 +1000 (AEST)","from localhost ([::1]:46992 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnoZp-00005J-T7\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 12:13:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51681)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dno1S-0006hh-6v\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dno1M-0001jt-Qo\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:18 -0400","from mx1.redhat.com ([209.132.183.28]:34516)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dno1M-0001it-LP\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:12 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A81597EAA1\n\tfor ; Fri, 1 Sep 2017 15:38:11 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 66432841DA\n\tfor ; Fri, 1 Sep 2017 15:38:11 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid BB5EE1132F4A; Fri, 1 Sep 2017 17:37:58 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A81597EAA1","From":"Markus Armbruster ","To":"qemu-devel@nongnu.org","Date":"Fri, 1 Sep 2017 17:37:52 +0200","Message-Id":"<20170901153758.8628-42-armbru@redhat.com>","In-Reply-To":"<20170901153758.8628-1-armbru@redhat.com>","References":"<20170901153758.8628-1-armbru@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tFri, 01 Sep 2017 15:38:11 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL v2 41/47] qapi: Use qapi_enum_parse() in\n\tinput_type_enum()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Signed-off-by: Markus Armbruster \nMessage-Id: <1503564371-26090-11-git-send-email-armbru@redhat.com>\nReviewed-by: Marc-André Lureau \n---\n qapi/qapi-visit-core.c | 13 ++++---------\n 1 file changed, 4 insertions(+), 9 deletions(-)","diff":"diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c\nindex ed6d2af462..ec83ff68f9 100644\n--- a/qapi/qapi-visit-core.c\n+++ b/qapi/qapi-visit-core.c\n@@ -14,6 +14,7 @@\n \n #include \"qemu/osdep.h\"\n #include \"qapi/error.h\"\n+#include \"qapi/util.h\"\n #include \"qemu-common.h\"\n #include \"qapi/qmp/qobject.h\"\n #include \"qapi/qmp/qerror.h\"\n@@ -353,7 +354,7 @@ static void input_type_enum(Visitor *v, const char *name, int *obj,\n const char *const strings[], Error **errp)\n {\n Error *local_err = NULL;\n- int64_t value = 0;\n+ int64_t value;\n char *enum_str;\n \n visit_type_str(v, name, &enum_str, &local_err);\n@@ -362,14 +363,8 @@ static void input_type_enum(Visitor *v, const char *name, int *obj,\n return;\n }\n \n- while (strings[value] != NULL) {\n- if (strcmp(strings[value], enum_str) == 0) {\n- break;\n- }\n- value++;\n- }\n-\n- if (strings[value] == NULL) {\n+ value = qapi_enum_parse(strings, enum_str, -1, NULL);\n+ if (value < 0) {\n error_setg(errp, QERR_INVALID_PARAMETER, enum_str);\n g_free(enum_str);\n return;\n","prefixes":["PULL","v2","41/47"]}