{"id":808755,"url":"http://patchwork.ozlabs.org/api/patches/808755/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901153758.8628-46-armbru@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170901153758.8628-46-armbru@redhat.com>","list_archive_url":null,"date":"2017-09-01T15:37:56","name":"[PULL,v2,45/47] qapi: Convert indirect uses of FOO_lookup[...] to qapi_enum_lookup()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cbb645d2e93764d15fbfde5d42a9a7af9ef7ae16","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/?format=json","name":"Markus Armbruster","email":"armbru@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901153758.8628-46-armbru@redhat.com/mbox/","series":[{"id":1049,"url":"http://patchwork.ozlabs.org/api/series/1049/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1049","date":"2017-09-01T15:37:14","name":"[PULL,v2,01/47] qapi: Fix error handling code on alternate conflict","version":2,"mbox":"http://patchwork.ozlabs.org/series/1049/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808755/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808755/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkP3J3mJxz9t3P\n\tfor ;\n\tSat, 2 Sep 2017 01:55:40 +1000 (AEST)","from localhost ([::1]:46559 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnoIE-0006pR-K6\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 11:55:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51782)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dno1W-0006na-L5\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dno1R-0001og-Oc\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:22 -0400","from mx1.redhat.com ([209.132.183.28]:59066)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dno1R-0001oI-JC\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:17 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A099D7D0CA\n\tfor ; Fri, 1 Sep 2017 15:38:16 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 6C947957B1\n\tfor ; Fri, 1 Sep 2017 15:38:12 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid C6CB31132F4E; Fri, 1 Sep 2017 17:37:58 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A099D7D0CA","From":"Markus Armbruster ","To":"qemu-devel@nongnu.org","Date":"Fri, 1 Sep 2017 17:37:56 +0200","Message-Id":"<20170901153758.8628-46-armbru@redhat.com>","In-Reply-To":"<20170901153758.8628-1-armbru@redhat.com>","References":"<20170901153758.8628-1-armbru@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tFri, 01 Sep 2017 15:38:16 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL v2 45/47] qapi: Convert indirect uses of\n\tFOO_lookup[...] to qapi_enum_lookup()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Signed-off-by: Markus Armbruster \nMessage-Id: <1503564371-26090-15-git-send-email-armbru@redhat.com>\nReviewed-by: Marc-André Lureau \n---\n hw/core/qdev-properties.c | 7 +++++--\n qapi/qapi-visit-core.c | 2 +-\n 2 files changed, 6 insertions(+), 3 deletions(-)","diff":"diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c\nindex 078fc5d239..7512bd4379 100644\n--- a/hw/core/qdev-properties.c\n+++ b/hw/core/qdev-properties.c\n@@ -72,7 +72,9 @@ static void set_enum(Object *obj, Visitor *v, const char *name, void *opaque,\n \n static void set_default_value_enum(Object *obj, const Property *prop)\n {\n- object_property_set_str(obj, prop->info->enum_table[prop->defval.i],\n+ object_property_set_str(obj,\n+ qapi_enum_lookup(prop->info->enum_table,\n+ prop->defval.i),\n prop->name, &error_abort);\n }\n \n@@ -1095,7 +1097,8 @@ void qdev_prop_set_enum(DeviceState *dev, const char *name, int value)\n Property *prop;\n \n prop = qdev_prop_find(dev, name);\n- object_property_set_str(OBJECT(dev), prop->info->enum_table[value],\n+ object_property_set_str(OBJECT(dev),\n+ qapi_enum_lookup(prop->info->enum_table, value),\n name, &error_abort);\n }\n \ndiff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c\nindex f285879d72..30dc85b6f3 100644\n--- a/qapi/qapi-visit-core.c\n+++ b/qapi/qapi-visit-core.c\n@@ -345,7 +345,7 @@ static void output_type_enum(Visitor *v, const char *name, int *obj,\n return;\n }\n \n- enum_str = (char *)strings[value];\n+ enum_str = (char *)qapi_enum_lookup(strings, value);\n visit_type_str(v, name, &enum_str, errp);\n }\n \n","prefixes":["PULL","v2","45/47"]}