{"id":808748,"url":"http://patchwork.ozlabs.org/api/patches/808748/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901153758.8628-13-armbru@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170901153758.8628-13-armbru@redhat.com>","list_archive_url":null,"date":"2017-09-01T15:37:23","name":"[PULL,v2,12/47] qlit: Replace open-coded qnum_get_int() by call","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"38a4df3d3c1fdfedf8d06b7a19ddb306e22ff0eb","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/?format=json","name":"Markus Armbruster","email":"armbru@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901153758.8628-13-armbru@redhat.com/mbox/","series":[{"id":1049,"url":"http://patchwork.ozlabs.org/api/series/1049/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1049","date":"2017-09-01T15:37:14","name":"[PULL,v2,01/47] qapi: Fix error handling code on alternate conflict","version":2,"mbox":"http://patchwork.ozlabs.org/series/1049/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808748/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808748/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkP063fDpz9t3P\n\tfor ;\n\tSat, 2 Sep 2017 01:52:54 +1000 (AEST)","from localhost ([::1]:46551 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnoFY-0004Yg-Ha\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 11:52:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51578)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dno1O-0006ft-BH\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dno1J-0001fi-LE\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:14 -0400","from mx1.redhat.com ([209.132.183.28]:34126)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dno1J-0001eh-Em\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:09 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7A6387EAA4\n\tfor ; Fri, 1 Sep 2017 15:38:08 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id A438917C69;\n\tFri, 1 Sep 2017 15:38:03 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 6658811385EF; Fri, 1 Sep 2017 17:37:58 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7A6387EAA4","From":"Markus Armbruster ","To":"qemu-devel@nongnu.org","Date":"Fri, 1 Sep 2017 17:37:23 +0200","Message-Id":"<20170901153758.8628-13-armbru@redhat.com>","In-Reply-To":"<20170901153758.8628-1-armbru@redhat.com>","References":"<20170901153758.8628-1-armbru@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tFri, 01 Sep 2017 15:38:08 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL v2 12/47] qlit: Replace open-coded\n\tqnum_get_int() by call","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Marc-André Lureau \n\nBonus: rids us of a side effect in an assertion.\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Markus Armbruster \nMessage-Id: <20170825105913.4060-10-marcandre.lureau@redhat.com>\nSigned-off-by: Markus Armbruster \n---\n qobject/qlit.c | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)","diff":"diff --git a/qobject/qlit.c b/qobject/qlit.c\nindex 07ad6b05e8..b1d9146220 100644\n--- a/qobject/qlit.c\n+++ b/qobject/qlit.c\n@@ -43,8 +43,6 @@ static void compare_helper(QObject *obj, void *opaque)\n \n bool qlit_equal_qobject(const QLitObject *lhs, const QObject *rhs)\n {\n- int64_t val;\n-\n if (!rhs || lhs->type != qobject_type(rhs)) {\n return false;\n }\n@@ -53,8 +51,7 @@ bool qlit_equal_qobject(const QLitObject *lhs, const QObject *rhs)\n case QTYPE_QBOOL:\n return lhs->value.qbool == qbool_get_bool(qobject_to_qbool(rhs));\n case QTYPE_QNUM:\n- g_assert(qnum_get_try_int(qobject_to_qnum(rhs), &val));\n- return lhs->value.qnum == val;\n+ return lhs->value.qnum == qnum_get_int(qobject_to_qnum(rhs));\n case QTYPE_QSTRING:\n return (strcmp(lhs->value.qstr,\n qstring_get_str(qobject_to_qstring(rhs))) == 0);\n","prefixes":["PULL","v2","12/47"]}