{"id":808704,"url":"http://patchwork.ozlabs.org/api/patches/808704/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170901142602.31108-1-tuomas.tynkkynen@iki.fi/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170901142602.31108-1-tuomas.tynkkynen@iki.fi>","list_archive_url":null,"date":"2017-09-01T14:25:58","name":"[U-Boot,1/5] pci: xilinx: Fix doc comments on config space accessors","commit_ref":"adfc3e4804e89fa1959e447e55bf8707466b8346","pull_url":null,"state":"accepted","archived":false,"hash":"4fc34ce32f24bb56ba8d7cec1b7f05776cb06b2d","submitter":{"id":32296,"url":"http://patchwork.ozlabs.org/api/people/32296/?format=json","name":"Tuomas Tynkkynen","email":"tuomas.tynkkynen@iki.fi"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170901142602.31108-1-tuomas.tynkkynen@iki.fi/mbox/","series":[{"id":1038,"url":"http://patchwork.ozlabs.org/api/series/1038/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=1038","date":"2017-09-01T14:25:58","name":"[U-Boot,1/5] pci: xilinx: Fix doc comments on config space accessors","version":1,"mbox":"http://patchwork.ozlabs.org/series/1038/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808704/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808704/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"POp5+29n\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkM6P0zsvz9t2Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat,  2 Sep 2017 00:28:13 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid D86C0C21E0F; Fri,  1 Sep 2017 14:28:02 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 32ADDC21C72;\n\tFri,  1 Sep 2017 14:28:00 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid A5B3EC21C72; Fri,  1 Sep 2017 14:27:58 +0000 (UTC)","from mail-lf0-f68.google.com (mail-lf0-f68.google.com\n\t[209.85.215.68])\n\tby lists.denx.de (Postfix) with ESMTPS id 3D889C21C3C\n\tfor <u-boot@lists.denx.de>; Fri,  1 Sep 2017 14:27:58 +0000 (UTC)","by mail-lf0-f68.google.com with SMTP id g77so214971lfg.4\n\tfor <u-boot@lists.denx.de>; Fri, 01 Sep 2017 07:27:58 -0700 (PDT)","from duuni.srv.tuxera.com ([194.100.106.190])\n\tby smtp.gmail.com with ESMTPSA id u6sm46130lfk.56.2017.09.01.07.27.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 07:27:56 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id;\n\tbh=T15hJS/91DJSWt1uzkfKZ5hpbeHMe91J3t4/3M1lJjQ=;\n\tb=POp5+29nt/rf28kk7evpgi8XQPD3EIkavhiIlZ3RRbYJ0GE1xeFiZuYkkvfWajHb3C\n\tzrkNpXAG2ZXj8MaE3HUovHBakjvSKnalGm5S2v4ziA+ztrE374oTOBNpSKO52OamiB0p\n\tFilwjpJu8ayVOlwQ/ptwp4+7XX6R/zqN5aV1k/8CqVADeCA8BgaUK6ynAPbT4tn2VRsA\n\tJYF3SxH++6AgMMsAk1Dbfu7eAGz6I/iDYNDESlNpnvrGx+xU6jSAZ6Enyo1u/C6/0kKi\n\t+Npc5asmfeVJsrbjYiuSIlwbg+drtCgpCgkC8kb2+byCiCau9CVQSiqg41Q0ldZLoBAp\n\ttQSg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id;\n\tbh=T15hJS/91DJSWt1uzkfKZ5hpbeHMe91J3t4/3M1lJjQ=;\n\tb=m5ZLi1nrK66jNY8zpAJCHW59nc6EsqfnyMKYUTi8T7wWQUTynb56s/14FGtYpOqBzl\n\tX2tZFctjbnHnXacNsI1/SWXMBAAc4wItkTpJMRQcL1+K/W1c2YJP5W0Kj6mtbkekDd1h\n\tyxtnMA1FtZLh1bdr2rpiHlMKJVCPzlhDYn7S/xguvQe55UjwWPTNMZSSbOBqWXzze01C\n\tndHIoiSGE9jKLJLLOysL31dAUjH2UH2+iNcJXfqADT8DhShNblRmHkLi978ebGlAYMaW\n\tHUYY6iUo31w4uUHYJax8Y8RMWs50Vk5TliLLgjY2GdYPzRUUqqlw0fpz8VMOzzPDFE3t\n\tCEPw==","X-Gm-Message-State":"AHPjjUhUWL0Jdz1ifjioVZy9JpSOnRKW37ns9rdHCzlVa4HkDyN9jWOC\n\t//VEJ5U5CCWJg7m81lI=","X-Google-Smtp-Source":"ADKCNb6FBVnEvzoTzlWR5MhPPeagQcR1YyYz+IARZ1W1mceYV2CTH3CQUYzllRWRsM2KqndKZKjS9w==","X-Received":"by 10.25.154.72 with SMTP id c69mr872733lfe.173.1504276077459;\n\tFri, 01 Sep 2017 07:27:57 -0700 (PDT)","From":"Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>","To":"u-boot@lists.denx.de,\n\tSimon Glass <sjg@chromium.org>","Date":"Fri,  1 Sep 2017 17:25:58 +0300","Message-Id":"<20170901142602.31108-1-tuomas.tynkkynen@iki.fi>","X-Mailer":"git-send-email 2.13.0","Subject":"[U-Boot] [PATCH 1/5] pci: xilinx: Fix doc comments on config space\n\taccessors","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"},"content":"These take the 'struct udevice *' as an argument, not the\n'struct xilinx_pcie *` which is a local variable. Fix the comments to\nmatch the code.\n\nSigned-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>\n---\n drivers/pci/pcie_xilinx.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/pci/pcie_xilinx.c b/drivers/pci/pcie_xilinx.c\nindex 08e2e93445..e31ba8bd51 100644\n--- a/drivers/pci/pcie_xilinx.c\n+++ b/drivers/pci/pcie_xilinx.c\n@@ -87,7 +87,7 @@ static int pcie_xilinx_config_address(struct xilinx_pcie *pcie, pci_dev_t bdf,\n \n /**\n  * pcie_xilinx_read_config() - Read from configuration space\n- * @pcie: Pointer to the PCI controller state\n+ * @bus: Pointer to the PCI bus\n  * @bdf: Identifies the PCIe device to access\n  * @offset: The offset into the device's configuration space\n  * @valuep: A pointer at which to store the read value\n@@ -130,7 +130,7 @@ static int pcie_xilinx_read_config(struct udevice *bus, pci_dev_t bdf,\n \n /**\n  * pcie_xilinx_write_config() - Write to configuration space\n- * @pcie: Pointer to the PCI controller state\n+ * @bus: Pointer to the PCI bus\n  * @bdf: Identifies the PCIe device to access\n  * @offset: The offset into the device's configuration space\n  * @value: The value to write\n","prefixes":["U-Boot","1/5"]}