{"id":808633,"url":"http://patchwork.ozlabs.org/api/patches/808633/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901110332.32650-1-otubo@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170901110332.32650-1-otubo@redhat.com>","list_archive_url":null,"date":"2017-09-01T11:03:32","name":"dma/i82374: avoid double creation of i82374 device","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d1b9a744fa8b483231883e231456e4c568fe83af","submitter":{"id":71779,"url":"http://patchwork.ozlabs.org/api/people/71779/?format=json","name":"Eduardo Otubo","email":"otubo@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901110332.32650-1-otubo@redhat.com/mbox/","series":[{"id":1000,"url":"http://patchwork.ozlabs.org/api/series/1000/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1000","date":"2017-09-01T11:03:32","name":"dma/i82374: avoid double creation of i82374 device","version":1,"mbox":"http://patchwork.ozlabs.org/series/1000/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808633/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808633/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=otubo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkGdL5BF8z9s7p\n\tfor ;\n\tFri, 1 Sep 2017 21:06:10 +1000 (AEST)","from localhost ([::1]:35329 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnjm4-0006Ds-4z\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 07:06:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53168)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnjjq-0004kN-L8\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:03:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnjjj-0003LG-0P\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:03:50 -0400","from mx1.redhat.com ([209.132.183.28]:57520)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnjji-0003L1-Q7; Fri, 01 Sep 2017 07:03:42 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CA4EF3A246;\n\tFri, 1 Sep 2017 11:03:41 +0000 (UTC)","from vader.redhat.com (ovpn-117-156.ams2.redhat.com\n\t[10.36.117.156])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0CC7571C48;\n\tFri, 1 Sep 2017 11:03:37 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CA4EF3A246","From":"Eduardo Otubo ","To":"qemu-devel@nongnu.org","Date":"Fri, 1 Sep 2017 13:03:32 +0200","Message-Id":"<20170901110332.32650-1-otubo@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tFri, 01 Sep 2017 11:03:41 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374\n\tdevice","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, pbonzini@redhat.com, ehabkost@redhat.com,\n\tmst@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"When used with the following command line:\n\n ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374\n\nQEMU with machine type 40p already creates the device i82374. If\nspecified in the command line, it will try to create it again, hence\ngenerating the error. One way to avoid this problem is to set\nuser_creatable=false.\n\nSigned-off-by: Eduardo Otubo \n---\n hw/dma/i82374.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c\nindex 6c0f975df0..5275d822e0 100644\n--- a/hw/dma/i82374.c\n+++ b/hw/dma/i82374.c\n@@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)\n dc->realize = i82374_realize;\n dc->vmsd = &vmstate_i82374;\n dc->props = i82374_properties;\n+ dc->user_creatable = false;\n }\n \n static const TypeInfo i82374_info = {\n","prefixes":[]}