{"id":808516,"url":"http://patchwork.ozlabs.org/api/patches/808516/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504231805-30957-3-git-send-email-douly.fnst@cn.fujitsu.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504231805-30957-3-git-send-email-douly.fnst@cn.fujitsu.com>","list_archive_url":null,"date":"2017-09-01T02:10:03","name":"[v6,2/4] hw/acpi-build: Make assignment statement of next_base easy to read","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6d23557df2f32c83a6bdc276dfaec286d94d7452","submitter":{"id":69629,"url":"http://patchwork.ozlabs.org/api/people/69629/?format=json","name":"Dou Liyang","email":"douly.fnst@cn.fujitsu.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504231805-30957-3-git-send-email-douly.fnst@cn.fujitsu.com/mbox/","series":[{"id":940,"url":"http://patchwork.ozlabs.org/api/series/940/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=940","date":"2017-09-01T02:10:03","name":null,"version":6,"mbox":"http://patchwork.ozlabs.org/series/940/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808516/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808516/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xk2mD5WM5z9sPm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 12:11:22 +1000 (AEST)","from localhost ([::1]:39380 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnbQN-0004a7-Ko\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 22:11:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39754)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <douly.fnst@cn.fujitsu.com>) id 1dnbPi-0004Z9-Bq\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 22:10:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <douly.fnst@cn.fujitsu.com>) id 1dnbPf-0007H2-Hh\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 22:10:30 -0400","from mail.cn.fujitsu.com ([183.91.158.132]:16790\n\thelo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <douly.fnst@cn.fujitsu.com>) id 1dnbPf-0007Fx-7N\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 22:10:27 -0400","from localhost (HELO cn.fujitsu.com) ([10.167.33.5])\n\tby heian.cn.fujitsu.com with ESMTP; 01 Sep 2017 10:10:18 +0800","from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80])\n\tby cn.fujitsu.com (Postfix) with ESMTP id 8C9DC406CF61;\n\tFri,  1 Sep 2017 10:10:19 +0800 (CST)","from localhost.localdomain.localdomain (10.167.226.106) by\n\tG08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Fri, 1 Sep 2017 10:10:19 +0800"],"X-IronPort-AV":"E=Sophos;i=\"5.41,456,1498492800\"; d=\"scan'208\";a=\"25087501\"","From":"Dou Liyang <douly.fnst@cn.fujitsu.com>","To":"<qemu-devel@nongnu.org>","Date":"Fri, 1 Sep 2017 10:10:03 +0800","Message-ID":"<1504231805-30957-3-git-send-email-douly.fnst@cn.fujitsu.com>","X-Mailer":"git-send-email 2.5.5","In-Reply-To":"<1504231805-30957-1-git-send-email-douly.fnst@cn.fujitsu.com>","References":"<1504231805-30957-1-git-send-email-douly.fnst@cn.fujitsu.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-Originating-IP":"[10.167.226.106]","X-yoursite-MailScanner-ID":"8C9DC406CF61.A1085","X-yoursite-MailScanner":"Found to be clean","X-yoursite-MailScanner-From":"douly.fnst@cn.fujitsu.com","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"183.91.158.132","Subject":"[Qemu-devel] [PATCH v6 2/4] hw/acpi-build: Make assignment\n\tstatement of next_base easy to read","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"imammedo@redhat.com, rth@twiddle.net, ehabkost@redhat.com,\n\tDou Liyang <douly.fnst@cn.fujitsu.com>, mst@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"It may be hard to read the assignment statement of \"next_base\", so\n\nS/next_base += (1ULL << 32) - pcms->below_4g_mem_size;\n /next_base = mem_base + mem_len;\n\n... for readability.\n\nNo functionality change.\n\nSigned-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>\n---\n hw/i386/acpi-build.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c\nindex a0cf3bf..48525a1 100644\n--- a/hw/i386/acpi-build.c\n+++ b/hw/i386/acpi-build.c\n@@ -2411,7 +2411,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)\n             }\n             mem_base = 1ULL << 32;\n             mem_len = next_base - pcms->below_4g_mem_size;\n-            next_base += (1ULL << 32) - pcms->below_4g_mem_size;\n+            next_base = mem_base + mem_len;\n         }\n         numamem = acpi_data_push(table_data, sizeof *numamem);\n         build_srat_memory(numamem, mem_base, mem_len, i - 1,\n","prefixes":["v6","2/4"]}