{"id":808395,"url":"http://patchwork.ozlabs.org/api/patches/808395/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170831193543.27543-1-u.kleine-koenig@pengutronix.de/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831193543.27543-1-u.kleine-koenig@pengutronix.de>","list_archive_url":null,"date":"2017-08-31T19:35:43","name":"mtd: mtdchar: handle a block that should be marked bad that already is","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"e6f04cd7e4e55eb039c481678e90d64e3f54ac88","submitter":{"id":1476,"url":"http://patchwork.ozlabs.org/api/people/1476/?format=json","name":"Uwe Kleine-König","email":"u.kleine-koenig@pengutronix.de"},"delegate":{"id":54851,"url":"http://patchwork.ozlabs.org/api/users/54851/?format=json","username":"rw","first_name":"Richard","last_name":"Weinberger","email":"richard@nod.at"},"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170831193543.27543-1-u.kleine-koenig@pengutronix.de/mbox/","series":[{"id":898,"url":"http://patchwork.ozlabs.org/api/series/898/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=898","date":"2017-08-31T19:35:43","name":"mtd: mtdchar: handle a block that should be marked bad that already is","version":1,"mbox":"http://patchwork.ozlabs.org/series/898/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808395/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808395/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"Hquw9ot0\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjt0y4dFvz9s8P\n\tfor ;\n\tFri, 1 Sep 2017 05:36:50 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnVGe-00080W-Vt; Thu, 31 Aug 2017 19:36:45 +0000","from metis.ext.pengutronix.de\n\t([2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnVGG-0007yI-3r\n\tfor linux-mtd@lists.infradead.org; Thu, 31 Aug 2017 19:36:21 +0000","from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7])\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dnVFl-00077W-E2; Thu, 31 Aug 2017 21:35:49 +0200","from ukl by dude.hi.pengutronix.de with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dnVFk-0007Me-RX; Thu, 31 Aug 2017 21:35:48 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To\n\t:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=cfbRgjmazdPQfvTz7cZg2tXosNkbaKULi+XYoX2PUZ0=;\n\tb=Hquw9ot0prBsfY\n\tOudwIf6xYUeV4AybQ76M2goH0D8ANjwJUmEjx9iRBFoCEixnKcxeTyo6KUBs0Jd9wUgbyHEy7xTF2\n\tZPzCj4fd1c0HbV37IsDdd6Y0LDJjv08v5TVVSMqocg46v/36TI1LNLQwIqN37dVVLXikyC8Qxmq+u\n\tpoCyHjygYhB9Ur314YoMFE3iYjTHCCW744/JoDcEu2H1rxTED1kaI5V5iDbhv2SGf4wBcfKrLkZGe\n\tfzGURV0qH3YqzPQIceeF/BiPRvbCI6odSGgjN+dXEkv9CVaHad7ByqCJh+QKAu/IPZSALzNpblVWY\n\ttvZmE7uOElrt5HnsD3vw==;","From":"=?utf-8?q?Uwe_Kleine-K=C3=B6nig?= ","To":"David Woodhouse ,\n\tBrian Norris ,\n\tBoris Brezillon ,\n\tMarek Vasut ,\n\tRichard Weinberger , \n\tCyrille Pitchen ","Subject":"[PATCH] mtd: mtdchar: handle a block that should be marked bad that\n\talready is","Date":"Thu, 31 Aug 2017 21:35:43 +0200","Message-Id":"<20170831193543.27543-1-u.kleine-koenig@pengutronix.de>","X-Mailer":"git-send-email 2.11.0","MIME-Version":"1.0","X-SA-Exim-Connect-IP":"2001:67c:670:100:1d::7","X-SA-Exim-Mail-From":"ukl@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"linux-mtd@lists.infradead.org","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170831_123620_363231_6A4C56B1 ","X-CRM114-Status":"GOOD ( 10.29 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-mtd@lists.infradead.org, kernel@pengutronix.de","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Otherwise at least /sys/class/mtd/mtdX/bad_blocks is increased each time\nthe same block is remarked as bad.\n\nSigned-off-by: Uwe Kleine-König \n---\n drivers/mtd/mtdchar.c | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c\nindex 3568294d4854..049496a1d7a5 100644\n--- a/drivers/mtd/mtdchar.c\n+++ b/drivers/mtd/mtdchar.c\n@@ -916,6 +916,11 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)\n \n \t\tif (copy_from_user(&offs, argp, sizeof(loff_t)))\n \t\t\treturn -EFAULT;\n+\n+\t\tif (mtd_block_isbad(mtd, offs))\n+\t\t\t/* already done */\n+\t\t\treturn 0;\n+\n \t\treturn mtd_block_markbad(mtd, offs);\n \t\tbreak;\n \t}\n","prefixes":[]}